From 9e9479d6b0d9d86af54f883d16a0e35fd74fc641 Mon Sep 17 00:00:00 2001 From: Andrii Nikitin Date: Wed, 7 Oct 2020 12:43:32 +0200 Subject: [PATCH] Fix MQ timeouts in rabbit-repoid AMQP Server on practice sometimes closes connection when update_repo() is busy in gocd/rabbit-repoid.py. Doing the same work just in still_alive() seems be sufficient and fixes the same problem in local environment. --- gocd/rabbit-repoid.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gocd/rabbit-repoid.py b/gocd/rabbit-repoid.py index d9f5e6b0..8177ccb4 100755 --- a/gocd/rabbit-repoid.py +++ b/gocd/rabbit-repoid.py @@ -32,8 +32,8 @@ class Listener(PubSubConsumer): return super(Listener, self).interval() def still_alive(self): - self.check_some_repos() super(Listener, self).still_alive() + self.check_some_repos() def routing_keys(self): return [self.amqp_prefix + '.obs.repo.build_finished'] @@ -106,7 +106,6 @@ class Listener(PubSubConsumer): def on_message(self, unused_channel, method, properties, body): self.logger.debug("on_message") - self.check_some_repos() self.acknowledge_message(method.delivery_tag) try: body = json.loads(body)