yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

leaper: proper maintainer review rule

Browse Source 
After moved to ReviewBot from maintbot, follow the old rule of
adding maintainer review, skip maintainer review if submission is from
SLE; SLE's SP; Leap and Leap:Update.
This commit is contained in:
Max Lin 2018-08-28 18:16:45 +08:00
parent 541b94d1d0
commit cf87c26486
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
leaper.py
View File

@ -294,6 +294,8 @@ class Leaper(ReviewBot.ReviewBot):
elif origin.startswith('openSUSE:Leap:15.0'): elif origin.startswith('openSUSE:Leap:15.0'):
if self.must_approve_maintenance_updates: if self.must_approve_maintenance_updates:
self.needs_release_manager = True self.needs_release_manager = True
if src_project.startswith('openSUSE:Leap'):
self.do_check_maintainer_review = False
# submitted from :Update # submitted from :Update
if origin_same: if origin_same:
self.logger.debug("submission from 15.0 ok") self.logger.debug("submission from 15.0 ok")
@ -301,6 +303,7 @@ class Leaper(ReviewBot.ReviewBot):
# switching to sle package might make sense # switching to sle package might make sense
if src_project.startswith('SUSE:SLE-15'): if src_project.startswith('SUSE:SLE-15'):
self.needs_release_manager = True self.needs_release_manager = True
self.do_check_maintainer_review = False
return True return True
# submitted from elsewhere but is in :Update # submitted from elsewhere but is in :Update
else: else:
@ -338,6 +341,8 @@ class Leaper(ReviewBot.ReviewBot):
elif origin.startswith('SUSE:SLE-15'): elif origin.startswith('SUSE:SLE-15'):
if self.must_approve_maintenance_updates: if self.must_approve_maintenance_updates:
self.needs_release_manager = True self.needs_release_manager = True
if src_project.startswith('SUSE:SLE-15'):
self.do_check_maintainer_review = False
for v in ('15.0', '15.1'): for v in ('15.0', '15.1'):
prj = 'openSUSE:Leap:{}:SLE-workarounds'.format(v) prj = 'openSUSE:Leap:{}:SLE-workarounds'.format(v)
if self.is_package_in_project( prj, target_package): if self.is_package_in_project( prj, target_package):