yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

origin-manager: indicate the decision may be overridden via command.

Browse Source
This commit is contained in:
Jimmy Berry 2019-11-07 14:01:59 -06:00
parent 9503a04b33
commit d02f06898c
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
origin-manager.py
View File

@ -169,6 +169,9 @@ class OriginManager(ReviewBot.ReviewBot):
return False, None
def policy_result_handle(self, project, package, origin_info_new, origin_info_old, result):
if result.wait and not result.accept:
result.comments.append(f'Decision may be overridden via `@{self.review_user} override`.')
self.policy_result_reviews_add(project, package, result.reviews, origin_info_new, origin_info_old)
self.policy_result_comment_add(project, package, result.comments)

3
tests/origin_tests.py
View File

@ -142,11 +142,13 @@ class TestOrigin(OBSLocal.TestCase):
'<!-- OriginManager state=seen result=None -->',
'Source not found in allowed origins:',
'- fakeProject',
f'Decision may be overridden via `@{self.bot_user} override`.',
]
self.assertComment(request.reqid, comment)
self.origin_config_write([{'fakeProject': {}}], {'unknown_origin_wait': False})
self.assertReviewBot(request.reqid, self.bot_user, 'new', 'declined', 'review failed')
comment.pop()
self.assertComment(request.reqid, comment)
def test_devel_only(self):
@ -176,6 +178,7 @@ class TestOrigin(OBSLocal.TestCase):
'<!-- OriginManager state=seen result=None -->',
'Source not found in allowed origins:',
f'- {self.product_project}',
f'Decision may be overridden via `@{self.bot_user} override`.',
]
self.assertComment(request.reqid, comment)