yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement accept-onpass review mode

Browse Source 
For maintenance we want to have the openqa review open until the tests
are fixed - and only humans decline
This commit is contained in:
Stephan Kulow 2016-08-05 07:41:30 +02:00
parent 83044e225a
commit d03e4f940a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ReviewBot.py
View File

@ -1,5 +1,5 @@
#!/usr/bin/python #!/usr/bin/python
# Copyright (c) 2014 SUSE Linux Products GmbH # Copyright (c) 2014-2016 SUSE LLC
# #
# Permission is hereby granted, free of charge, to any person obtaining a copy # Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal # of this software and associated documentation files (the "Software"), to deal
@ -48,7 +48,7 @@ class ReviewBot(object):
""" """
DEFAULT_REVIEW_MESSAGES = { 'accepted' : 'ok', 'declined': 'review failed' } DEFAULT_REVIEW_MESSAGES = { 'accepted' : 'ok', 'declined': 'review failed' }
REVIEW_CHOICES = ('normal', 'no', 'accept', 'fallback-onfail', 'fallback-always') REVIEW_CHOICES = ('normal', 'no', 'accept', 'accept-onpass', 'fallback-onfail', 'fallback-always')
def __init__(self, apiurl = None, dryrun = False, logger = None, user = None, group = None): def __init__(self, apiurl = None, dryrun = False, logger = None, user = None, group = None):
self.apiurl = apiurl self.apiurl = apiurl
@ -102,7 +102,7 @@ class ReviewBot(object):
self.logger.info("%s ignored"%req.reqid) self.logger.info("%s ignored"%req.reqid)
elif good: elif good:
self._set_review(req, 'accepted') self._set_review(req, 'accepted')
else: elif self.review_mode != 'accept-onpass':
self._set_review(req, 'declined') self._set_review(req, 'declined')
def _set_review(self, req, state): def _set_review(self, req, state):