Merge pull request #1491 from jberry-suse/ReviewBot-replace-default-handler

ReviewBot: replace default handler for legal-auto and check_tags_in_requests

check_tags_in_requests.py

@@ -67,6 +67,7 @@ See also https://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Current_s
 Note that not all of the tags listed there are necessarily supported
 by OBS on which this bot relies.
 """
+        self.request_default_return = True
 
     def isNewPackage(self, tgt_project, tgt_package):
         try:
@@ -143,13 +144,6 @@ by OBS on which this bot relies.
     def check_action_maintenance_release(self, req, a):
         return self.checkTagInRequest(req, a)
 
-    def check_action__default(self, req, a):
-        # accept all other requests
-        self.logger.debug("auto accept request type %s"%a.type)
-        return True
-
-
-
 
 class CommandLineInterface(ReviewBot.CommandLineInterface):
 

legal-auto.py

@@ -60,6 +60,7 @@ class LegalAuto(ReviewBot.ReviewBot):
         else:
             self.apinick = 'obs#'
         self.override_allow = False # Handled via external tool.
+        self.request_default_return = True
 
     def request_priority(self):
         prio = self.request.priority or 'moderate'
@@ -135,10 +136,6 @@ class LegalAuto(ReviewBot.ReviewBot):
         self.message = 'ok'
         return True
 
-    def check_action__default(self, req, a):
-        self.logger.error("unhandled request type %s" % a.type)
-        return True
-
     def prepare_review(self):
         url = osc.core.makeurl(self.legaldb, ['requests'])
         req = REQ.get(url, headers=self.legaldb_headers).json()