yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename the function for better understanding.

Browse Source
This commit is contained in:
Tomáš Chvátal 2014-02-10 13:37:39 +01:00
parent e89cfb02a8
commit ed330caaeb
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osc-staging.py
View File

@ -97,16 +97,13 @@ class StagingApi(object):
root = ET.parse(f).getroot() root = ET.parse(f).getroot()
return root.attrib['code'] return root.attrib['code']
def consolidate_review_request(self, request): def accept_non_ring_request(self, request):
""" """
Accept review of requests that are not yet in Accept review of requests that are not yet in
any ring so we don't delay their testing. any ring so we don't delay their testing.
:param request: request to check :param request: request to check
""" """
# FIXME: move this to activity class from api
# FIXME: verify the state of the submission not just the ring
# Consolidate all data from request # Consolidate all data from request
request_id = int(request.get('id')) request_id = int(request.get('id'))
action = request.findall('action') action = request.findall('action')
@ -121,7 +118,7 @@ class StagingApi(object):
# If the values are empty it is no error # If the values are empty it is no error
if not target_project or not target_pacakge: if not target_project or not target_pacakge:
e.append('no target/package in request {0}, action {1}; '.format(id, action)) logging.info('no target/package in request {0}, action {1}; '.format(id, action))
# Verify the package ring # Verify the package ring
ring = self.ring_packages.get(tpkg, None) ring = self.ring_packages.get(tpkg, None)
@ -161,7 +158,7 @@ class StagingApi(object):
requests = self.get_open_requests() requests = self.get_open_requests()
# check if we can reduce it down by accepting some # check if we can reduce it down by accepting some
for rq in requests: for rq in requests:
self.consolidate_review_request(rq) self.accept_non_ring_request(rq)
# FIXME: dispatch to various staging projects automatically # FIXME: dispatch to various staging projects automatically