From ee7cdc2a9058e0dfc34f8e7bba7efff6817388c5 Mon Sep 17 00:00:00 2001 From: Ludwig Nussel Date: Tue, 5 Feb 2019 08:24:16 +0100 Subject: [PATCH] ReviewBot: catch exception for adding devel project review if the bot is run on requests it has no role it, adding devel project review may fail. So just handle that and proceed. --- ReviewBot.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ReviewBot.py b/ReviewBot.py index 995bc7c6..efe0ecd3 100644 --- a/ReviewBot.py +++ b/ReviewBot.py @@ -309,7 +309,15 @@ class ReviewBot(object): self.logger.warning('no devel project found for {}/{}'.format(project, package)) return False - self.add_review(request, by_project=devel_project, by_package=devel_package, msg=message) + try: + self.add_review(request, by_project=devel_project, by_package=devel_package, msg=message) + except HTTPError as e: + # could happen when the bot is not actually a reviewer and has no permissions + if e.code != 403: + raise e + self.logger.error('failed to add devel project review for {}/{}'.format(devel_project, devel_package)) + return False + return True def devel_project_review_ensure(self, request, project, package, message='submitter not devel maintainer'):