yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2443 from jsegitz/master

Browse Source 
check_source.py: Add the reason why a review was added (e.g. which
This commit is contained in:
Stephan Kulow 2021-06-23 11:00:49 +02:00 committed by GitHub
commit f07ad86d86
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
check_source.py
View File

@ -244,12 +244,16 @@ class CheckSource(ReviewBot.ReviewBot):
self.add_review(self.request, by_user=self.repo_checker, msg='Please review build success') self.add_review(self.request, by_user=self.repo_checker, msg='Please review build success')
if self.bad_rpmlint_entries: if self.bad_rpmlint_entries:
if self.has_whitelist_warnings(source_project, source_package, target_project, target_package): warnings = self.has_whitelist_warnings(source_project, source_package, target_project, target_package)
if warnings:
# if there are any add a review for the security team # if there are any add a review for the security team
# maybe add the found warnings to the message for the review # maybe add the found warnings to the message for the review
self.add_review(self.request, by_group=self.security_review_team, msg=CheckSource.AUDIT_BUG_MESSAGE) message = CheckSource.AUDIT_BUG_MESSAGE + "\nTriggered by whitelist warnings:\n{}".format("\n".join(warnings))
if self.suppresses_whitelist_warnings( source_project, source_package ): self.add_review(self.request, by_group=self.security_review_team, msg=message)
self.add_review(self.request, by_group=self.security_review_team, msg=CheckSource.AUDIT_BUG_MESSAGE) warnings = self.suppresses_whitelist_warnings(source_project, source_package)
if warnings:
message = CheckSource.AUDIT_BUG_MESSAGE + "\nTriggered by suppressed whitelist warning:\n{}".format("\n".join(warnings))
self.add_review(self.request, by_group=self.security_review_team, msg=message)
return True return True