From fa845d6237b50da1fd7dbe27c8469cd06605f840 Mon Sep 17 00:00:00 2001 From: Ludwig Nussel Date: Mon, 8 Jun 2015 16:12:46 +0200 Subject: [PATCH] fix fallback text summary --- abichecker/abichecker.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/abichecker/abichecker.py b/abichecker/abichecker.py index b7e96dcf..1a7299a1 100755 --- a/abichecker/abichecker.py +++ b/abichecker/abichecker.py @@ -527,8 +527,6 @@ class ABIChecker(ReviewBot.ReviewBot): if ret is not None: state = 'done' result = 'accepted' if ret else 'declined' - if self.text_summary == '': - self.text_summary = "ABI checker result: %s"%result else: # we probably don't want abichecker to spam here # FIXME don't delete comment in this case @@ -537,6 +535,10 @@ class ABIChecker(ReviewBot.ReviewBot): state = 'seen' self.save_reports_to_db(req, state, result) + if ret is not None and self.text_summary == '': + # if for some reason save_reports_to_db didn't produce a + # summary we add one + self.text_summary = "ABI checker result: [%s](%s/request/%s)"%(result, WEB_URL, req.reqid) if commentid and not self.dryrun: self.commentapi.delete(commentid)