From 307d4eba5935d0701a94b2f45bb73c634832e539 Mon Sep 17 00:00:00 2001 From: Ludwig Nussel Date: Thu, 19 Feb 2015 17:20:27 +0100 Subject: [PATCH 1/2] handle packages without maintainer if no maintainer is found, add devel project/package as reviewer --- check_maintenance_incidents.py | 1 + 1 file changed, 1 insertion(+) diff --git a/check_maintenance_incidents.py b/check_maintenance_incidents.py index edd9dd8b..d4d13aeb 100755 --- a/check_maintenance_incidents.py +++ b/check_maintenance_incidents.py @@ -101,6 +101,7 @@ class MaintenanceChecker(ReviewBot.ReviewBot): self.needs_maintainer_review.add(pkgname) else: self.logger.warning("%s doesn't have maintainers"%pkgname) + self.needs_maintainer_review.add(pkgname) if a.tgt_releaseproject == "openSUSE:Backports:SLE-12": self.add_factory_source = True From 54d272c2e26b459419ad88ceed18043b2fecddeb Mon Sep 17 00:00:00 2001 From: Ludwig Nussel Date: Thu, 19 Feb 2015 17:21:12 +0100 Subject: [PATCH 2/2] handle maintainer groups some packages like wicked are maintained by a group so expand user names on groups --- check_maintenance_incidents.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/check_maintenance_incidents.py b/check_maintenance_incidents.py index d4d13aeb..02526c27 100755 --- a/check_maintenance_incidents.py +++ b/check_maintenance_incidents.py @@ -52,7 +52,13 @@ class MaintenanceChecker(ReviewBot.ReviewBot): } url = osc.core.makeurl(self.apiurl, ('search', 'owner'), query=query) root = ET.parse(osc.core.http_GET(url)).getroot() - return [p.get('name') for p in root.findall('.//person') if p.get('role') == 'maintainer'] + maintainers = [p.get('name') for p in root.findall('.//person') if p.get('role') == 'maintainer'] + if not maintainers: + for group in [p.get('name') for p in root.findall('.//group') if p.get('role') == 'maintainer']: + url = osc.core.makeurl(self.apiurl, ('group', group)) + root = ET.parse(osc.core.http_GET(url)).getroot() + maintainers = maintainers + [p.get('userid') for p in root.findall('./person/person')] + return maintainers def add_devel_project_review(self, req, package): """ add devel project/package as reviewer """