yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
7,415 Commits 2 Branches 12 Tags
Commit Graph

51 Commits

Author SHA1 Message Date
Dirk Müller
730630f06f
Use f-strings where possible 2024-05-07 21:52:32 +02:00
Dirk Müller
a7831fd212
use request.creator rather than request.get_creator() which is 
deprecated
 2023-01-25 18:14:26 +01:00
Stephan Kulow
673084d753 Merge check_source_in_factory into check_tags_in_requests.py 
Followup #2781
 2022-03-30 08:31:58 +02:00
Stephan Kulow
f86579642b Target E501 - Line too long 
https://www.flake8rules.com/rules/E501.html - but 79 characters is a
joke
 2022-02-18 18:17:27 +01:00
Stephan Kulow
f38bd3a7ed Target E128 - Continuation line under-indented for visual indent 
https://www.flake8rules.com/rules/E128.html
 2022-02-18 17:35:33 +01:00
Stephan Kulow
27c364b0c9 Target E251 - Unexpected spaces around keyword 
https://www.flake8rules.com/rules/E251.html
 2022-02-18 17:28:13 +01:00
Stephan Kulow
d8f5d0874e Remove E201 - Whitespace after '(' 
https://www.flake8rules.com/rules/E201.html
 2022-02-18 17:23:19 +01:00
Stephan Kulow
54079e949f Target E202 - Whitespace before ')' 
https://www.flake8rules.com/rules/E202.html
 2022-02-18 17:18:29 +01:00
Stephan Kulow
529d1dafae Target E302 - add two comment lines before class 2022-02-18 17:15:48 +01:00
Stephan Kulow
4e9c8eabbe Target E305 - Have two empty lines of a class 2022-02-18 17:11:46 +01:00
Stephan Kulow
d6628beadf Target E125 - Continuation line with same indent 
https://www.flake8rules.com/rules/E125.html
 2022-02-18 15:52:53 +01:00
Stephan Kulow
e52dc6ce2b Harmonize imports on using lxml for XML parsing 2022-02-18 11:16:01 +01:00
Marcus Meissner
616037ae74 filter out 15-sp3 and 15-sp4 from factory-source review 
strategy of those is now different
 2021-10-15 14:29:28 +02:00
Stephan Kulow
a8f7146baf Remove E713 offense from flaker 2021-09-21 14:20:08 +02:00
Dirk Mueller
ad06348dcf More flake8 cleanups 2019-12-10 12:50:57 +01:00
Dirk Mueller
32ad0adc2d Fix all E22x errors 
This cleans up white spaces around various kinds of operators to be
consistent.
 2019-11-27 11:08:06 +01:00
Dirk Mueller
8483632683 Some flake8 improvements 
Was bored while waiting for a test run to finish. The rule is
that two empty lines distinguish larger blocks and shouldn't be
used between functions or within functions.
 2019-11-27 10:40:15 +01:00
Jimmy Berry
a8ff27b81f osclib/core: provide action_is_patchinfo() from ReviewBot. 
Allows for usage outside of ReviewBot children.
 2019-07-11 16:01:42 -05:00
Stephan Kulow
3bd00cdf5d Run check_maintenance_incidents.py on gocd 2019-05-29 07:22:52 +02:00
Stephan Kulow
ea9061ccf5 Import urllib2 python agnostic 2018-11-16 09:01:45 +01:00
Jimmy Berry
ac798df607 ReviewBot: accept patchinfo action reviews instead of ignore. 
Ignore is used to wait for a change to occur while patchinfo should never
affect the result. Since all actions must be accepted for the request to
be accepted setting patchinfo to accept is the correct way to ignore it.
 2018-11-12 16:22:27 -06:00
Max Lin
1968b6523c check_maintenance_incidents: skip action if the action is for patchinfo 
Action of patchinfo does not have a releaseproject attribute, with bad
luck it might be lists as the first action of an maintenance incident,
we should skip it and try next action.
 2018-10-15 17:59:46 +08:00
Jimmy Berry
406fc41a85 ReviewBots: utilize delete_package check where it was already assumed. 2018-09-17 17:15:23 -05:00
Jimmy Berry
6069245350 Remove SUSE copyright, warranty, and license headers. 
Distinct copyrights were left as I do not wish to track down commit
history to ensure it properly documents the copyright holders. Also left
non-GPLv2 licenses and left bs_copy untouched as a mirror from OBS.

Already have a mix of with and without headers and even OBS does not place
on majority of files. If SUSE lawyers have an issue it will come up in
legal review for Factory.
 2018-08-23 19:18:06 -05:00
Jimmy Berry
e308bd6139 check_maintenance_incidencts: utilize _is_patchinfo(). 
Pulled out as function in 9a418f780f2c09caaf22c1430b93b1895909bd80, but
not used in maintenance bot.
 2018-06-28 10:52:47 -05:00
Jimmy Berry
f98a78c1ae Remove Vim config in favor of EditorConfig. 2018-01-23 00:48:00 -06:00
Ludwig Nussel
312c18024d Don't die on delete requests 
Perform src_project checks only on actions that actually have a
src_project
 2017-11-09 14:55:07 +01:00
Ludwig Nussel
52dbf107a7 maintbot: no maintainer review for SLE15 submissions 2017-10-02 16:09:43 +02:00
Jimmy Berry
078ec68697 ReviewBot: add_review(): provide allow_duplicate parameter and default of False. 
Also update calls based on default behavior change. As described in the
comment above add_review() there seems to be no reason to ever add a
duplicate review.

The check in leaper would skip unless state == declined. In such a case
the review would automatically be reopened along with the request so that
logic is unnecessary.
 2017-08-15 22:18:53 -05:00
Jimmy Berry
ef93709e16 ReviewBot: add_review(): raise exception instead of returning boolean. 
This ensures that calling bots crash rather than continue which can cause
non-atomic state changes that miss reviews when OBS crashes or is
unavailable.
 2017-08-15 21:43:02 -05:00
Jimmy Berry
12b84757a2 check_source: add devel review for delete request using MaintenanceChecker logic. 2017-07-27 19:31:46 -05:00
Jimmy Berry
7c6f67979a core: extract maintainers_get(), owner_fallback() from MaintenanceChecker. 
Allows the code to be properly shared between checkrepo and
check_maintenance_incidents as a todo suggests. Given that the majority of
similar cases for code sharing are extension of osc.core it seems to make
sense to place them in osclib.core.
 2017-07-12 15:31:30 -05:00
Jimmy Berry
4813734ab0 MaintenanceChecker: include project in owner query to utilize local devel. 
For Leap the devel project may override the Factory one.
 2017-04-26 17:12:49 -05:00
Jimmy Berry
a1cb4aa772 MaintenanceChecker: utilize osc.core.owner(). 2017-04-26 16:01:47 -05:00
Jimmy Berry
7431af4a72 Rework ReviewBot.CommandLineInterface to provide class option. (#622) 
Alleviates the need for a lot of duplicate code, some of which is already
out-of-sync.
 2017-01-02 09:34:13 +01:00
Andreas Stieger
f5d47c3ded Improve message for multiple maintainer reviews 2016-12-02 13:39:52 +01:00
Ludwig Nussel
6202edd27c Don't require maintainer ack for Maintenance submissions 2016-10-17 11:35:21 +02:00
Ludwig Nussel
b79d40321c Fix review of dropped packages 
Avoid adding e.g. openSUSE:13.2 as reviewer. OBS sometimes returns
projects of released openSUSE distributions as maintainer for packages
that were dropped from Factory.
 2016-10-14 14:29:35 +02:00
Ludwig Nussel
c29e28d27c Don't check patchinfo files 2016-06-17 11:00:06 +02:00
Ludwig Nussel
d35e73d595 Introduce the Leap bot 
Combination of factory source checker and maintainer check
 2016-06-07 15:11:26 +02:00
Ludwig Nussel
0c18a67112 add factory source checker for all of Backports 2016-05-30 16:22:04 +02:00
Ludwig Nussel
a66047058d skip maintainer review for sle based packages 
fixes bsc#956051
 2015-11-23 16:47:03 +01:00
Ludwig Nussel
2aefe3bac0 don't add factory-source multiple times 2015-10-05 10:50:01 +02:00
Ludwig Nussel
2e0b8debda remove unused variable 2015-09-30 11:41:36 +02:00
Ludwig Nussel
7253a060c4 avoid adding double reviews if review is by project 2015-09-29 09:51:23 +02:00
Ludwig Nussel
a334773cab implement checking submit requests 2015-09-29 08:44:30 +02:00
Ludwig Nussel
54d272c2e2 handle maintainer groups 
some packages like wicked are maintained by a group so expand user names on groups
 2015-02-19 17:24:51 +01:00
Ludwig Nussel
307d4eba59 handle packages without maintainer 
if no maintainer is found, add devel project/package as reviewer
 2015-02-19 17:20:27 +01:00
Ludwig Nussel
cfd6641f82 rename CPE -> Backports 2015-02-04 16:43:56 +01:00
Ludwig Nussel
a2cf55aaff fix double review, add testcase 
closes #278
 2015-01-26 11:42:00 +01:00