97 Commits

Author SHA1 Message Date
Stephan Kulow
ea9061ccf5 Import urllib2 python agnostic 2018-11-16 09:01:45 +01:00
Ludwig Nussel
9f82d01c1b
Merge pull request #1716 from lnussel/leaper
leaper: block on pending factory submissions also for new packages
2018-10-26 16:49:42 +02:00
Jimmy Berry
4c8ade1a93 flake8: utilize raw strings to avoid invalid escape character warnings. 2018-10-24 16:34:16 -05:00
Jimmy Berry
020d14065e leaper: disable maintainer review addition for incidents.
This was disabled manually in production to effectively run leaper in
"comment-only mode" for maintenance with the expectation that this would
not remain for long. Since it seems it will it makes sense to merge the
state expected to be deployed.
2018-10-15 16:40:26 -05:00
Ludwig Nussel
f1c8f63900 leaper: block on pending factory submissions also for new packages 2018-10-01 09:57:15 +02:00
cf87c26486 leaper: proper maintainer review rule
After moved to ReviewBot from maintbot, follow the old rule of
adding maintainer review, skip maintainer review if submission is from
SLE; SLE's SP; Leap and Leap:Update.
2018-08-28 18:16:45 +08:00
Jimmy Berry
541b94d1d0
Merge pull request #1674 from jberry-suse/license
LICENSE: add proper GPLv2 license and drop unnecessary headers.
2018-08-27 16:53:43 -05:00
Jimmy Berry
19fca41416 leaper: comment_handler_lines_deduplicate() remove as no longer applicable.
In factory for multi-action requests, like maintenance, this ends up hiding
useful lines that should be repeated for actions with the same origin.
2018-08-27 16:19:28 -05:00
Jimmy Berry
6069245350 Remove SUSE copyright, warranty, and license headers.
Distinct copyrights were left as I do not wish to track down commit
history to ensure it properly documents the copyright holders. Also left
non-GPLv2 licenses and left bs_copy untouched as a mirror from OBS.

Already have a mix of with and without headers and even OBS does not place
on majority of files. If SUSE lawyers have an issue it will come up in
legal review for Factory.
2018-08-23 19:18:06 -05:00
Jimmy Berry
dab65356d7 leaper: replace maintbot usage with ReviewBot methods.
The maintenance_incident logic is always updated to mimic the maintbot
behavior in regards to when to add devel project review.
2018-08-22 21:24:58 -05:00
Jimmy Berry
be2ed18b29 leaper: remove duplicate maintainer review check for IBS in default action.
The default is already set in check_one_request() (called before) to
  self.do_check_maintainer_review = not self.ibs
2018-08-22 00:31:35 -05:00
Jimmy Berry
1012b62830 ReviewBots: utilize Config.get() instead of self.staging_config. 2018-08-17 10:16:47 -05:00
Jimmy Berry
9a1fd7fb7b leaper: remove only_one_action limitation.
Leaper will now be used on maintenance incidents which commonly have
multiple actions. A similar change was done to check_source.py where the
restriction was moved to a review setting which is more appropriate rather
than a hard limitation. Going forward it makes sense to lift the limitation
and have only one bot enforce the rule where appropriate.
2018-08-08 23:31:41 -05:00
Jimmy Berry
e479ddc841 leaper: provide maintenance_incident support. 2018-08-08 23:31:34 -05:00
32cd7bc22d leaper: fix error with no lookup_150 attribute exist after introduced PackageLookup 2018-07-25 18:09:51 +08:00
Ludwig Nussel
cc2fa88058 leaper: adjust for SLE 15SP1 and SLE12SP4 2018-06-28 14:24:35 +02:00
Ludwig Nussel
07de65b419 Leaper: adjust for 15.1
preliminary adjustments
2018-06-26 09:03:33 +02:00
Ludwig Nussel
a471c0b9e8 Refactor _check_project into ReviewBot 2018-05-30 13:55:38 +02:00
Ludwig Nussel
7dbb4d667b leaper: update diff link to also link to package itself 2018-04-17 10:13:06 +02:00
Ludwig Nussel
ecf14e0e52 leaper: fix link to SLE-workarounds 2018-04-17 10:13:06 +02:00
Ludwig Nussel
3e0d07b335 leaper: set maintainer review early 2018-03-27 09:28:44 +02:00
Ludwig Nussel
1b5ab032aa leaper: also look into :Live subproject of Factory 2018-03-23 15:28:11 +01:00
Ludwig Nussel
4e03967dba
Merge pull request #1455 from lnussel/leaper
leaper: allow comment override also on openSUSE
2018-03-23 11:20:36 +01:00
Ludwig Nussel
60bb341c29 leaper: allow comment override also on openSUSE 2018-03-19 16:29:33 +01:00
Jimmy Berry
39ef75493d Change references to osc-plugin-factory to openSUSE-release-tools. 2018-03-16 14:58:27 -05:00
Jimmy Berry
16f49c7518 leaper: do not decline SLE requests, but rather ask managers for input. 2018-03-07 15:11:02 -06:00
Jimmy Berry
8332692dad leaper: move review groups to osclib.conf. 2018-03-07 14:55:09 -06:00
Ludwig Nussel
58bd9c70e1 leaper: allow turning FORK into something else 2018-02-13 12:57:26 +01:00
Ludwig Nussel
4e3148aace leaper: don't check maintainer for other requests 2018-02-12 13:27:27 +01:00
Ludwig Nussel
d4a4cf8396 leaper: switch off maintainer review for updates from Factory 2018-02-09 13:31:11 +01:00
Jimmy Berry
f98a78c1ae Remove Vim config in favor of EditorConfig. 2018-01-23 00:48:00 -06:00
Jimmy Berry
8c4891bd95 ReviewBot: replace get_devel_project() with osclib.core.devel_project_get(). 2018-01-17 18:09:30 -06:00
Ludwig Nussel
981fe38696 Skip maintainer review for certain Leap 15 submissions 2017-11-20 14:54:49 +01:00
d1c4801578 Another set of low-noise flake8 cleanups 2017-10-20 20:46:44 +02:00
3cf49d9556 Python 2.6+ / 3.x style except clauses
This newer style except statement allows for compatibility with
Python 3.x and does not harm on python 2.6+.
2017-10-16 22:47:58 +02:00
Ludwig Nussel
30930ba7fd leaper: ignore 404
Some projects may not exist yet, such as SLE :Update.
Don't bail out because of that.
2017-10-05 16:44:22 +02:00
Ludwig Nussel
dd8adeb97d leaper: fix iterating through list 2017-09-07 16:27:47 +02:00
Ludwig Nussel
021c6f5da0 leaper: avoid comments about unhandled request types
delete and set_bugowner are quite common, so commenting about them
doesn't add much value.
2017-08-29 11:14:18 +02:00
Ludwig Nussel
635f41b18c leaper: fix syntax error 2017-08-29 11:14:10 +02:00
Jimmy Berry
078ec68697 ReviewBot: add_review(): provide allow_duplicate parameter and default of False.
Also update calls based on default behavior change. As described in the
comment above add_review() there seems to be no reason to ever add a
duplicate review.

The check in leaper would skip unless state == declined. In such a case
the review would automatically be reopened along with the request so that
logic is unnecessary.
2017-08-15 22:18:53 -05:00
Jimmy Berry
ef93709e16 ReviewBot: add_review(): raise exception instead of returning boolean.
This ensures that calling bots crash rather than continue which can cause
non-atomic state changes that miss reviews when OBS crashes or is
unavailable.
2017-08-15 21:43:02 -05:00
Jimmy Berry
0aaa2ea02d leaper: transition from SLE-12-SP3 and Leap:42.3 to SLE-15 and Leap:15.0. 2017-08-01 16:42:16 -05:00
Jimmy Berry
060b50f072 ReviewBot: add comment_handler option and use in leaper. 2017-07-12 15:31:30 -05:00
Jimmy Berry
2c1a21704d ReviewBot: copy default review messages before each review. 2017-07-12 15:31:30 -05:00
Jimmy Berry
3b1c11f45c ReviewBot: provide only_one_action option and use in leaper and check_source. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7bcf94a35f ReviewBot: provide request_default_return option and use in leaper. 2017-07-12 15:31:30 -05:00
Ludwig Nussel
1c7a37bc0e Turn off automatic submission from Factory 2017-07-03 17:23:00 +02:00
Jimmy Berry
c1dc56c251 leaper: correct invalid diff link when package present in SLE. 2017-06-27 01:15:25 -05:00
Ludwig Nussel
e2cd308062 Merge pull request #890 from lnussel/leaper
Add more klickable links
2017-06-19 16:49:27 +02:00
Jimmy Berry
d804a9d333 leaper: drop extraneous _ prefix to src_srcinfo during in_sle_origin check. 2017-05-11 23:34:35 -05:00