When releasename does not differ it is essentially the same as no
releasename at all, but since OBS allows this and some source packages
contain such a value need to make check more specific.
See #2294 for an example.
Now that update_consider() local check package_kind() on both origin
and target package a delete is possible. origin_update() already
supported generating deletes or swapping origin to next potential.
Useful for avoiding making a request if any pending or non-accepted
request against that package exists. Such a use case is submitting new
packages by origin-manager which should only try the submission once.
As a follow-up to new packages accepted from a specific devel generate
a change_devel request automatically. Such requests should be approved
automatically since they are a workaround to not being able to set devel
during source submission.
Necessary for writing involved tests since the assumptions made by the
cache are violated and thus cause problems.
To keep the tests passing the oscrc intended to be used must be set as
environment variable so when osclib.conf.Config is use the config is not
lost. This would be made simpler without the needless extra config added
by StagingWorkflow.
The check for bcntsynctag can be very misleading - just because we align
the build counters between 2 packages doesn't make them invalid submission
targets. Better rely on the link check which is already implemented as
fallback
And set a verbose decline reason for this case
* Simplify the 'accept' code
openSUSE:Factory/snapshot is newly setup as a Download on Demand repository
and we can thus safe ourselves the hassle of having to take extra care of
handling delete requests. They no longer bleed directly into the /snapshot
area and can now be accepted like any other request
* Drop vdelreq plugin
Since we no longer do a virtual accept of delete requests, we also don't
have to monitor their state anymore. Drop the plugin that served only
this usecase
* Drop the acheck command
As a consequence, the command 'staging acheck' serves no purpose anymore:
/totest was just there to ensure we have something to copy to /snapshot.
This entire repo will vanish, and it is thus no longer needed to verify
if it is in sync before accepting new data.
To improve robustness and handle invalid/corrupt data in the annotation
just return None if it is anything other than a dict after parsing. The
most likely occurrence is someone accepts the origin-manager review with
a plain-text message.
This excludes reviews that were added and never reviewed possibly because
the request was rejected before the review could be accepted. In such
cases the comment specified when adding the review will be loaded as the
annotation which is not desirable.
