yudaike/openSUSE-release-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
3,756 Commits 2 Branches 12 Tags
Commit Graph

93 Commits

Author SHA1 Message Date
Ludwig Nussel
fc587db936 ReviewBot: don't crash if staging-group is None 2018-03-09 16:22:24 +01:00
Ludwig Nussel
ca5f71ec4b leaper: fix can_accept_review for combined user/group usage 2018-03-08 16:45:33 +01:00
Stephan Kulow
c176a4c95e ReviewBot: allow both group and user review 2018-03-08 10:34:40 +01:00
Jimmy Berry
d30db7eb1d
Merge pull request #1427 from jberry-suse/ReviewBot-comment-override 
Define comment commands and provide for ReviewBot review overrides and repo-checker skip-cycle.
 2018-03-07 13:41:31 -06:00
Jimmy Berry
a40ebc1544 ReviewBot: provide comment command override. 
For example:

  @leaper override accept
  @repo-checker override decline
 2018-03-06 16:42:12 -06:00
Jimmy Berry
3c25b8a8a4 ReviewBot: do not bother commenting for unhandled request type. 
For consistency this would still make sense to post as a "report", but
given the lack of such a facility in OBS disable comment to reduce noise.
 2018-03-05 11:45:37 -06:00
Jimmy Berry
f98a78c1ae Remove Vim config in favor of EditorConfig. 2018-01-23 00:48:00 -06:00
Jimmy Berry
6631598dc6 ReviewBot: comment_write(): provide bot_name_suffix parameter. 
Cleanly allows for multiple comments from the same tool on one entity.
 2018-01-19 08:50:32 -06:00
Jimmy Berry
8c4891bd95 ReviewBot: replace get_devel_project() with osclib.core.devel_project_get(). 2018-01-17 18:09:30 -06:00
Jimmy Berry
1bd5b99028 ReviewBot: comment_write(): provide info_extra_identical parameter. 
Allows for excluding info_extra from comment_find() and compares messages
after marker has been removed.
 2017-12-29 18:32:43 -06:00
Dirk Mueller
1cec490d54 White space / consistent usage of spaces / indentation of 4 fixes 2017-10-20 00:58:05 +02:00
Dirk Mueller
3cf49d9556 Python 2.6+ / 3.x style except clauses 
This newer style except statement allows for compatibility with
Python 3.x and does not harm on python 2.6+.
 2017-10-16 22:47:58 +02:00
Jimmy Berry
b129a13758 Merge pull request #1154 from jberry-suse/ReviewBot-comment_write-super-small-teany-tiny-tweak 
ReviewBot: comment_write() add info_extra parameter (and overview documentation).
 2017-10-06 15:37:55 -05:00
Jimmy Berry
b97ced1c74 ReviewBot: comment_write() no need to str() since None is exits above. 2017-10-05 17:41:51 -05:00
Jimmy Berry
642f0536a1 ReviewBot: comment_write(): pre-truncate for correct comparison. 
Otherwise, long comments that end up being truncated are re-posted.
 2017-10-05 17:40:26 -05:00
Jimmy Berry
76c4b499e3 ReviewBot: comment_write(): add overview documentation. 2017-09-29 09:42:39 -05:00
Jimmy Berry
b886949e83 ReviewBot: comment_write(): add info_extra parameter. 2017-09-29 09:35:14 -05:00
Jimmy Berry
eb350bdf73 ReviewBot: comment_write(): skip posting empty comments extracted from handler. 2017-08-29 22:19:21 -05:00
Jimmy Berry
17d8ea8b3a ReviewBot: downgrade message about skipping duplicate review to debug. 
This matches the original intent along with ensuring such messages never
end up in the default CommentFromLogHandler.
 2017-08-29 22:18:16 -05:00
Jimmy Berry
c71e075396 Merge pull request #1088 from jberry-suse/ReviewBot-only_replace 
repo_checker: post passed comment only if previous failed comment (and debug improvements).
 2017-08-24 20:48:59 -05:00
Jimmy Berry
ebd2f580ec ReviewBot: comment_write(): provide only_replace option. 2017-08-23 15:19:36 -05:00
Jimmy Berry
ca13855d2e ReviewBot: comment_write(): pull dryrun protected bit out individually. 2017-08-23 15:17:44 -05:00
Jimmy Berry
757d31cf35 ReviewBot: comment_write(): place debug_key at the end for consistency. 2017-08-23 15:15:02 -05:00
Jimmy Berry
f88e8a9297 ReviewBot: simplify logger format. 
The output is rather verbose, especially inside journals, and not terribly
helpful.
 2017-08-23 15:00:33 -05:00
Jimmy Berry
164b04903c ReviewBot: add_review(): remove left-over print() line. 2017-08-18 17:35:05 -05:00
Jimmy Berry
d565f46123 ReviewBot: get_devel_project(): correct error handling to only allow 404. 
The original intent was clearly to allow 404 (package does not exist for
new packages), but crash on anything else. Instead it consumes all
exceptions and does nothing different even with the e.code condition.
 2017-08-18 17:34:32 -05:00
Jimmy Berry
078ec68697 ReviewBot: add_review(): provide allow_duplicate parameter and default of False. 
Also update calls based on default behavior change. As described in the
comment above add_review() there seems to be no reason to ever add a
duplicate review.

The check in leaper would skip unless state == declined. In such a case
the review would automatically be reopened along with the request so that
logic is unnecessary.
 2017-08-15 22:18:53 -05:00
Jimmy Berry
ef93709e16 ReviewBot: add_review(): raise exception instead of returning boolean. 
This ensures that calling bots crash rather than continue which can cause
non-atomic state changes that miss reviews when OBS crashes or is
unavailable.
 2017-08-15 21:43:02 -05:00
Jimmy Berry
9443c3de04 ReviewBot: comment_write(): include target in debug message when too similar. 2017-08-04 13:32:07 -05:00
Jimmy Berry
cfbd479ed7 ReviewBot: comment_write(): support package. 2017-08-02 21:35:16 -05:00
Jimmy Berry
03c46f18d7 ReviewBot: provide staging_api() from repo_checker. 2017-07-18 17:06:37 -05:00
Jimmy Berry
4bc130a927 ReviewBot: comment_write(): provide identical option to allow for stricter matching. 2017-07-12 15:31:30 -05:00
Jimmy Berry
dc7e3659a4 ReviewBot: comment_write(): support writing to project. 2017-07-12 15:31:30 -05:00
Jimmy Berry
3f16de02b3 ReviewBot: include comment in __default handler if comments enabled. 2017-07-12 15:31:30 -05:00
Jimmy Berry
96d51b5ad8 ReviewBot: load requests with withfullhistory to allow for review analysis. 2017-07-12 15:31:30 -05:00
Jimmy Berry
060b50f072 ReviewBot: add comment_handler option and use in leaper. 2017-07-12 15:31:30 -05:00
Jimmy Berry
2c1a21704d ReviewBot: copy default review messages before each review. 2017-07-12 15:31:30 -05:00
Jimmy Berry
3b1c11f45c ReviewBot: provide only_one_action option and use in leaper and check_source. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7bcf94a35f ReviewBot: provide request_default_return option and use in leaper. 2017-07-12 15:31:30 -05:00
Ondřej Súkup
518b52060b
ReviewBot: add missing yaml import for loading config file. 2017-06-23 17:07:23 +02:00
Stephan Kulow
9a418f780f
Extract patchinfo check into a function 2017-06-08 12:49:39 +02:00
Ludwig Nussel
be7c3e7c3e Handle multiple patchinfos 2017-04-28 11:50:32 +02:00
Jimmy Berry
fdbe793585 ReviewBot: always remove previous comment regardless of the state. 2017-04-25 13:38:57 -05:00
Ludwig Nussel
138a92e7f5 Add comment when adding fallback reviewer 2017-03-14 13:50:37 +01:00
Jimmy Berry
47459ccb29 CommentAPI: provide comment_find() and add_marker() from ReviewBot. 2017-03-10 00:09:27 -06:00
Stephan Kulow
f8e5662161 Do not craft encoded URL with a light heart 2017-03-03 15:16:59 -06:00
Ludwig Nussel
c6f4f4472e Merge pull request #693 from jberry-suse/leaper-unhandled 
ReviewBot & leaper: provide deduplicate method for leaper comment (and other fixes)
 2017-02-17 14:08:20 +01:00
Jimmy Berry
87cb5c2ab0 ReviewBot: drop duplicate import namedtuple. 2017-02-15 10:01:36 -06:00
Jimmy Berry
748fce38cc ReviewBot & leaper: provide deduplicate method for leaper comment. 
Otherwise, leaper will indicate an unhandled request twice.
 2017-02-15 10:01:20 -06:00
Jimmy Berry
23d4a7a6a5 ReviewBot: check_action__default() should return None not set ret. 2017-02-15 09:44:31 -06:00