* Simplify the 'accept' code
openSUSE:Factory/snapshot is newly setup as a Download on Demand repository
and we can thus safe ourselves the hassle of having to take extra care of
handling delete requests. They no longer bleed directly into the /snapshot
area and can now be accepted like any other request
* Drop vdelreq plugin
Since we no longer do a virtual accept of delete requests, we also don't
have to monitor their state anymore. Drop the plugin that served only
this usecase
* Drop the acheck command
As a consequence, the command 'staging acheck' serves no purpose anymore:
/totest was just there to ensure we have something to copy to /snapshot.
This entire repo will vanish, and it is thus no longer needed to verify
if it is in sync before accepting new data.
In 6f21ae6 we fixed an inversion of to and fullname fields - but the
recipient was not fixed up here (resulting in addressing the user
by his email address)
Also fix a typo: recepient -> recipient
Otherwise, all write calls complain about passing a string instead of
binary data. Given the yaml dump and subsequent comments are all strings
it makes more sense to change file mode.
If installcheck or packagelists check fails, there is no point
(normally) to build the media - so let the release manager disable
the images repo (which also hides uninteresting fails) while the
checks are failing and have gocd enable the images repo afterwards
to start the build (and the openqa sync)
We start most jobs with --debug to generate output, but we had the
case that OBS network caused the connection to just get stuck and
then it 'paused' for 18 hours
To improve robustness and handle invalid/corrupt data in the annotation
just return None if it is anything other than a dict after parsing. The
most likely occurrence is someone accepts the origin-manager review with
a plain-text message.
This excludes reviews that were added and never reviewed possibly because
the request was rejected before the review could be accepted. In such
cases the comment specified when adding the review will be loaded as the
annotation which is not desirable.
With the lack of events from OBS for SLE updates #2239 and the troubles
with the pika base class for IBS #2220 it seems best to keep the full
run daily to ensure expedient updates.
if package_kind() returned None then the submission can be a new package
submission, check_source should continue the process instead of
decline the request.
