94 Commits

Author SHA1 Message Date
Jimmy Berry
7c6f67979a core: extract maintainers_get(), owner_fallback() from MaintenanceChecker.
Allows the code to be properly shared between checkrepo and
check_maintenance_incidents as a todo suggests. Given that the majority of
similar cases for code sharing are extension of osc.core it seems to make
sense to place them in osclib.core.
2017-07-12 15:31:30 -05:00
Jimmy Berry
ad81ff98f9 checkrepo: wait for accepts for all archs before final review accept. 2017-07-12 15:31:30 -05:00
Jimmy Berry
4c6f84d842 checkrepo: convert remaining messages to use target_archs(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
64b762956f checkrepo: _whatdependson() and _builddepinfo(): utilize target_archs(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
f0a559947c checkrepo: is_buildsuccess(): utilize target_archs(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
d4639ea0e2 checkrepo: _toignore(): compress into arch loop. 2017-07-12 15:31:30 -05:00
Jimmy Berry
844cf64b6d checkrepo: repositories_to_check(): utilize target_archs().
Drastically simplify the logic while keeping the core the same and
utilizing archs from project instead of hard-coded.
2017-07-12 15:31:30 -05:00
Jimmy Berry
35e03460bf checkrepo: utilize the devel project for requests from Factory.
Assuming requests are forwarded to Leap after being accepted into Factory
the devel project can be reviewed just as when the requests were submitted
to Factory.
2017-07-12 15:31:30 -05:00
Jimmy Berry
e29f7e060b checkrepo: provide target_archs() method to determine relevant archs.
The default behavior is to return the archs for which the target project
is built against, but can be used to check any project (like stagings).
2017-07-12 15:31:30 -05:00
Jimmy Berry
13dba97ed7 checkrepo: do not decline for disabled builds.
This behavior is inconsistent in that no builds is ignored, but builds that
are disabled results in a decline. In order to allow for the request to be
evaluated in staging it should not be declined so early.
2017-07-12 15:31:30 -05:00
Jimmy Berry
0572d7482c checkrepo: some spelling and grammar fixes. 2017-07-12 15:31:30 -05:00
Ludwig Nussel
866a28adad Prepare repochecker for Leap 2017-03-16 17:04:05 +01:00
Ludwig Nussel
e06b04627a Make repochecker give up on Haskell 2016-08-02 10:52:10 +02:00
dfb4f959fa Ugly workaround for glibc.i686 package config
Workaround glibc.i686 package config, it had a topadd block in _link,
and looks like it causes the disturl won't consistently with glibc even
with the same srcmd5. And the lastsuccess state will be outdated if the
revision is used the same srcmd5.

Note: the proper workaround, to instead of
5daf2bb6509abaf966268c9d6b13aa4e330a8af3
2016-04-21 20:12:10 +08:00
87d4fa5f09 Revert "Ugly workaround for glibc.i686 package config"
This reverts commit 5daf2bb6509abaf966268c9d6b13aa4e330a8af3.
2016-04-21 20:09:25 +08:00
5daf2bb650 Ugly workaround for glibc.i686 package config
Workaround glibc.i686 package config, it had a topadd block in _link,
and looks like it causes the disturl won't consistently with glibc even
with the same srcmd5. And the lastsuccess state will be outdated if the
revision is used the same srcmd5.
2016-04-21 18:30:56 +08:00
fb7f304edd Add glibc.i686 to specs if its glibc request
Add glibc.i686 to specs if its glibc request, therefore, repochecker
will not ignore glibc.i686 binaries in case some binaries need them.
Also ignore build_excluded if it's i686 only package, and downloading
it's i586 packages.
2016-04-21 18:30:56 +08:00
b9c98afa34 More sensible output in check_disturl()
More sensible output in check_disturl(). And changed the output flag to
WARNING than DECLINED as it did not really decline the request.
2016-04-20 17:32:26 +08:00
518586506d Output the additional message if the request is outdated in the devel project
The additional message will look more clear than telling it's bad
disturl and no matching downloads available. Note that, before executing
in check_disturl(), there is another place to check the revision which
was in check_specs(), but it was mainly for 2nd spec.

And makes DECLINED message consistently.
2016-04-19 21:52:31 +08:00
8c6ef7ff80 repochecker: Adjust the decline message for missing binaries
Some users are confused as the old message "package never built" does
not have to be true in many cases, especially on longer-lasting
stagings. In this case, the binaries might have been built but have
since been replaced by newer ones - the effect is the same: repo-checker
can't receive them in order to perform the full checks.
2016-04-12 11:15:39 +02:00
2c5e84b2b3 Fixes previous commit 2016-03-23 18:11:48 +08:00
128d97ba5f Add the possible repo candidates
Add the possible repo candidates to repos_to_check, those candidates
need to have binaries for check.
2016-03-23 17:44:20 +08:00
806fb3e158 Check the common Factory build repository only
Adding the common Factory build repository to the candidate repos only,
adn re-introduced build_excluded attribute. If it haven't good repo ie.
builds against ARM, PPC, images, i586 only or whatever, leave them there
for human to check.

Verified with SR#359327, SR#360767, SR#361364 and SR#361243.
2016-02-25 22:58:13 +08:00
e8fac472da Need to care about unknown status 2016-02-25 02:59:11 +08:00
3fb42d1385 Do not count excluded repository as good repo
Fix https://progress.opensuse.org/issues/10888
2016-02-24 19:56:31 +08:00
Alberto Planas
122b43e304 Detect OBS fails and improve the error messaging. 2015-08-28 12:58:02 +02:00
Alberto Planas
b4b5cd34a9 Move the Config call from checkrepo to the caller. 2015-02-26 11:47:11 +01:00
Alberto Planas
5a6ffa6505 If any goodrepo have no missing, the request have no missings. 2015-02-24 18:01:28 +01:00
Alberto Planas
6aad8caeb2 Fix cycle detector for new packages. 2015-02-19 14:14:49 +01:00
Alberto Planas
c9d1e06ca8 Refactor configuration parameters into configuration file. 2015-02-19 11:39:05 +01:00
Alberto Planas
26dcd7f965 Detect if the author of a delete request iis the maintainer of tgt_project 2014-11-12 16:58:34 +01:00
Alberto Planas
96dab1d6e6 Change the way to evaluate DELETE request
- Add withhistory to recover the creator
- Remove the check of the user creator test for now, I need
  to figure out how to detect who is the maintainer in the
  tgt_project
- Check that the package is not needed in the tgt_project
  (usually Factory)
2014-11-12 14:08:00 +01:00
Alberto Planas
09b988895a Improve the error message for DELETE requests. 2014-11-10 14:05:49 +01:00
Alberto Planas
5bd0626e30 Default "who" to None for the _author() 2014-11-04 11:09:40 +01:00
Alberto Planas
4af48f4c96 Improve clean_cache method. Add a test. 2014-10-14 17:10:07 +02:00
Alberto Planas
425a7ea663 Implement an external cache for checkrepo 2014-10-01 17:49:39 +02:00
Alberto Planas
503ca7f6f2 Remove all cache logic... for now. 2014-09-29 16:28:50 +02:00
Alberto Planas
482da28be6 Do not download requests without RPM. 2014-09-29 16:28:50 +02:00
ce6fa20551 Query NonFree SR. 2014-09-22 17:37:37 +02:00
d0a1124e18 Cache verify_md5 calls 2014-09-18 16:05:51 +02:00
94e0709896 Add a remainder to fix the cache 2014-09-18 16:05:50 +02:00
270de09833 Hide local bin rpm cache dir path inside module 2014-09-18 16:05:50 +02:00
49a257cc6a Some PEP8 fixes. 2014-09-01 09:43:44 +02:00
Ludwig Nussel
df1a2a0f9f add debug function to checkrepo 2014-08-28 17:16:01 +02:00
Ludwig Nussel
b39739e1ac also protect delete with --dry 2014-08-27 13:22:23 +02:00
Ludwig Nussel
d4223d94a1 add --verbose and --dry options 2014-08-27 11:36:08 +02:00
8acd18874f Add a new check. When the SPEC file is different from the package name. 2014-08-22 10:56:23 +02:00
c0259013a4 action #3206 - auto review for delete requests 2014-08-21 17:01:01 +02:00
a7e9b395bf Remove the link from the shadow project. 2014-08-20 17:49:21 +02:00
831bc38d38 Fix the Request constructor when multiple SPECs. 2014-08-20 10:49:12 +02:00