704 Commits

Author SHA1 Message Date
Jimmy Berry
5b6ad33773 cache: unquote() all URLs before processing to ensure correctness.
It seems osc.core and similar generate both quoted and unquoted URLs that
are cached separately. Additionally, urlopen() handles quoted paths
differently from os.path.*() methods which can create issues for quoted
projects.
2017-07-18 23:51:22 -05:00
Jimmy Berry
af83befff3 Drop everything related to old osc-check_repo.py. 2017-07-12 15:31:30 -05:00
Jimmy Berry
4fafc29fa3 cycle: rework to compare two projects instead of a project and request list.
This removes the need to detect sub-packages and significantly simplifies
the code while providing the same result.
2017-07-12 15:31:30 -05:00
Jimmy Berry
03a8666fa4 core: adapt checkrepo.get_package_list_from_repository() as binary_list().
- utilize osc.core.get_binarylist() instead of building query manually
- return a namedtuple for increased readability
2017-07-12 15:31:30 -05:00
Jimmy Berry
c2e950eebd core: provide request_staged() and request_when_staged().
Useful for determining if a request has an open staging project review
which makes it likely that it has been staged and avoids the need to
review each staging project.
2017-07-12 15:31:30 -05:00
Jimmy Berry
d4bea1f28d core: owner_fallback(): rework to be consistent with other functions. 2017-07-12 15:31:30 -05:00
Jimmy Berry
cf1c6f5db3 core: provide depends_on(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
84fc6fdc61 core: maintainers_get() provide option to get project maintainers. 2017-07-12 15:31:30 -05:00
Jimmy Berry
7c6f67979a core: extract maintainers_get(), owner_fallback() from MaintenanceChecker.
Allows the code to be properly shared between checkrepo and
check_maintenance_incidents as a todo suggests. Given that the majority of
similar cases for code sharing are extension of osc.core it seems to make
sense to place them in osclib.core.
2017-07-12 15:31:30 -05:00
Jimmy Berry
ad81ff98f9 checkrepo: wait for accepts for all archs before final review accept. 2017-07-12 15:31:30 -05:00
Jimmy Berry
4c6f84d842 checkrepo: convert remaining messages to use target_archs(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
64b762956f checkrepo: _whatdependson() and _builddepinfo(): utilize target_archs(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
f0a559947c checkrepo: is_buildsuccess(): utilize target_archs(). 2017-07-12 15:31:30 -05:00
Jimmy Berry
d4639ea0e2 checkrepo: _toignore(): compress into arch loop. 2017-07-12 15:31:30 -05:00
Jimmy Berry
844cf64b6d checkrepo: repositories_to_check(): utilize target_archs().
Drastically simplify the logic while keeping the core the same and
utilizing archs from project instead of hard-coded.
2017-07-12 15:31:30 -05:00
Jimmy Berry
35e03460bf checkrepo: utilize the devel project for requests from Factory.
Assuming requests are forwarded to Leap after being accepted into Factory
the devel project can be reviewed just as when the requests were submitted
to Factory.
2017-07-12 15:31:30 -05:00
Jimmy Berry
e29f7e060b checkrepo: provide target_archs() method to determine relevant archs.
The default behavior is to return the archs for which the target project
is built against, but can be used to check any project (like stagings).
2017-07-12 15:31:30 -05:00
Jimmy Berry
13dba97ed7 checkrepo: do not decline for disabled builds.
This behavior is inconsistent in that no builds is ignored, but builds that
are disabled results in a decline. In order to allow for the request to be
evaluated in staging it should not be declined so early.
2017-07-12 15:31:30 -05:00
Jimmy Berry
0572d7482c checkrepo: some spelling and grammar fixes. 2017-07-12 15:31:30 -05:00
Ludwig Nussel
b9c36d3f74 Merge pull request #994 from lnussel/adi
Ignore failures to delete adi's
2017-07-11 17:47:17 +02:00
Jimmy Berry
fe400a209b comments: avoid attempt to delete non-existent parent comments. 2017-07-10 17:12:37 -05:00
Ludwig Nussel
692bdc7b31 Ignore failures to delete adi's
If someone branched the ADI we are not able to delete it. Just ignore that.
2017-07-07 16:06:45 +02:00
bd4e71e2b0
AcceptCommand: update version of all products found in the project
in opeSUSE:Factory, for example, there is also openSUS-Kubic.product and the
versions are supposed to stay in sync.

We newly find all product definitions inside a project and update all of them,
with the same limiation as before: only if version was a 8 digit version it will
be updated to the current date stamp

Additionally, this is a preparation for the new product builder, as _product is no
longer hardcoded, but found.
2017-07-06 12:50:16 +02:00
Ludwig Nussel
dee7847f47 Merge pull request #952 from jberry-suse/duplicate-binary
Detect duplicate binaries within a project
2017-07-03 14:06:28 +02:00
6511997d29 Use frozenlinks for submission from the specific project 2017-06-30 18:28:46 +08:00
Jimmy Berry
387b37939c osc-staging: provide check_duplicate_binaries staging command. 2017-06-27 17:12:57 -05:00
Jimmy Berry
dec63ca6fd stagingapi: copy request to avoid adding prefix to meta. 2017-06-19 17:30:09 -05:00
Jimmy Berry
d9fe9ed319 Merge pull request #954 from jberry-suse/list-hide-source
list: hide source project for SLE now that devel falls back to source.
2017-06-16 16:40:49 +02:00
Jimmy Berry
33309e731c Merge pull request #951 from jberry-suse/supersede-skip-comment
stagingapi: skip supersede for next comment by updating requests_comment.
2017-06-16 00:29:37 +02:00
Jimmy Berry
213ebdb702 list: hide source project for SLE now that devel falls back to source. 2017-06-15 15:52:42 -05:00
cfe603f459 Merge pull request #950 from jberry-suse/devel-fallback-source
request_splitter: fallback to source project when devel is not present.
2017-06-15 18:54:00 +08:00
Jimmy Berry
c946aac3c3 core: provide target_archs(). 2017-06-14 23:53:12 -05:00
Jimmy Berry
98397ea758 core: provide package_list() and utilize in issue-diff.py. 2017-06-14 23:50:28 -05:00
Jimmy Berry
9052ca7182 stagingapi: skip supersede for next comment by updating requests_comment. 2017-06-14 22:28:59 -05:00
Jimmy Berry
d873e16356 request_splitter: fallback to source project when devel is not present. 2017-06-14 22:18:10 -05:00
Jimmy Berry
afaf794398 list: do not include parenthesis in delete request color. 2017-06-14 22:07:04 -05:00
Jimmy Berry
02ee26b3ed Merge pull request #931 from jberry-suse/supersede-diff-types
stagingapi: rework supersede logic to handle different request types.
2017-06-01 10:39:21 +02:00
Jimmy Berry
d93a3f6ca1 Merge pull request #934 from jberry-suse/select-comment-diff
stagingapi: update_status_comments() provide diff comments.
2017-06-01 10:37:45 +02:00
Jimmy Berry
a78fd6a15d stagingapi: update_status_comments() provide diff comments.
Instead of always providing a full comment whenever packages are added
an original comment will be posted and diff comments will be replied to
the original comment. The diff comments will provide a summary of what
changed while the complete state can be seen in the project pseudometa.
2017-06-01 10:12:18 +02:00
Jimmy Berry
7bd6e44c4f stagingapi: provide get_prj_meta_revision(). 2017-06-01 10:12:09 +02:00
Jimmy Berry
c9608507ae stagingapi: update_status_comments() utilize newer comment APIs.
- comment_find()
- add_marker()
2017-06-01 10:10:12 +02:00
Jimmy Berry
e74ce20953 stagingapi: get_prj_pseudometa() provide revision parameter. 2017-06-01 10:10:12 +02:00
Jimmy Berry
99a6de7798 stagingapi: get_prj_meta() provide revision parameter. 2017-06-01 10:10:12 +02:00
Jimmy Berry
dfcad869c9 comments: provide parent_id parameter for add_comment(). 2017-06-01 10:10:12 +02:00
Jimmy Berry
040cfde16b comments: remove unused chunks() from comment_find(). 2017-06-01 10:10:12 +02:00
Jimmy Berry
6ed8e2ea8a comments: add query parameter to _prepare_url(). 2017-06-01 10:10:12 +02:00
Jimmy Berry
fb76fb87b9 stagingapi: rework supersede logic to handle different request types.
Additionally, this treats revoked or superseded requests as always to
be replaced if a new requests is available.
2017-05-31 10:32:03 +02:00
Jimmy Berry
39799f0235 stagingapi: include new request ID in supersede review message. 2017-05-31 10:08:42 +02:00
Jimmy Berry
df9f89b2b7 stagingapi: handle old source removed and assume supersede. 2017-05-31 08:56:42 +02:00
Jimmy Berry
0a3d0f0f9f Merge pull request #909 from jberry-suse/unselect-cleanup-supersede-decline
unslect: --cleanup handle superseded request that is never replaced.
2017-05-16 14:37:32 -05:00