1450 Commits

Author SHA1 Message Date
e6de6a60d4
freeze: always disable images repository after freeze
After freeze, /standard needs to rebuild, which then triggers
the pipelines to perform installcheck, recalculate the media and
enable build of /images.

Fixes issue#2817
2022-06-20 16:55:53 +02:00
Stephan Kulow
de6a64c464 accept: Catch requests without description
Fixes #2799
2022-04-08 08:06:17 +02:00
Stephan Kulow
66bd39eab5 Accept_command: create set_bugowner requests 2022-04-05 19:00:05 +02:00
Stephan Kulow
27c4ae0a06 Don't play with the publish flag on freeze, images only switches build flag
Fix #2789 differently
2022-04-04 16:56:41 +02:00
Stephan Kulow
044f19b7dc Keep images repository disabled on freeze command
Fixes #2789
2022-04-01 10:45:48 +02:00
Stephan Kulow
6773c20695 Fix adi projects having no archs 2022-03-30 10:48:08 +02:00
Stephan Kulow
a0418aa4a0 Use all staging archs in adi projects
This replaces #1304 with a more brute force approach to fix not only
32bit libs but all failures we see on i586. We waste so much energy
retrying failed builds, it's really not worth it not trying i586 on
adi.
2022-03-29 13:55:58 +02:00
Stephan Kulow
fb6f4798a7 Extend build-fail-reminder to notify about uninstallable packages 2022-03-28 12:02:38 +02:00
Stephan Kulow
6f1314730c Stay with minversion 3.6 (and require module we already use elsewhere)
Fixes #2770
2022-03-25 09:43:56 +01:00
Stephan Kulow
ca27641a46 Fix staging accept approving package list changes
The order is important, look at the comments *before* deleting them
2022-03-24 16:33:15 +01:00
Stephan Kulow
f414161a1e Remove unused repo_checker config entries 2022-03-24 08:05:34 +01:00
Stephan Kulow
d01f79dc97 Small fixes for staging-installcheck
While I tried to enable rpmlint log parsing I refactored the config
handling. No harm done to leave that
2022-03-23 16:12:05 +01:00
Stephan Kulow
ce6112be09 Add some documentation for pkglistgen staging workflow
While writing it, I noticed that 'approve' also needs to change the exit
value of the pkglistgen pipeline step - fixed
2022-03-23 09:55:42 +01:00
Stephan Kulow
da3b74dba1 accept: Create pkglistgen .changes entry and commit 2022-03-22 13:42:49 +01:00
Stephan Kulow
92fad0708e Prepare applying pkglistgen diffs on staging accept
We will check if there are approved pkglistgen comments and if so, apply
them to the target. For this we need to parse the generated markdown, so
refactor both in a common class.

There diff is applied, but not yet commited in this commit
2022-03-22 09:28:02 +01:00
dbfe014f0e Staging accept: build-disable the images repository
With the current pipelines, we enable build of the images repository
once everything in /standard is build-succeeded and repo-checker passed.

Let's go the last mile and disable images when we check in the staging.

This should save some OBS build power (not building ISO images before the
stagings are actually ready) and also some openQA (not testing ISO images
before stagings settle)

I can foresee that sometimes an RM would still want to have preliminary
testing done - in which case the images repo can be manually build enabled
(or the pipeline be triggered to go beyond repo-checker, as it likely also
needs a recalculation of the content)
2022-03-19 08:33:54 +01:00
Stephan Kulow
fe847b43d5 Rename the pkglistgen config for ring1 as well
It's a little suprising fallout from 1870e989a4d7a1f846dc06895402dc1395b34c11,
but we don't have package lists in "rings" anymore, but only in one
ring.
2022-03-07 11:17:11 +01:00
Stephan Kulow
57322b2382
Merge pull request #2731 from coolo/fix_1611
pkglistgen: Deprecate scope 'all'
2022-03-04 12:10:54 +01:00
Stephan Kulow
313908293f pkglistgen: Deprecate scope 'all'
Within gocd we run each job on its own worker and don't rely on builtin
loop. So no need to care for a remote config
2022-03-04 11:27:12 +01:00
Stephan Kulow
a1f7a16e6f tests: Fix api_tests to mock attribute not mtime 2022-03-04 11:11:42 +01:00
Stephan Kulow
5c377d64d3 osclib: Add an helpful error on failed attribute save
It's stil throwing the exception but with some luck the user sees the
error and acts.
2022-03-04 09:48:06 +01:00
Stephan Kulow
66b778144f Make frozenage less reliant on changing _frozenlinks
The mtime of a file in OBS is the time this content was created for the
first time. As such if the target project isn't moving for a week,
staging select will keep asking you to freeze - even if you just froze.

So instead of relying on OBS to tell the true mtime, set an attribute
in the staging project and read from it. This also gives a way to check
in the webui for the last freeze time

Fixes #2462
2022-03-03 18:11:50 +01:00
Stephan Kulow
39bbc90c22
Merge pull request #2721 from coolo/origin_updater
More origin manager cleanup
2022-03-03 08:12:19 +01:00
Stephan Kulow
bc5a437bb7 freeze: Copy weakremovers.inc from target project to avoid bitrot
Fixes #1924
2022-02-25 14:10:59 +01:00
Stephan Kulow
95db8a0091 More origin manager cleanup
As we don't do automatic origin updates in no project, remove the
update monitors. Those have been paused on botmaster for half a year
and just no project relies on them any longer
2022-02-25 10:10:09 +01:00
Stephan Kulow
d6fb5d680c Remove sentry integration
It was introduced by #2159 because the various machines were hard to
monitor. Since we moved to botmaster there is no longer a problem with
that and if it ever served us is hard to say as the sentry project's
password is lost for years. So simplify the exception handling by just
throwing it
2022-02-21 14:41:33 +01:00
Stephan Kulow
3e14e55fde
Merge pull request #2712 from coolo/fix_project
Fix output of staging reviews
2022-02-21 12:28:02 +01:00
Stephan Kulow
90d8cd6cf0 Fix output of staging reviews
The staging status doesn't provide the by_project and it's not
really important here, so simplify

Before:
adi:39 review: None/ekiga for ekiga[955924]

After:
adi:39 review: package:ekiga for ekiga[955924]
2022-02-20 12:57:39 +01:00
Stephan Kulow
aaab4af930 Target F401 - Unused imports 2022-02-18 18:29:27 +01:00
Stephan Kulow
f86579642b Target E501 - Line too long
https://www.flake8rules.com/rules/E501.html - but 79 characters is a
joke
2022-02-18 18:17:27 +01:00
Stephan Kulow
f38bd3a7ed Target E128 - Continuation line under-indented for visual indent
https://www.flake8rules.com/rules/E128.html
2022-02-18 17:35:33 +01:00
Stephan Kulow
27c364b0c9 Target E251 - Unexpected spaces around keyword
https://www.flake8rules.com/rules/E251.html
2022-02-18 17:28:13 +01:00
Stephan Kulow
d8f5d0874e Remove E201 - Whitespace after '('
https://www.flake8rules.com/rules/E201.html
2022-02-18 17:23:19 +01:00
Stephan Kulow
54079e949f Target E202 - Whitespace before ')'
https://www.flake8rules.com/rules/E202.html
2022-02-18 17:18:29 +01:00
Stephan Kulow
529d1dafae Target E302 - add two comment lines before class 2022-02-18 17:15:48 +01:00
Stephan Kulow
4e9c8eabbe Target E305 - Have two empty lines of a class 2022-02-18 17:11:46 +01:00
Stephan Kulow
579145b52c Target F841 - Remove unused variables 2022-02-18 17:01:38 +01:00
Stephan Kulow
0561e06cb1 Target E261 - two spaces before inline comment 2022-02-18 16:39:16 +01:00
Stephan Kulow
dc62b2ed78 Target E711 - compare against None with 'is' not != 2022-02-18 15:56:45 +01:00
Stephan Kulow
d6628beadf Target E125 - Continuation line with same indent
https://www.flake8rules.com/rules/E125.html
2022-02-18 15:52:53 +01:00
Stephan Kulow
66a0f152ff Target E129 - Visually indented line with same indent
https://www.flake8rules.com/rules/E129.html
2022-02-18 15:52:47 +01:00
Stephan Kulow
ae734ba555 Fix indent of statements E127
https://www.flake8rules.com/rules/E127.html
2022-02-18 14:23:59 +01:00
Stephan Kulow
2de74cfc52 Replace variable name 'l' (x is fine)
https://www.flake8rules.com/rules/E741.html
2022-02-18 14:21:59 +01:00
Stephan Kulow
f705a24db1 Only have one statement in a line E701
https://www.flake8rules.com/rules/E701.html
2022-02-18 13:42:57 +01:00
Stephan Kulow
52dbb52b7f
Merge pull request #2703 from coolo/drop_etree
Harmonize imports on using lxml for XML parsing
2022-02-18 12:50:18 +01:00
Stephan Kulow
c1a66f9997
Merge pull request #2704 from coolo/remove_bare_excepts
Remove bare excepts - https://www.flake8rules.com/rules/E722.html
2022-02-18 12:50:05 +01:00
Stephan Kulow
1152d4c419 Remove bare excepts - https://www.flake8rules.com/rules/E722.html
The bare except in osc-credentials lead me to remove it and the scripts
using it
2022-02-18 12:03:56 +01:00
Stephan Kulow
e52dc6ce2b Harmonize imports on using lxml for XML parsing 2022-02-18 11:16:01 +01:00
Stephan Kulow
177a654eb1 Remove --by-develproject for adi command
It's pointless by now as we have no project that uses devel projects
and would accept submissions not coming from there

Fixes #1366 (kindof)
2022-02-17 12:04:25 +01:00
Stephan Kulow
dafa42d3df Support to move one staging into another
osc staging select --move adi:26 adi:14

If move is given, all staging projects given after the first will
be seen as source

Fixes #1105
2022-02-15 15:00:14 +01:00