59 Commits

Author SHA1 Message Date
Stephan Kulow
5d0f0e3145 Fix check_source with python3
Fixes #2038
2019-05-16 13:17:32 +02:00
Stephan Kulow
6f83acfae4 Run source and repo checker in python3 2019-05-16 06:39:28 +02:00
Stephan Kulow
fec762e5a4 Avoid warning on using .warn (python3) 2019-05-11 14:25:02 +02:00
Stephan Kulow
646ce308d7 Only decline delete requests that affect linked packages within the target
This decline reason came from https://github.com/openSUSE/openSUSE-release-tools/pull/603
without much more context, so I'm guessing it's about delete requests for
e.g. kernel-default that should delete kernel-source

Packages that link to *other* projects basically do not exist in openSUSE
distributions but are very common in SLE service packs, so we need to diff
on this.

Fixes #1824
2019-01-09 12:58:54 +01:00
Stephan Kulow
ea9061ccf5 Import urllib2 python agnostic 2018-11-16 09:01:45 +01:00
Jimmy Berry
a87cca01b7 check_source: check if member of staging group before attempting to skip.
SLE likes to be different for the sake of it.
2018-11-06 16:15:20 -06:00
Jimmy Berry
406fc41a85 ReviewBots: utilize delete_package check where it was already assumed. 2018-09-17 17:15:23 -05:00
Jimmy Berry
658137b9e9 check_source: split out delete repository check to new sub action check. 2018-09-17 17:14:48 -05:00
Jimmy Berry
ecbc806b2d check_source: decline all delete project requests. 2018-09-17 17:13:58 -05:00
Jimmy Berry
d1022403cb
Merge pull request #1691 from lnussel/check_source
check_source: reset skip_add_reviews for each request
2018-09-13 16:57:31 -05:00
dbf31de9af check_source: ignore _product package check 2018-09-13 20:49:56 +08:00
Ludwig Nussel
db9375336b check_source: reset skip_add_reviews for each request
skip_add_reviews needs to be reset, otherwise a single
maintenance_incident request affects the rest of the work queue.
2018-09-12 11:48:23 +02:00
Jimmy Berry
31d6a872c7 check_source: replace maintbot usage with ReviewBot methods. 2018-08-22 21:24:58 -05:00
Jimmy Berry
1012b62830 ReviewBots: utilize Config.get() instead of self.staging_config. 2018-08-17 10:16:47 -05:00
Jimmy Berry
343213fb48 check_source: drop staging_group() for target_project_config().
The staging_group() method pre-dates the target_project_config(), but
essentially accomplishes the same for a single value.
2018-08-17 10:04:34 -05:00
Jimmy Berry
e46d9b0910 check_source: allow for dot in package name during in-air rename check. 2018-08-13 22:47:01 -05:00
Jimmy Berry
4c129bec3c check_source: skip adding reviews for incidents in favor of maintbot. 2018-06-28 12:25:24 -05:00
Jimmy Berry
da36ae9931 check_source: replace one action limitation with configurable rule.
Allows tool to be used on multi-action requests while still enforcing
the rule for Factory and Leap which should reject such requests due to
staging process.
2018-06-28 12:14:19 -05:00
Jimmy Berry
6092ff55c8 check_source: override rename project setting for maintenance_incident. 2018-06-28 12:11:24 -05:00
Jimmy Berry
bfcc1ddf86 check_source: rework rename check to allow for suffixed :Update packages.
Exact name matching is thus always enforced for projects requiring devel
project enforcement (ie. Factory), but relaxed to compare without suffix
for packages coming from an :Update project.
2018-06-28 12:10:19 -05:00
Ludwig Nussel
d372c5132c
Merge pull request #1466 from jberry-suse/check_source-default-handler
check_source: make use of ReviewBot request_default_return.
2018-03-19 16:35:16 +01:00
Jimmy Berry
60a9e7decb check_source: make use of ReviewBot request_default_return. 2018-03-16 14:21:41 -05:00
Jimmy Berry
42139de4d6 check_source: delete: place maintainer review check behind ignore_devel.
SLE does not utilize devel projects and so adding such reviewer does not
make sense. Additionally, for Leap the right review will depend on origin
which leaper handles.
2018-03-16 14:11:12 -05:00
Jimmy Berry
a7e36b03f7 check_source: provide in-air-rename-allow config setting. 2018-03-16 14:09:02 -05:00
Sebastian Riedel
d991c97a6c check_source: skip all checks for 00* packages 2018-03-15 16:04:38 +01:00
Ludwig Nussel
d66ea3a0b2 check_source: make adding review team configurable 2018-03-09 14:34:42 +01:00
Ludwig Nussel
31b35832d7 check_source: fix boolean option 2018-03-09 13:50:08 +01:00
Oliver Kurz
110c729fc8 check_source: add hint about how to whitelist a devel projects.
Output looks like this:
[I] 559982 declined: home:XRevan86:non-free is not a devel project of
openSUSE:Factory:NonFree, submit the package to a devel project first. See
https://en.opensuse.org/openSUSE:How_to_contribute_to_Factory#How_to_request_a_new_devel_project
for details
2018-01-25 18:04:39 -06:00
Jimmy Berry
c7eb985de8 check_source: add_role: utilize devel project fallback.
Otherwise, for Leap the message will always print None/None.
2018-01-19 08:49:05 -06:00
Jimmy Berry
8c4891bd95 ReviewBot: replace get_devel_project() with osclib.core.devel_project_get(). 2018-01-17 18:09:30 -06:00
Jimmy Berry
b8f9fb6853 check_source: load target project config during check_action_delete().
Otherwise, causes fatal crash trying to access self.repo_checker.
2018-01-03 20:01:12 -06:00
7e1b42fe41 check_source: Ignore download_files failure in some cases 2017-11-22 17:29:14 +08:00
Jimmy Berry
3349bd964a Merge pull request #1197 from dirkmueller/python3
Python 2.6+ / 3.x style except clauses
2017-10-18 20:50:02 -05:00
7058f07d71 Merge pull request #1194 from nilxam/decline_more_invalid_dr
check_source: decline the delete request if duplicated
2017-10-17 15:23:26 +08:00
475b8473df check_source: decline the delete request if duplicated
Decline the delete request in case there is pending delete/submit request to
the same package, if there is another submit request against the same package
that we should prefer the submit one which should be passed staging already,
what it means just queued for accepting, like request go through adi or virtual
accept delete request.
2017-10-17 14:42:29 +08:00
3cf49d9556 Python 2.6+ / 3.x style except clauses
This newer style except statement allows for compatibility with
Python 3.x and does not harm on python 2.6+.
2017-10-16 22:47:58 +02:00
Jimmy Berry
37d397fb89 check_source: move all relevant flags to config to work properly without flags. 2017-10-11 22:31:58 -05:00
Jimmy Berry
52af5b3d75 check_source: print message if checking devel project.
Currently, no indication unless ends in decline. More important when moving
option to config rather than flag.
2017-10-11 22:14:42 -05:00
Ludwig Nussel
afbe1495de Merge pull request #1166 from DimStar77/fa-norename
check_source: Ensure the source and destination package name matches
2017-10-09 14:01:10 +02:00
272348bc21
check_source: Ensure the source and destination package name matches 2017-10-06 17:24:25 +02:00
Jimmy Berry
a825af82a0 check_source: lookup staging group using StagingAPI rather than flag. 2017-10-04 15:31:28 -05:00
Jimmy Berry
c081de6025 check_source: interpret "None" as python None for review-team and repo-checker.
Allows for disabling adding those reviews from the command line.
2017-10-04 15:31:22 -05:00
Jimmy Berry
1e9c389617 check_source: drop inaccurate "with > 8 diff" from --review-team option. 2017-10-04 15:15:18 -05:00
Jimmy Berry
73df8871f1 check_source: drop unnecessary dest from add_option(). 2017-10-04 15:13:32 -05:00
Jimmy Berry
6afbc550ad check_source: rename perl and asciidoc to match name. 2017-08-18 15:18:04 -05:00
Jimmy Berry
0980989206 check_source: remove DIFFCOUNT algorithm and instead always add review_team. 2017-08-18 15:15:26 -05:00
Jimmy Berry
8711b45f4a Merge pull request #1017 from jberry-suse/source_check-repo_checker-default
check_source: change repo_checker default to new OBS username.
2017-08-14 11:44:16 -05:00
Jimmy Berry
12b84757a2 check_source: add devel review for delete request using MaintenanceChecker logic. 2017-07-27 19:31:46 -05:00
Jimmy Berry
a61cf8a2f0 check_source: utilize project config to allow for remote entries.
Rather than updating a local whitelist file for temporary devel project
whitelist entries it makes more sense to allow for remote configuration.
2017-07-18 23:48:47 -05:00
Jimmy Berry
c08887e3ec check_source: change repo_checker default to new OBS username.
To distinguish from the old factory-repo-checker and use a generic name
applicable to Leap as well.
2017-07-18 22:51:26 -05:00