Dirk Mueller
3cf49d9556
This newer style except statement allows for compatibility with Python 3.x and does not harm on python 2.6+.
239 lines
10 KiB
Python
Executable File
239 lines
10 KiB
Python
Executable File
#!/usr/bin/python
|
|
# Copyright (c) 2014 SUSE Linux Products GmbH
|
|
#
|
|
# Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
# of this software and associated documentation files (the "Software"), to deal
|
|
# in the Software without restriction, including without limitation the rights
|
|
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
# copies of the Software, and to permit persons to whom the Software is
|
|
# furnished to do so, subject to the following conditions:
|
|
#
|
|
# The above copyright notice and this permission notice shall be included in
|
|
# all copies or substantial portions of the Software.
|
|
#
|
|
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
# SOFTWARE.
|
|
|
|
from pprint import pprint
|
|
import os, sys, re
|
|
import logging
|
|
from optparse import OptionParser
|
|
import cmdln
|
|
|
|
try:
|
|
from xml.etree import cElementTree as ET
|
|
except ImportError:
|
|
import cElementTree as ET
|
|
|
|
import osc.conf
|
|
import osc.core
|
|
import urllib2
|
|
import yaml
|
|
import ReviewBot
|
|
from itertools import count
|
|
|
|
|
|
class FactorySourceChecker(ReviewBot.ReviewBot):
|
|
""" this review bot checks if the sources of a submission are
|
|
either in Factory or a request for Factory with the same sources
|
|
exist. If the latter a request is only accepted if the Factory
|
|
request is reviewed positive."""
|
|
|
|
def __init__(self, *args, **kwargs):
|
|
ReviewBot.ReviewBot.__init__(self, *args, **kwargs)
|
|
self.factory = "openSUSE:Factory"
|
|
self.review_messages = { 'accepted' : 'ok', 'declined': 'the package needs to be accepted in Factory first' }
|
|
self.lookup = {}
|
|
self.history_limit = 5
|
|
|
|
def reset_lookup(self):
|
|
self.lookup = {}
|
|
|
|
def parse_lookup(self, project):
|
|
self.lookup.update(yaml.safe_load(self._load_lookup_file(project)))
|
|
|
|
def _load_lookup_file(self, prj):
|
|
return osc.core.http_GET(osc.core.makeurl(self.apiurl,
|
|
['source', prj, '00Meta', 'lookup.yml']))
|
|
|
|
def check_source_submission(self, src_project, src_package, src_rev, target_project, target_package):
|
|
super(FactorySourceChecker, self).check_source_submission(src_project, src_package, src_rev, target_project, target_package)
|
|
src_srcinfo = self.get_sourceinfo(src_project, src_package, src_rev)
|
|
if src_srcinfo is None:
|
|
# source package does not exist?
|
|
# handle here to avoid crashing on the next line
|
|
self.logger.info("Could not get source info for %s/%s@%s" % (src_project, src_package, src_rev))
|
|
return False
|
|
projects = self._package_get_upstream_projects(target_package)
|
|
if projects is None:
|
|
self.logger.error("no upstream project found for {}, can't check".format(target_package))
|
|
return False
|
|
|
|
self.review_messages['declined'] = 'the package needs to be accepted in {} first'.format(' or '.join(projects))
|
|
for project in projects:
|
|
self.logger.info("Checking in project %s" % project)
|
|
good = self._check_project(project, target_package, src_srcinfo.verifymd5)
|
|
if good:
|
|
self.logger.info("{} is in {}".format(target_package, project))
|
|
return good
|
|
|
|
good = self._check_requests(project, target_package, src_srcinfo.verifymd5)
|
|
if good:
|
|
self.logger.info("{} already reviewed for {}".format(target_package, project))
|
|
|
|
if not good:
|
|
self.logger.info('{} failed source submission check'.format(target_package))
|
|
|
|
return good
|
|
|
|
def _package_get_upstream_projects(self, package):
|
|
""" return list of projects where the specified package is supposed to come
|
|
from. Either by lookup table or self.factory """
|
|
projects = self.factory
|
|
if self.lookup and package in self.lookup:
|
|
projects = self.lookup[package]
|
|
|
|
if isinstance(projects, basestring):
|
|
projects = [projects]
|
|
|
|
return projects
|
|
|
|
def _check_project(self, project, package, rev):
|
|
"""check if factory sources contain the package and revision. check head and history"""
|
|
self.logger.debug("checking %s in %s"%(package, project))
|
|
try:
|
|
si = osc.core.show_package_meta(self.apiurl, project, package)
|
|
except (urllib2.HTTPError, urllib2.URLError):
|
|
si = None
|
|
if si is None:
|
|
self.logger.debug("new package")
|
|
return None
|
|
else:
|
|
si = self.get_sourceinfo(project, package)
|
|
if rev == si.verifymd5:
|
|
self.logger.debug("srcmd5 matches")
|
|
return True
|
|
|
|
self.logger.debug("%s not the latest version, checking history", rev)
|
|
u = osc.core.makeurl(self.apiurl, [ 'source', project, package, '_history' ], { 'limit': self.history_limit })
|
|
try:
|
|
r = osc.core.http_GET(u)
|
|
except urllib2.HTTPError as e:
|
|
self.logger.debug("package has no history!?")
|
|
return None
|
|
|
|
root = ET.parse(r).getroot()
|
|
# we need this complicated construct as obs doesn't honor
|
|
# the 'limit' parameter use above for obs interconnect:
|
|
# https://github.com/openSUSE/open-build-service/issues/2545
|
|
for revision, i in zip(reversed(root.findall('revision')), count()):
|
|
node = revision.find('srcmd5')
|
|
if node is None:
|
|
continue
|
|
self.logger.debug("checking %s"%node.text)
|
|
if node.text == rev:
|
|
self.logger.debug("got it, rev %s"%revision.get('rev'))
|
|
return True
|
|
if i == self.history_limit:
|
|
break
|
|
|
|
self.logger.debug("srcmd5 not found in history either")
|
|
return False
|
|
|
|
def _check_requests(self, project, package, rev):
|
|
self.logger.debug("checking requests")
|
|
prjprefix = ''
|
|
apiurl = self.apiurl
|
|
sr = 'sr'
|
|
try:
|
|
if self.config.project_namespace_api_map:
|
|
for prefix, url, srprefix in self.config.project_namespace_api_map:
|
|
if project.startswith(prefix):
|
|
apiurl = url
|
|
prjprefix = prefix
|
|
project = project[len(prefix):]
|
|
sr = srprefix
|
|
break
|
|
requests = osc.core.get_request_list(apiurl, project, package, None, ['new', 'review'], 'submit')
|
|
except (urllib2.HTTPError, urllib2.URLError):
|
|
self.logger.error("caught exception while checking %s/%s", project, package)
|
|
return None
|
|
|
|
def srref(reqid):
|
|
return '#'.join((sr, reqid))
|
|
|
|
for req in requests:
|
|
for a in req.actions:
|
|
si = self.get_sourceinfo(prjprefix + a.src_project, a.src_package, a.src_rev)
|
|
self.logger.debug("rq %s: %s/%s@%s"%(req.reqid, prjprefix + a.src_project, a.src_package, si.verifymd5))
|
|
if si.verifymd5 == rev:
|
|
if req.state.name == 'new':
|
|
self.logger.info("%s ok", srref(req.reqid))
|
|
return True
|
|
elif req.state.name == 'review':
|
|
self.logger.debug("%s still in review", srref(req.reqid))
|
|
if not req.reviews:
|
|
self.logger.error("%s in state review but no reviews?", srref(req.reqid))
|
|
return False
|
|
for r in req.reviews:
|
|
if r.by_project and r.state == 'new' and r.by_project.startswith('openSUSE:Factory:Staging:'):
|
|
self.logger.info("%s review by %s ok", srref(req.reqid), r.by_project)
|
|
continue
|
|
if r.state != 'accepted':
|
|
if r.by_user:
|
|
self.logger.info("%s waiting for review by %s", srref(req.reqid), r.by_user)
|
|
elif r.by_group:
|
|
self.logger.info("%s waiting for review by %s", srref(req.reqid), r.by_group)
|
|
elif r.by_project:
|
|
if r.by_package:
|
|
self.logger.info("%s waiting for review by %s/%s", srref(req.reqid), r.by_project, r.by_package)
|
|
else:
|
|
self.logger.info("%s waiting for review by %s", srref(req.reqid), r.by_project)
|
|
return None
|
|
return True
|
|
else:
|
|
self.logger.error("%s in state %s not expected", srref(req.reqid), req.state.name)
|
|
return None
|
|
else:
|
|
self.logger.info("%s to %s has different sources", srref(req.reqid), project)
|
|
return False
|
|
|
|
class CommandLineInterface(ReviewBot.CommandLineInterface):
|
|
|
|
def __init__(self, *args, **kwargs):
|
|
ReviewBot.CommandLineInterface.__init__(self, args, kwargs)
|
|
self.clazz = FactorySourceChecker
|
|
|
|
def get_optparser(self):
|
|
parser = ReviewBot.CommandLineInterface.get_optparser(self)
|
|
parser.add_option("--factory", metavar="project", action="append",
|
|
help=("Project to check source against. Use multiple times to check more than one project. "
|
|
"[default: openSUSE:Factory]"))
|
|
parser.add_option("--lookup", metavar="project", help="use lookup file")
|
|
parser.add_option("--limit", metavar="limit", help="how many revisions back to check. [default: 5]")
|
|
|
|
return parser
|
|
|
|
def setup_checker(self):
|
|
bot = ReviewBot.CommandLineInterface.setup_checker(self)
|
|
|
|
if self.options.factory:
|
|
bot.factory = self.options.factory
|
|
if self.options.lookup:
|
|
bot.parse_lookup(self.options.lookup)
|
|
if self.options.limit:
|
|
bot.history_limit = self.options.limit
|
|
|
|
return bot
|
|
|
|
if __name__ == "__main__":
|
|
app = CommandLineInterface()
|
|
sys.exit( app.main() )
|
|
|
|
# vim: sw=4 et
|