0688993ffc
Maintenance, as usual, makes things rather complex since it may have single or multiple actions or which all, none, or some may be reviewable.
125 lines
5.5 KiB
Python
Executable File
125 lines
5.5 KiB
Python
Executable File
#!/usr/bin/python3
|
|
|
|
from osclib.core import package_source_hash
|
|
from osclib.origin import origin_annotation_dump
|
|
from osclib.origin import config_load
|
|
from osclib.origin import origin_find
|
|
from osclib.origin import policy_evaluate
|
|
import ReviewBot
|
|
import sys
|
|
|
|
|
|
class OriginManager(ReviewBot.ReviewBot):
|
|
def __init__(self, *args, **kwargs):
|
|
ReviewBot.ReviewBot.__init__(self, *args, **kwargs)
|
|
|
|
# ReviewBot options.
|
|
self.request_default_return = True
|
|
self.override_allow = False
|
|
|
|
def check_action_delete_package(self, request, action):
|
|
advance, result = self.config_validate(action.tgt_project)
|
|
if not advance:
|
|
return result
|
|
|
|
origin_info_old = origin_find(self.apiurl, action.tgt_project, action.tgt_package)
|
|
|
|
reviews = {'fallback': 'Delete requests require fallback review.'}
|
|
self.policy_result_reviews_add(action.tgt_project, action.tgt_package,
|
|
reviews, origin_info_old, origin_info_old)
|
|
|
|
return True
|
|
|
|
def check_source_submission(self, src_project, src_package, src_rev, tgt_project, tgt_package):
|
|
advance, result = self.config_validate(tgt_project)
|
|
if not advance:
|
|
return result
|
|
|
|
source_hash_new = package_source_hash(self.apiurl, src_project, src_package, src_rev)
|
|
origin_info_new = origin_find(self.apiurl, tgt_project, tgt_package, source_hash_new)
|
|
|
|
source_hash_old = package_source_hash(self.apiurl, tgt_project, tgt_package)
|
|
origin_info_old = origin_find(self.apiurl, tgt_project, tgt_package, source_hash_old, True)
|
|
|
|
result = policy_evaluate(self.apiurl, tgt_project, tgt_package,
|
|
origin_info_new, origin_info_old,
|
|
source_hash_new, source_hash_old)
|
|
return self.policy_result_handle(tgt_project, tgt_package, origin_info_new, origin_info_old, result)
|
|
|
|
def config_validate(self, target_project):
|
|
config = config_load(self.apiurl, target_project)
|
|
if not config:
|
|
# No perfect solution for lack of a config. For normal projects a
|
|
# decline seems best, but in the event of failure to return proper
|
|
# config no good behavior. For maintenance the situation is further
|
|
# complicated since multiple actions some of which are not intended
|
|
# to be reviewed, but not always guaranteed to see multiple actions.
|
|
self.review_messages['accepted'] = 'skipping since no OSRT:OriginConfig'
|
|
return False, True
|
|
if not config.get('fallback-group'):
|
|
self.review_messages['declined'] = 'OSRT:OriginConfig.fallback-group missing'
|
|
return False, False
|
|
if not self.dryrun and config['review-user'] != self.review_user:
|
|
self.logger.warning(
|
|
'OSRT:OriginConfig.review-user ({}) does not match ReviewBot.review_user ({})'.format(
|
|
config['review-user'], self.review_user))
|
|
|
|
return True, True
|
|
|
|
def policy_result_handle(self, project, package, origin_info_new, origin_info_old, result):
|
|
self.policy_result_reviews_add(project, package, result.reviews, origin_info_new, origin_info_old)
|
|
self.policy_result_comment_add(project, package, result.comments)
|
|
|
|
if result.wait:
|
|
# Allow overriding a policy wait by accepting as workaround with the
|
|
# hope that pending request will be accepted.
|
|
override = self.request_override_check(self.request, True)
|
|
if override:
|
|
self.review_messages['accepted'] = origin_annotation_dump(
|
|
origin_info_new, origin_info_old, self.review_messages['accepted'], raw=True)
|
|
return override
|
|
else:
|
|
if result.accept:
|
|
self.review_messages['accepted'] = origin_annotation_dump(
|
|
origin_info_new, origin_info_old, raw=True)
|
|
return result.accept
|
|
|
|
return None
|
|
|
|
def policy_result_reviews_add(self, project, package, reviews, origin_info_new, origin_info_old):
|
|
for key, comment in reviews.items():
|
|
if key == 'maintainer':
|
|
self.devel_project_review_ensure(self.request, project, package, comment)
|
|
elif key == 'fallback':
|
|
fallback_group = config_load(self.apiurl, project).get('fallback-group')
|
|
comment += '\n\n' + origin_annotation_dump(origin_info_new, origin_info_old)
|
|
self.add_review(self.request, by_group=fallback_group, msg=comment)
|
|
else:
|
|
self.add_review(self.request, by_group=key, msg=comment)
|
|
|
|
def policy_result_comment_add(self, project, package, comments):
|
|
message = '\n\n'.join(comments)
|
|
if len(self.request.actions) > 1:
|
|
message = '## {}/{}\n\n{}'.format(project, package, message)
|
|
suffix = '::'.join([project, package])
|
|
else:
|
|
suffix = None
|
|
|
|
only_replace = False
|
|
if not len(comments):
|
|
message = 'Previous comment no longer relevant.'
|
|
only_replace = True
|
|
|
|
self.comment_write(state='seen', message=message, identical=True,
|
|
only_replace=only_replace, bot_name_suffix=suffix)
|
|
|
|
|
|
class CommandLineInterface(ReviewBot.CommandLineInterface):
|
|
def __init__(self, *args, **kwargs):
|
|
ReviewBot.CommandLineInterface.__init__(self, *args, **kwargs)
|
|
self.clazz = OriginManager
|
|
|
|
if __name__ == "__main__":
|
|
app = CommandLineInterface()
|
|
sys.exit(app.main())
|