Adam Majer adamm
1 Followers · 0 Following
  • Joined on 2023-07-21
Repositories
44
 Projects Packages Public Activity Starred Repositories
adamm pushed to test1 at git-workflow/autogits 2026-02-26 21:57:26 +01:00
7af2068801 test1
adamm created branch test1 in git-workflow/autogits 2026-02-26 21:57:25 +01:00
adamm deleted branch pending-reviews-not-seen from git-workflow/autogits 2026-02-26 21:23:37 +01:00
adamm commented on pull request git-workflow/autogits#142 2026-02-26 21:08:33 +01:00
pending-reviews

Bah ... tests failing ... fixing.

adamm commented on pull request git-workflow/autogits#138 2026-02-26 20:57:17 +01:00
WIP: fix: reviews may be ahead of timeline

I've pushed my changes along with the test changes from this PR to #142 . Can you please take a look and check that this "race condition" is fixed?

In reality, the problem was that issue…

adamm created pull request git-workflow/autogits#142 2026-02-26 20:22:36 +01:00
pending-reviews
adamm created branch pending-reviews in git-workflow/autogits 2026-02-26 20:21:28 +01:00
adamm pushed to pending-reviews at git-workflow/autogits 2026-02-26 20:21:28 +01:00
b4b3bf584e t: correctly handle multiple reviews from the same user
adamm pushed to pending-reviews-not-seen at git-workflow/autogits 2026-02-26 20:09:34 +01:00
65307cfb5e common: check for old pending request reviews
5669083388 pr: handle case of nil user in reviews
cb9131a5dd t: add init process to all services
Compare 3 commits »
adamm created branch pending-reviews-not-seen in git-workflow/autogits 2026-02-26 17:11:26 +01:00
adamm pushed to pending-reviews-not-seen at git-workflow/autogits 2026-02-26 17:11:26 +01:00
3ae7cf0d82 tests
ff621a6d70 common: check for old pending request reviews
Compare 2 commits »
adamm pushed to main at git-workflow/autogits 2026-02-26 13:16:07 +01:00
5669083388 pr: handle case of nil user in reviews
adamm commented on issue git-workflow/autogits#139 2026-02-26 12:22:22 +01:00
bots in containers leave many defunct processes

I would be interested to see the patch regardless. I saw this issue running in container too.

adamm commented on pull request git-workflow/autogits#138 2026-02-25 18:02:44 +01:00
WIP: fix: reviews may be ahead of timeline

ok, I think I understand where the problem is. Let me make a unit test and fix and you can merge that into this pr?

adamm deleted branch new-packages from git-workflow/autogits 2026-02-25 17:53:57 +01:00
adamm commented on pull request git-workflow/autogits#138 2026-02-25 17:32:54 +01:00
WIP: fix: reviews may be ahead of timeline

Basically, you should end up in same situation. A race condition, ie. you add a review trigger that is not seen in timeline, means that the timeline is modified asynchronously after requests…

adamm commented on pull request git-workflow/autogits#138 2026-02-25 17:24:34 +01:00
WIP: fix: reviews may be ahead of timeline

I think this is correct. The timeline could be behind rawReviews, but those rawReviews that are not on the timeline should be ignored.

adamm merged pull request git-workflow/autogits#136 2026-02-25 14:49:39 +01:00
staging-updates
adamm pushed to main at git-workflow/autogits 2026-02-25 14:49:38 +01:00
582df2555b Merge branch 'staging-updates'
91d22f7eea staging: add tests for idempotency and label changes
913b8c8a4b staging: Match previous message format
e1825dc658 staging: CommentPROnce everywhere
59965e7b5c staging: comment once on PRs using timeline
Compare 18 commits »
adamm commented on pull request git-workflow/autogits#108 2026-02-25 12:53:50 +01:00
New package handling

rebased and merged.