Alberto Planas aplanas
  • Joined on 2022-08-17
aplanas reopened issue importers/git-importer#14 2022-11-03 14:43:35 +01:00
firewalld creates a broken tree with merged commits in wrong order
aplanas closed issue importers/git-importer#14 2022-11-03 14:42:11 +01:00
firewalld creates a broken tree with merged commits in wrong order
aplanas commented on issue importers/git-importer#14 2022-11-03 14:42:11 +01:00
firewalld creates a broken tree with merged commits in wrong order

Can this be the expected mapping?

- commit: openSUSE:Factory/firewalld/31.0
  merged:
  - revert: openSUSE:Factory/firewalld/30.0
- commit: openSUSE:Factory/firewalld/30.0
  merged:
 …
aplanas approved importers/git-importer#11 2022-11-03 14:23:45 +01:00
implement file caching
aplanas approved importers/git-importer#11 2022-11-03 14:18:16 +01:00
implement file caching

One nit in comments, but LGTM

aplanas commented on pull request importers/git-importer#11 2022-11-03 14:18:16 +01:00
implement file caching

I liked more when it did not contain the {name}? This makes a pure object access. Now if two files has the same content but different name (LICENSE / license, README / README.txt) but the same content it will create two files.

aplanas commented on pull request importers/git-importer#11 2022-11-03 14:01:34 +01:00
implement file caching

There are many ways to fix this issue. For now try this one:

  1. git rebase -i Very carefully, drop the 4 commits that you see here that are from coolo
  2. :wq
  3. git fetch --all
  4. git…
aplanas commented on pull request importers/git-importer#11 2022-11-03 13:53:17 +01:00
implement file caching

@nkrapp seems that you introduced some extra commits? Can you rebase?

aplanas commented on pull request importers/git-importer#11 2022-11-03 12:31:44 +01:00
implement file caching

Can be fun to check if this is true, like creating a repo, commiting a file, creating a branch, updating the file in the branch, and create a hard link outside of the repo. If a checkout into…

aplanas commented on pull request importers/git-importer#11 2022-11-03 11:37:57 +01:00
implement file caching

Do we know how git handles files in its working copy when you e.g. checkout a different branch?

When possible, hardlinks: https://git-scm.com/docs/git-clone/

aplanas commented on pull request importers/git-importer#11 2022-11-03 11:36:18 +01:00
implement file caching

Can be copying 1.3M files a bit expensive? (I did not measure it, but my crappy HD is killing me every morning)

aplanas commented on pull request importers/git-importer#11 2022-11-03 11:01:03 +01:00
implement file caching

I think so, right? If we unlink we should be keeping the cached version (copy or link) without risk of changing the content. What do you think?

aplanas commented on pull request importers/git-importer#13 2022-11-03 10:59:50 +01:00
Fix the import of breeze and other packages

The problem starts with using "the" in front of "devel project" - because green is KDE:Frameworks5 (the devel project now) and purple is KDE:Frameworks5:LTS (the devel project between august and…

aplanas commented on pull request importers/git-importer#13 2022-11-03 10:54:51 +01:00
Fix the import of breeze and other packages

Note that the red line is Factory in the 2nd picture while it's devel branch in the 1st picture.

In the second image the green line is the devel project? What is the 3rd line? For example I…

aplanas commented on pull request importers/git-importer#13 2022-11-03 10:47:10 +01:00
Fix the import of breeze and other packages

I do not understand this as a rebase. IIUC this is setting "refs/heads/{devel,factory}" reference to the parent1 commit, and checking out later this reference.

aplanas commented on pull request importers/git-importer#11 2022-11-03 08:07:47 +01:00
implement file caching

As datapoint: we're talking about 1.3M files - that would be still ~5000 files per directory. The git objects are packed for a reason - there are not supposed to be 1.3M of them.

In that case…