Alberto Planas aplanas
  • Joined on 2022-08-17
aplanas pushed to main at importers/git-importer 2022-12-02 09:35:41 +01:00
9962673eff Merge pull request 'Add force push for the devel branch' (#21) from add_force into main
7b20c03256 Add force push for the devel branch
Compare 2 commits »
aplanas merged pull request importers/git-importer#21 2022-12-02 09:35:40 +01:00
Add force push for the devel branch
aplanas commented on pull request importers/git-importer#20 2022-11-14 08:08:28 +01:00
Also treat some more mimetypes as text

OK for me, but this seems like a non-binary suffix

aplanas commented on pull request importers/git-importer#18 2022-11-08 10:05:44 +01:00
No longer rely on external service for LFS tracking

IMHO do not mix both. Keep sha256 as a partial function, like the md5. This will work on the download-file-a-like handler.

The mime-type can be keep here (keeping an additional read), or moved…

aplanas commented on pull request importers/git-importer#18 2022-11-08 09:51:37 +01:00
No longer rely on external service for LFS tracking

ah ok, you use the loop for this, imho it is ok to move it out

aplanas commented on pull request importers/git-importer#18 2022-11-08 09:51:37 +01:00
No longer rely on external service for LFS tracking

Here. This should be dropped.

aplanas commented on pull request importers/git-importer#18 2022-11-08 09:51:37 +01:00
No longer rely on external service for LFS tracking

Do not remove the sha256, can be used during the download call (without storing the file). Note that you reimplemented it later with a similiar for

aplanas commented on pull request importers/git-importer#19 2022-11-08 09:46:32 +01:00
Push to the remote when the repo changed

eventually factory and devel should go out of the Git class

aplanas commented on pull request importers/git-importer#17 2022-11-07 09:13:05 +01:00
Fix the maintenance of .gitattributes file

I am not sure that I like the first commit, where the the pool is dropped if there is only one package. If debug is the problem, we should improve the logs.

aplanas commented on pull request importers/git-importer#16 2022-11-04 09:54:57 +01:00
Run many packages in parallel to avoid overhead and make use of CPUS

seems safer

aplanas commented on pull request importers/git-importer#16 2022-11-04 08:13:53 +01:00
Run many packages in parallel to avoid overhead and make use of CPUS

Why is this required?

aplanas commented on pull request importers/git-importer#16 2022-11-04 08:13:53 +01:00
Run many packages in parallel to avoid overhead and make use of CPUS

Same? Is there any transaction open?

aplanas commented on pull request importers/git-importer#16 2022-11-04 08:13:53 +01:00
Run many packages in parallel to avoid overhead and make use of CPUS

Is not closing the cursor with doing the commit?

aplanas commented on pull request importers/git-importer#16 2022-11-04 08:13:53 +01:00
Run many packages in parallel to avoid overhead and make use of CPUS

Making max_workers to None will create one process per CPU. That is OK in my desktop, but laptop report like 32 of them, and I am sure this will kill OBS. Maybe create a parameter with some low default?

aplanas commented on pull request importers/git-importer#16 2022-11-04 08:13:53 +01:00
Run many packages in parallel to avoid overhead and make use of CPUS

You mean > 1?