Alberto Planas aplanas

0 Followers · 0 Following

• Joined on 2022-08-17

Repositories

3

Projects Packages Public Activity Starred Repositories

aplanas commented on pull request importers/git-importer#11 2022-11-03 08:04:30 +01:00

implement file caching

Uhm there is the risk of changing the cached version after the next update. Maybe is better to unlink first the fileif present (IIRC there is a parameter to remove any error in the file does not…

aplanas commented on pull request importers/git-importer#11 2022-11-02 17:26:45 +01:00

implement file caching

there is a risk of commiting this into git? maybe use cache = Path("~/.cache/git-import/").expanduser()

aplanas commented on pull request importers/git-importer#11 2022-11-02 17:26:45 +01:00

implement file caching

return self._path_from_md5(name, dirpath, md5).exists()

aplanas commented on pull request importers/git-importer#11 2022-11-02 17:26:45 +01:00

implement file caching

Try firt a hardlink to save space and speed up the cache:

aplanas commented on pull request importers/git-importer#11 2022-11-02 17:26:45 +01:00

implement file caching

as explained later, maybe dirpath can be removed

aplanas commented on pull request importers/git-importer#11 2022-11-02 17:26:45 +01:00

implement file caching

you create the directories here, so you can skeip lines 192 and 193

aplanas commented on pull request importers/git-importer#11 2022-11-02 17:26:45 +01:00

implement file caching

I propose to use the same model than git (also drop joinpath): filepath = cache / md5[:2] / md5[2:]

aplanas created repository aplanas/git-importer 2022-11-02 16:28:37 +01:00

aplanas approved importers/git-importer#10 2022-11-02 16:27:21 +01:00

Fix up some code after aplanas' continued review

One nit, but LGTM

aplanas commented on pull request importers/git-importer#10 2022-11-02 16:26:35 +01:00

Fix up some code after aplanas' continued review

Path(entry["name"]), do not use PurePath, only Path

aplanas created pull request mold/core#3 2022-11-02 14:53:48 +01:00

Fix URLs and commits form broken packages

aplanas pushed to main at aplanas/ring0_submodules 2022-11-02 14:53:34 +01:00

d184ec2eab Fix URLs and commits form broken packages

aplanas pushed to main at aplanas/ring0_submodules 2022-11-02 14:48:37 +01:00

cf74e3850e Fix linux-glibc-devel commit

aplanas pushed to main at aplanas/ring0_submodules 2022-11-02 14:47:45 +01:00

2b6cb0c913 Fix gcc12 commit

aplanas pushed to main at aplanas/ring0_submodules 2022-11-02 14:44:19 +01:00

e6499db244 Fix build commit

aplanas pushed to main at aplanas/ring0_submodules 2022-11-02 14:37:49 +01:00

b87133825c Fix gcc12 and build URLs

aplanas pushed to main at aplanas/ring0_submodules 2022-11-02 14:32:26 +01:00

7a5cae61d3 Update brp-check-suse

aplanas commented on pull request importers/git-importer#9 2022-11-02 14:19:47 +01:00

Export the built tree as git repo

p1_str = f" p1:{self.parent1.short_string()}" if self.parent1 else ""

aplanas commented on pull request importers/git-importer#9 2022-11-02 14:19:47 +01:00

Export the built tree as git repo

(more later)

aplanas commented on pull request importers/git-importer#9 2022-11-02 14:19:47 +01:00

Export the built tree as git repo

making it elif can remove the return