Alberto Planas aplanas
  • Joined on 2022-08-17
aplanas commented on pull request importers/git-importer#9 2022-11-02 14:19:47 +01:00
Export the built tree as git repo

same

aplanas commented on pull request importers/git-importer#9 2022-11-02 14:19:47 +01:00
Export the built tree as git repo

return file.endswith((".spec", ".changes"))

aplanas pushed to main at aplanas/ring0_submodules 2022-11-02 13:33:55 +01:00
112014a77d document local rebuild method
316633ac5b update
decba38cad update bash and readline
3b904ecd73 Merge pull request 'Test PR to submodules' (#1) from aplanas/ring0_submodules:main into main
e0ef83f320 update
Compare 17 commits »
aplanas commented on pull request importers/git-importer#9 2022-11-02 13:14:26 +01:00
Export the built tree as git repo

What I am wondering is the semantic of the function. calc_delta seems to be from some status to self. When the other status is not None the old_files is empty making all to download, when…

aplanas commented on pull request importers/git-importer#9 2022-11-02 13:07:11 +01:00
Export the built tree as git repo

right, the last line can be replaced with a for, but this change is for the for and if lines

aplanas commented on pull request importers/git-importer#9 2022-11-02 13:05:45 +01:00
Export the built tree as git repo

still the for two lines can be replaced

aplanas commented on pull request importers/git-importer#9 2022-11-02 13:05:07 +01:00
Export the built tree as git repo

but not in the call?

aplanas commented on pull request importers/git-importer#9 2022-11-02 12:02:10 +01:00
Export the built tree as git repo
aplanas commented on pull request importers/git-importer#9 2022-11-02 11:59:03 +01:00
Export the built tree as git repo

old_files.get(entry["name"]) != ..., will return None if missing.

aplanas commented on pull request importers/git-importer#9 2022-11-02 11:57:42 +01:00
Export the built tree as git repo

(no optional)

aplanas commented on pull request importers/git-importer#9 2022-11-02 11:57:28 +01:00
Export the built tree as git repo

Reading the code seems that current_rev is not optional.

aplanas commented on pull request importers/git-importer#9 2022-11-02 11:45:24 +01:00
Export the built tree as git repo

The last two lines: old_files = {e["name"]: f"{e['md5']}-{e['size']}" for e in current_rev.files_list(db)}

aplanas commented on pull request importers/git-importer#9 2022-11-02 11:38:01 +01:00
Export the built tree as git repo

if in L47 use a type pathlib.Path, like in L52, you will be sure that a path is given, and this line can be args.repodir = "repos" / args.package

aplanas pushed to main at importers/git-importer 2022-10-27 15:19:48 +02:00
6f83425538 Merge pull request 'Add a test case for a simpler and newer package' (#8) from add_second_test into main
83544e45d7 Add a test case for a simpler and newer package
Compare 2 commits »
aplanas merged pull request importers/git-importer#8 2022-10-27 15:19:48 +02:00
Add a test case for a simpler and newer package
aplanas commented on pull request importers/git-importer#7 2022-10-27 13:45:01 +02:00
Add actual tree and a test case for zsh

Instead of using a test case to generate the fixtures, create a funtion. One way here is that, because there is an __main__ check later, see if there is a parameter in sys.argv named…

aplanas commented on pull request importers/git-importer#7 2022-10-27 13:28:55 +02:00
Add actual tree and a test case for zsh

nit: the old build name was more descriptive?