Alberto Planas aplanas
  • Joined on 2022-08-17
aplanas commented on pull request importers/git-importer#7 2022-10-27 13:28:55 +02:00
Add actual tree and a test case for zsh

remove?

aplanas commented on pull request importers/git-importer#7 2022-10-27 13:28:55 +02:00
Add actual tree and a test case for zsh

drop?

aplanas commented on pull request importers/git-importer#4 2022-10-26 15:15:09 +02:00
Build a Tree of commits (at least prep it)

with context?

aplanas commented on pull request importers/git-importer#4 2022-10-26 15:15:09 +02:00
Build a Tree of commits (at least prep it)

with

aplanas approved importers/git-importer#3 2022-10-26 13:47:54 +02:00
add a user database
aplanas commented on pull request importers/git-importer#3 2022-10-26 13:02:30 +02:00
add a user database

I think that from here you can remove all from the with context (at least I do not see any access to cur)

aplanas suggested changes for importers/git-importer#3 2022-10-26 13:02:30 +02:00
add a user database
aplanas commented on pull request importers/git-importer#3 2022-10-26 11:06:14 +02:00
add a user database

that would be awesome!

If you feel strong, refactor also the schema = dict() part, and build a list : ]

aplanas commented on pull request importers/git-importer#3 2022-10-26 11:05:23 +02:00
add a user database

@staticmethod, those are method associated with a class and not an instance. @classmethod are use for metaprogramming, when you want to change the class definition (weird stuff).

In a…

aplanas commented on pull request importers/git-importer#3 2022-10-26 10:54:09 +02:00
add a user database

@staticmethod

aplanas commented on pull request importers/git-importer#3 2022-10-26 10:52:46 +02:00
add a user database

Use a with context, like in a file: https://www.psycopg.org/docs/cursor.html

aplanas commented on pull request importers/git-importer#3 2022-10-26 10:49:17 +02:00
add a user database

Indeed.

IMHO avoid is None, == []. Use the truth value (if missing_user:)

aplanas commented on pull request importers/git-importer#3 2022-10-26 10:47:45 +02:00
add a user database

is, black will detect this kind of issues too (I think)

aplanas commented on pull request importers/git-importer#3 2022-10-26 10:47:45 +02:00
add a user database

It is OK how you write it, but I would expect root and userid as part of the __init__ constructor (give initial state).

aplanas commented on pull request importers/git-importer#3 2022-10-26 10:47:45 +02:00
add a user database

For 4 elements a tuple is totally OK. If you expect that it will grow, use a set.

aplanas commented on pull request importers/git-importer#3 2022-10-26 10:47:45 +02:00
add a user database

Remove this section?

aplanas suggested changes for importers/git-importer#3 2022-10-26 10:47:45 +02:00
add a user database
aplanas commented on pull request importers/git-importer#3 2022-10-26 10:47:45 +02:00
add a user database

If it is a class method do not expect self as a first parameter, it is usually cls [1]

aplanas commented on pull request mold/core#1 2022-10-25 15:38:37 +02:00
Test PR to submodules

Should be done. Seems there is a bug in the UI, where here I can see both commits, but in the "Commits" tab I can see only one.