fix soname the right way #1

Merged
jengelh merged 1 commits from rrahl0/libdisplaydevice:main into main 2025-05-09 11:23:29 +02:00
Collaborator
No description provided.
rrahl0 added 1 commit 2025-04-11 01:02:31 +02:00
Owner

Is this from an upstream commit, if so, which?

Is this from an upstream commit, if so, which?
Author
Collaborator

it is not, calling the library liblibdisplaydevice is just weird, and having no soversion is cumbersome. still want to work with upstream to see if we can do something about it

it is not, calling the library liblibdisplaydevice is just weird, and having no soversion is cumbersome. still want to work with upstream to see if we can do something about it
jengelh merged commit d16a76e63a into main 2025-05-09 11:23:29 +02:00
Owner

soversion (0.0.0) was already addd thanks to soversion.patch (added previously).
I don't see a "liblib" in the old build, so it seems like you did a cosmetic CMakeLists.txt change.

$ git co a9708cc5c5d7020527f17c454717b6f920c00bdca5f4c3d1e50eb52dccccbdfc; osc build
/run/ob/j0/.mount/.build.packages/RPMS/x86_64/libdisplaydevice-debugsource-2025.115.133852-0.x86_64.rpm
/run/ob/j0/.mount/.build.packages/RPMS/x86_64/libdisplaydevice0_0_0-debuginfo-2025.115.133852-0.x86_64.rpm
/run/ob/j0/.mount/.build.packages/RPMS/x86_64/libdisplaydevice0_0_0-2025.115.133852-0.x86_64.rpm
11:27 a4:../c_c++/libdisplaydevice $ rpm -qlvp /run/ob/j0/.mount/.build.packages/RPMS/x86_64/libdisplaydevice0_0_0-2025.115.133852-0.x86_64.rpm
-rwxr-xr-x    1 root     root                   213152 May  9 11:27 /usr/lib64/libdisplaydevice_common.so.0.0.0
drwxr-xr-x    2 root     root                        0 May  9 11:27 /usr/share/doc/packages/libdisplaydevice0_0_0
-rw-r--r--    1 root     root                     2190 Jan 15 14:38 /usr/share/doc/packages/libdisplaydevice0_0_0/README.md
drwxr-xr-x    2 root     root                        0 May  9 11:27 /usr/share/licenses/libdisplaydevice0_0_0
-rw-r--r--    1 root     root                    34523 Jan 15 14:38 /usr/share/licenses/libdisplaydevice0_0_0/LICENSE
11:27 a4:../c_c++/libdisplaydevice $ rpm -qp --provides /run/ob/j0/.mount/.build.packages/RPMS/x86_64/libdisplaydevice0_0_0-2025.115.133852-0.x86_64.rpm
libdisplaydevice0_0_0 = 2025.115.133852-0
libdisplaydevice0_0_0(x86-64) = 2025.115.133852-0
libdisplaydevice_common.so.0.0.0()(64bit)
soversion (0.0.0) was already addd thanks to soversion.patch (added previously). I don't see a "liblib" in the old build, so it seems like you did a cosmetic CMakeLists.txt change. ``` $ git co a9708cc5c5d7020527f17c454717b6f920c00bdca5f4c3d1e50eb52dccccbdfc; osc build /run/ob/j0/.mount/.build.packages/RPMS/x86_64/libdisplaydevice-debugsource-2025.115.133852-0.x86_64.rpm /run/ob/j0/.mount/.build.packages/RPMS/x86_64/libdisplaydevice0_0_0-debuginfo-2025.115.133852-0.x86_64.rpm /run/ob/j0/.mount/.build.packages/RPMS/x86_64/libdisplaydevice0_0_0-2025.115.133852-0.x86_64.rpm 11:27 a4:../c_c++/libdisplaydevice $ rpm -qlvp /run/ob/j0/.mount/.build.packages/RPMS/x86_64/libdisplaydevice0_0_0-2025.115.133852-0.x86_64.rpm -rwxr-xr-x 1 root root 213152 May 9 11:27 /usr/lib64/libdisplaydevice_common.so.0.0.0 drwxr-xr-x 2 root root 0 May 9 11:27 /usr/share/doc/packages/libdisplaydevice0_0_0 -rw-r--r-- 1 root root 2190 Jan 15 14:38 /usr/share/doc/packages/libdisplaydevice0_0_0/README.md drwxr-xr-x 2 root root 0 May 9 11:27 /usr/share/licenses/libdisplaydevice0_0_0 -rw-r--r-- 1 root root 34523 Jan 15 14:38 /usr/share/licenses/libdisplaydevice0_0_0/LICENSE 11:27 a4:../c_c++/libdisplaydevice $ rpm -qp --provides /run/ob/j0/.mount/.build.packages/RPMS/x86_64/libdisplaydevice0_0_0-2025.115.133852-0.x86_64.rpm libdisplaydevice0_0_0 = 2025.115.133852-0 libdisplaydevice0_0_0(x86-64) = 2025.115.133852-0 libdisplaydevice_common.so.0.0.0()(64bit) ```
Author
Collaborator

I used patchelf, which obviously is not great. but back then I didn't know better.

I used patchelf, which obviously is not great. but back then I didn't know better.
Sign in to join this conversation.
No Reviewers
No Label
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: clibs/libdisplaydevice#1
No description provided.