cockpit/cockpit-machines
SHA256
9
0
Fork 3
forked from pool/cockpit-machines
Code Pull Requests 1 Activity

Explicitly set uefi as default firmware (bsc#1245145) #9

Manually merged
malikirri merged 1 commits from malikirri/cockpit-machines:default-uefi into main 2025-07-10 16:50:08 +02:00
Conversation 3 Commits 1 Files Changed 2 +68 -33
malikirri commented 2025-07-09 10:21:45 +02:00
Member
Copy Link
No description provided.
autogits-devel requested review from abrooks 2025-07-09 10:21:54 +02:00
autogits-devel requested review from adamm 2025-07-09 10:21:54 +02:00
autogits-devel requested review from jzerebecki 2025-07-09 10:21:55 +02:00
abrooks reviewed 2025-07-09 11:03:30 +02:00
uefi-default-firmware.patch Outdated
@@ -31,0 +23,4 @@
userPassword,
vmName,
sshKeys,
+ firmware: "uefi",
abrooks commented 2025-07-09 11:03:19 +02:00
Member
Copy Link

Is there any concern to just always running uefi? Is our stance just drop support for bios completely?

Is there any concern to just always running uefi? Is our stance just drop support for bios completely?
malikirri commented 2025-07-09 11:20:26 +02:00
Author
Member
Copy Link

I don't think the stance is to drop support for bios. But bios is considered a legacy so there was a request to make uefi the default https://bugzilla.suse.com/show_bug.cgi?id=1232691

I don't think the stance is to drop support for bios. But bios is considered a legacy so there was a request to make uefi the default https://bugzilla.suse.com/show_bug.cgi?id=1232691
abrooks commented 2025-07-09 11:24:47 +02:00
Member
Copy Link

My only concern is if an image supports bios but not uefi we don't have any considerations for it

My only concern is if an image supports bios but not uefi we don't have any considerations for it
malikirri commented 2025-07-09 11:31:29 +02:00
Author
Member
Copy Link

You should be able to change from uefi to bios after you've created the VM but haven't installed it yet but it looks to be bugged. I'll look into what's going on with that

You should be able to change from uefi to bios after you've created the VM but haven't installed it yet but it looks to be bugged. I'll look into what's going on with that
👍 1
malikirri commented 2025-07-10 11:59:42 +02:00
Author
Member
Copy Link

Updated the patch to fix the issues with switching from UEFI to BIOS before VM is installed

Updated the patch to fix the issues with switching from UEFI to BIOS before VM is installed
uefi-default-firmware.patch Outdated
@@ -37,2 +28,2 @@
return "unknown";
} else {
logDebug(`CREATE_VM(${vmName}): install_machine.py '${JSON.stringify(args)}'`);
abrooks commented 2025-07-09 11:02:31 +02:00
Member
Copy Link

Do we want to keep the logDebug here?

Do we want to keep the `logDebug` here?
malikirri commented 2025-07-09 11:21:05 +02:00
Author
Member
Copy Link

logDebug is part of the original code base. That is just diff of a diff looking silly

`logDebug` is part of the original code base. That is just diff of a diff looking silly
👍 1
adamm marked this conversation as resolved
malikirri force-pushed default-uefi from 64ccd4fe0e to fbe68bb066 2025-07-10 11:58:41 +02:00 Compare
abrooks approved these changes 2025-07-10 12:43:31 +02:00
abrooks left a comment
Member
Copy Link

I think this looks fine

I think this looks fine
adamm approved these changes 2025-07-10 14:26:43 +02:00
adamm left a comment
Owner
Copy Link

merge ok

merge ok
autogits-devel removed review request for jzerebecki 2025-07-10 16:49:31 +02:00
autogits-devel requested review from jzerebecki 2025-07-10 16:49:59 +02:00
malikirri manually merged commit fbe68bb066 into main 2025-07-10 16:50:08 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
abrooks
adamm
jzerebecki
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
abrooks adamm autogits-devel autogits_obs_staging_bot factory_bot jzerebecki ldragon legaldb malikirri
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cockpit/cockpit-machines#9
No description provided.
Delete Branch "malikirri/cockpit-machines:default-uefi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?