dma: Let st*_dma() propagate MemTxResult (bsc#1193914, CVE-2021-3611)
dma_memory_write() returns a MemTxResult type. Do not discard
it, return it to the caller.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211223115554.3155328-18-philmd@redhat.com>
(cherry picked from commit 24aed6bcb6)
References: bsc#1193914
References: CVE-2021-3611
Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
			
			
This commit is contained in:
		@@ -248,13 +248,13 @@ static inline void dma_memory_unmap(AddressSpace *as,
 | 
			
		||||
        dma_memory_read(as, addr, &val, (_bits) / 8, attrs); \
 | 
			
		||||
        return _end##_bits##_to_cpu(val);                               \
 | 
			
		||||
    }                                                                   \
 | 
			
		||||
    static inline void st##_sname##_##_end##_dma(AddressSpace *as,      \
 | 
			
		||||
                                                 dma_addr_t addr,       \
 | 
			
		||||
                                                 uint##_bits##_t val,   \
 | 
			
		||||
                                                 MemTxAttrs attrs)      \
 | 
			
		||||
    {                                                                   \
 | 
			
		||||
        val = cpu_to_##_end##_bits(val);                                \
 | 
			
		||||
        dma_memory_write(as, addr, &val, (_bits) / 8, attrs);           \
 | 
			
		||||
    static inline MemTxResult st##_sname##_##_end##_dma(AddressSpace *as, \
 | 
			
		||||
                                                        dma_addr_t addr, \
 | 
			
		||||
                                                        uint##_bits##_t val, \
 | 
			
		||||
                                                        MemTxAttrs attrs) \
 | 
			
		||||
    { \
 | 
			
		||||
        val = cpu_to_##_end##_bits(val); \
 | 
			
		||||
        return dma_memory_write(as, addr, &val, (_bits) / 8, attrs); \
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
static inline uint8_t ldub_dma(AddressSpace *as, dma_addr_t addr, MemTxAttrs attrs)
 | 
			
		||||
@@ -265,10 +265,10 @@ static inline uint8_t ldub_dma(AddressSpace *as, dma_addr_t addr, MemTxAttrs att
 | 
			
		||||
    return val;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
static inline void stb_dma(AddressSpace *as, dma_addr_t addr,
 | 
			
		||||
                           uint8_t val, MemTxAttrs attrs)
 | 
			
		||||
static inline MemTxResult stb_dma(AddressSpace *as, dma_addr_t addr,
 | 
			
		||||
                                  uint8_t val, MemTxAttrs attrs)
 | 
			
		||||
{
 | 
			
		||||
    dma_memory_write(as, addr, &val, 1, attrs);
 | 
			
		||||
    return dma_memory_write(as, addr, &val, 1, attrs);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
DEFINE_LDST_DMA(uw, w, 16, le);
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user