dfaggioli/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rules.mak: Force CFLAGS for all objects in DSO #4

Merged
jirislaby merged 1 commits from opensuse-2.3 into opensuse-2.3 2015-05-29 21:34:48 +02:00
Conversation 1 Commits 1 Files Changed 1 +3 -1
jirislaby commented 2015-05-26 17:42:15 +02:00 (Migrated from github.com)
Copy Link

Because of the trick of process-archive-undefs, all .mo objects, even
with --enable-modules, are dependencies of executables.

This breaks CFLAGS propogation because the compiling of module object
will happen too early before building for DSO.

With GCC 5, the linking would fail because .o doesn't have -fPIC. Also,
BUILD_DSO will be missed. (module-common.o will have it, so the stamp
symbol was still liked in .so).

Fix the problem by forcing the CFLAGS on individual .o-cflags during
unnest-vars.

Reported-by: Alexander Graf agraf@suse.de
Signed-off-by: Fam Zheng famz@redhat.com
Cc: qemu-stable@nongnu.org # 2.3
Message-Id: 1430981715-31465-1-git-send-email-famz@redhat.com
Signed-off-by: Paolo Bonzini pbonzini@redhat.com

Because of the trick of process-archive-undefs, all .mo objects, even with --enable-modules, are dependencies of executables. This breaks CFLAGS propogation because the compiling of module object will happen too early before building for DSO. With GCC 5, the linking would fail because .o doesn't have -fPIC. Also, BUILD_DSO will be missed. (module-common.o will have it, so the stamp symbol was still liked in .so). Fix the problem by forcing the CFLAGS on individual .o-cflags during unnest-vars. Reported-by: Alexander Graf agraf@suse.de Signed-off-by: Fam Zheng famz@redhat.com Cc: qemu-stable@nongnu.org # 2.3 Message-Id: 1430981715-31465-1-git-send-email-famz@redhat.com Signed-off-by: Paolo Bonzini pbonzini@redhat.com
afaerber commented 2015-05-30 00:50:43 +02:00 (Migrated from github.com)
Copy Link

As mentioned to Alex, this should've been replaced with a proper cherry-pick with Signed-off-by. We don't want merge commits in our rebasing patch queue. af

Bruce notifications@github.com schrieb:

Merged #4.

—
Reply to this email directly or view it on GitHub.

As mentioned to Alex, this should've been replaced with a proper cherry-pick with Signed-off-by. We don't want merge commits in our rebasing patch queue. af Bruce notifications@github.com schrieb: > Merged #4. > > — > Reply to this email directly or view it on GitHub.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dfaggioli
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dfaggioli/qemu#4
Delete Branch "opensuse-2.3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?