workflow-pr: Allow to ignore reviewers in manual mode

Eg. don't insist on maintainers who got removed on purpose from the pull request.
Merge branch 'main' into refactoring-make
2026-03-10 13:33:02 +01:00 · 2026-03-10 12:30:20 +01:00 · 2026-03-06 11:33:32 +01:00
2 changed files with 12 additions and 4 deletions
--- a/8
+++ b/8
@@ -1,4 +1,8 @@
 MODULES := devel-importer utils/hujson utils/maintainer-update gitea-events-rabbitmq-publisher gitea_status_proxy group-review obs-forward-bot obs-staging-bot obs-status-service workflow-direct workflow-pr

-build:
-	for m in $(MODULES); do go build -C $$m -buildmode=pie || exit 1 ; done
+.PHONY: build $(MODULES)
+
+build: $(MODULES)
+
+$(MODULES):
+	go build -C $@ -buildmode=pie
--- a/common/pr.go
+++ b/common/pr.go
@@ -352,7 +352,7 @@ func (rs *PRSet) FindMissingAndExtraReviewers(maintainers MaintainershipData, id
 			noReviewPkgPRCreators = pkgMaintainers
 		}

-		LogDebug("packakge maintainers:", Maintainers)
+		LogDebug("package maintainers:", Maintainers)

 		missing = slices.Concat(configReviewers.Pkg, configReviewers.PkgOptional)
 		if slices.Contains(noReviewPkgPRCreators, pr.PR.User.UserName) || pr.Reviews.IsReviewedByOneOf(Maintainers...) {
@@ -502,10 +502,14 @@ func (rs *PRSet) IsApproved(gitea GiteaPRChecker, maintainers MaintainershipData

 		if !is_manually_reviewed_ok {
 			LogInfo("manual merge not ok")
-			return false
 		}
+
+		// we only check existing reviewers here. buildops tean want to be able
+		// to remove reviewiers to ignore them.
+		return is_manually_reviewed_ok
 	}

+	// No manual review
 	for _, pr := range rs.PRs {
 		var reviewers []string
 		var pkg string
Author	SHA256	Message	Date
Adrian Schröter	2f84093878	workflow-pr: Allow to ignore reviewers in manual mode All checks were successful go-generate-check / go-generate-check (pull_request) Successful in 12s Details Integration tests / t (pull_request) Successful in 11m4s Details Eg. don't insist on maintainers who got removed on purpose from the pull request.	2026-03-10 13:33:02 +01:00
Antonello Tartamo	b04755c667	Merge branch 'main' into refactoring-make Some checks failed Integration tests / t (pull_request) Failing after 11m36s Details Integration tests / t (push) Failing after 11m46s Details	2026-03-10 12:30:20 +01:00
ncounter	1fc0be5f60	make: refactor build target into per-module dependencies Some checks failed Integration tests / t (pull_request) Has been cancelled Details - Replace shell loop in build with explicit module targets - Add .PHONY for build and module targets - Keep go build -C <module> -buildmode=pie behavior unchanged - Enable parallel builds via make -jN build	2026-03-06 11:33:32 +01:00