Compare commits
1 Commits
main
...
maintainer
| Author | SHA256 | Date | |
|---|---|---|---|
| 2f84093878 |
@@ -352,7 +352,7 @@ func (rs *PRSet) FindMissingAndExtraReviewers(maintainers MaintainershipData, id
|
||||
noReviewPkgPRCreators = pkgMaintainers
|
||||
}
|
||||
|
||||
LogDebug("packakge maintainers:", Maintainers)
|
||||
LogDebug("package maintainers:", Maintainers)
|
||||
|
||||
missing = slices.Concat(configReviewers.Pkg, configReviewers.PkgOptional)
|
||||
if slices.Contains(noReviewPkgPRCreators, pr.PR.User.UserName) || pr.Reviews.IsReviewedByOneOf(Maintainers...) {
|
||||
@@ -502,10 +502,14 @@ func (rs *PRSet) IsApproved(gitea GiteaPRChecker, maintainers MaintainershipData
|
||||
|
||||
if !is_manually_reviewed_ok {
|
||||
LogInfo("manual merge not ok")
|
||||
return false
|
||||
}
|
||||
|
||||
// we only check existing reviewers here. buildops tean want to be able
|
||||
// to remove reviewiers to ignore them.
|
||||
return is_manually_reviewed_ok
|
||||
}
|
||||
|
||||
// No manual review
|
||||
for _, pr := range rs.PRs {
|
||||
var reviewers []string
|
||||
var pkg string
|
||||
|
||||
Reference in New Issue
Block a user