Compare commits

..

1 Commits

Author SHA256 Message Date
2f84093878 workflow-pr: Allow to ignore reviewers in manual mode
All checks were successful
go-generate-check / go-generate-check (pull_request) Successful in 12s
Integration tests / t (pull_request) Successful in 11m4s
Eg. don't insist on maintainers who got removed on purpose from the pull
request.
2026-03-10 13:33:02 +01:00

View File

@@ -352,7 +352,7 @@ func (rs *PRSet) FindMissingAndExtraReviewers(maintainers MaintainershipData, id
noReviewPkgPRCreators = pkgMaintainers
}
LogDebug("packakge maintainers:", Maintainers)
LogDebug("package maintainers:", Maintainers)
missing = slices.Concat(configReviewers.Pkg, configReviewers.PkgOptional)
if slices.Contains(noReviewPkgPRCreators, pr.PR.User.UserName) || pr.Reviews.IsReviewedByOneOf(Maintainers...) {
@@ -502,10 +502,14 @@ func (rs *PRSet) IsApproved(gitea GiteaPRChecker, maintainers MaintainershipData
if !is_manually_reviewed_ok {
LogInfo("manual merge not ok")
return false
}
// we only check existing reviewers here. buildops tean want to be able
// to remove reviewiers to ignore them.
return is_manually_reviewed_ok
}
// No manual review
for _, pr := range rs.PRs {
var reviewers []string
var pkg string