pr: fix tests

If new target repo is "reparented", it will have correct relationship
here. Otherwise PR creation will fail

common/associated_pr_scanner_test.go

@@ -14,7 +14,6 @@ func newStringScanner(s string) *bufio.Scanner {
 }
 
 func TestAssociatedPRScanner(t *testing.T) {
-	common.SetTestLogger(t)
 	testTable := []struct {
 		name  string
 		input string
@@ -96,7 +95,6 @@ func TestAssociatedPRScanner(t *testing.T) {
 }
 
 func TestAppendingPRsToDescription(t *testing.T) {
-	common.SetTestLogger(t)
 	testTable := []struct {
 		name   string
 		desc   string

common/config.go

@@ -54,7 +54,6 @@ type ReviewGroup struct {
 type QAConfig struct {
 	Name   string
 	Origin string
-	BuildDisableRepos []string // which repos to build disable in the new project
 }
 
 type Permissions struct {
@@ -93,7 +92,6 @@ type AutogitConfig struct {
 	NoProjectGitPR     bool // do not automatically create project git PRs, just assign reviewers and assume somethign else creates the ProjectGit PR
 	ManualMergeOnly    bool // only merge with "Merge OK" comment by Project Maintainers and/or Package Maintainers and/or reviewers
 	ManualMergeProject bool // require merge of ProjectGit PRs with "Merge OK" by ProjectMaintainers and/or reviewers
-	ReviewRequired     bool // always require a maintainer review, even if maintainer submits it. Only ignored if no other package or project reviewers
 }
 
 type AutogitConfigs []*AutogitConfig
@@ -295,9 +293,9 @@ func (config *AutogitConfig) GetRemoteBranch() string {
 }
 
 func (config *AutogitConfig) Label(label string) string {
-	if t, found := config.Labels[LabelKey(label)]; found {
-		return t
-	}
+		if t, found := config.Labels[LabelKey(label)]; found {
+			return t
+		}
 
 	return label
 }

common/config_test.go

@@ -4,6 +4,7 @@ import (
 	"slices"
 	"testing"
 
+	"go.uber.org/mock/gomock"
 	"src.opensuse.org/autogits/common"
 	"src.opensuse.org/autogits/common/gitea-generated/models"
 	mock_common "src.opensuse.org/autogits/common/mock"
@@ -53,7 +54,7 @@ func TestConfigLabelParser(t *testing.T) {
 				DefaultBranch: "master",
 			}
 
-			ctl := NewController(t)
+			ctl := gomock.NewController(t)
 			gitea := mock_common.NewMockGiteaFileContentAndRepoFetcher(ctl)
 			gitea.EXPECT().GetRepositoryFileContent("foo", "bar", "", "workflow.config").Return([]byte(test.json), "abc", nil)
 			gitea.EXPECT().GetRepository("foo", "bar").Return(&repo, nil)
@@ -175,7 +176,7 @@ func TestConfigWorkflowParser(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			ctl := NewController(t)
+			ctl := gomock.NewController(t)
 			gitea := mock_common.NewMockGiteaFileContentAndRepoFetcher(ctl)
 			gitea.EXPECT().GetRepositoryFileContent("foo", "bar", "", "workflow.config").Return([]byte(test.config_json), "abc", nil)
 			gitea.EXPECT().GetRepository("foo", "bar").Return(&test.repo, nil)

common/git_utils_test.go

@@ -24,14 +24,12 @@ import (
 	"os"
 	"os/exec"
 	"path"
-	"path/filepath"
 	"slices"
 	"strings"
 	"testing"
 )
 
 func TestGitClone(t *testing.T) {
-	SetTestLogger(t)
 	tests := []struct {
 		name string
 
@@ -95,59 +93,7 @@ func TestGitClone(t *testing.T) {
 	}
 }
 
-func TestGitCloneCommitID(t *testing.T) {
-	SetTestLogger(t)
-	execPath, err := os.Getwd()
-	if err != nil {
-		t.Fatal(err)
-	}
-	d := t.TempDir()
-	if err := os.Chdir(d); err != nil {
-		t.Fatal(err)
-	}
-	defer os.Chdir(execPath)
-	cmd := exec.Command(path.Join(execPath, "test_repo_setup.sh"))
-	if out, err := cmd.CombinedOutput(); err != nil {
-		t.Log(string(out))
-		t.Fatal(err)
-	}
-
-	gh, err := AllocateGitWorkTree(d, "Test", "test@example.com")
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	g, err := gh.CreateGitHandler("org")
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	// Get a commit ID from pkgA
-	remoteUrl := "file://" + d + "/pkgA"
-	out, err := exec.Command("git", "-C", path.Join(d, "pkgA"), "rev-parse", "main").Output()
-	if err != nil {
-		t.Fatal(err)
-	}
-	commitID := strings.TrimSpace(string(out))
-
-	repo := "pkgAcloneCommitID"
-	if _, err := g.GitClone(repo, commitID, remoteUrl); err != nil {
-		t.Skip("TODO: Add GitClone CommitID support")
-		t.Fatalf("GitClone failed with commit ID: %v", err)
-	}
-
-	// Verify we are at the right commit
-	head, err := g.GitBranchHead(repo, commitID)
-	if err != nil {
-		t.Fatalf("GitBranchHead failed: %v", err)
-	}
-	if head != commitID {
-		t.Errorf("Expected head %s, got %s", commitID, head)
-	}
-}
-
 func TestGitMsgParsing(t *testing.T) {
-	SetTestLogger(t)
 	t.Run("tree message with size 56", func(t *testing.T) {
 		const hdr = "f40888ea4515fe2e8eea617a16f5f50a45f652d894de3ad181d58de3aafb8f98 tree 56\x00"
 
@@ -226,7 +172,6 @@ func TestGitMsgParsing(t *testing.T) {
 }
 
 func TestGitCommitParsing(t *testing.T) {
-	SetTestLogger(t)
 	t.Run("parse valid commit message", func(t *testing.T) {
 		const commitData = "f40888ea4515fe2e8eea617a16f5f50a45f652d894de3ad181d58de3aafb8f99 commit 253\000" +
 			`tree e20033df9f18780756ba4a96dbc7eb1a626253961039cb674156f266ba7a4e53
@@ -437,7 +382,6 @@ dummy change, don't merge
 }
 
 func TestCommitTreeParsing(t *testing.T) {
-	SetTestLogger(t)
 	gitDir := t.TempDir()
 	testDir, _ := os.Getwd()
 	var commitId string
@@ -546,7 +490,6 @@ func TestCommitTreeParsing(t *testing.T) {
 }
 
 func TestGitStatusParse(t *testing.T) {
-	SetTestLogger(t)
 	testData := []struct {
 		name string
 		data []byte
@@ -653,67 +596,3 @@ func TestGitStatusParse(t *testing.T) {
 		})
 	}
 }
-
-func TestGitDirectoryListRepro(t *testing.T) {
-	SetTestLogger(t)
-	d := t.TempDir()
-
-	// Setup a mock environment for GitHandlerImpl
-	gh, err := AllocateGitWorkTree(d, "Test", "test@example.com")
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	org := "repo-org"
-	repoName := "test-repo"
-	repoPath := filepath.Join(d, org, repoName)
-	err = os.MkdirAll(repoPath, 0755)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	runGit := func(args ...string) {
-		cmd := exec.Command("git", args...)
-		cmd.Dir = repoPath
-		if out, err := cmd.CombinedOutput(); err != nil {
-			t.Fatalf("git %v failed: %v\n%s", args, err, out)
-		}
-	}
-
-	runGit("init", "-b", "main", "--object-format=sha256")
-	runGit("config", "user.email", "test@example.com")
-	runGit("config", "user.name", "test")
-
-	// Create a directory and a file
-	err = os.Mkdir(filepath.Join(repoPath, "subdir"), 0755)
-	if err != nil {
-		t.Fatal(err)
-	}
-	err = os.WriteFile(filepath.Join(repoPath, "subdir", "file.txt"), []byte("hello"), 0644)
-	if err != nil {
-		t.Fatal(err)
-	}
-	runGit("add", "subdir/file.txt")
-	runGit("commit", "-m", "add subdir")
-
-	// Now create the handler
-	g, err := gh.CreateGitHandler(org)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	// Call GitDirectoryList
-	dirs, err := g.GitDirectoryList(repoName, "HEAD")
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	t.Logf("Directories found: %v", dirs)
-
-	if len(dirs) == 0 {
-		t.Error("No directories found, but 'subdir' should be there")
-	}
-	if _, ok := dirs["subdir"]; !ok {
-		t.Errorf("Expected 'subdir' in directory list, got %v", dirs)
-	}
-}

common/gitea_utils.go

@@ -80,7 +80,6 @@ type GiteaIssueFetcher interface {
 }
 
 type GiteaTimelineFetcher interface {
-	ResetTimelineCache(org, repo string, idx int64)
 	GetTimeline(org, repo string, idx int64) ([]*models.TimelineComment, error)
 }
 
@@ -841,17 +840,6 @@ type TimelineCacheData struct {
 var giteaTimelineCache map[string]TimelineCacheData = make(map[string]TimelineCacheData)
 var giteaTimelineCacheMutex sync.RWMutex
 
-func (gitea *GiteaTransport) ResetTimelineCache(org, repo string, idx int64) {
-	giteaTimelineCacheMutex.Lock()
-	defer giteaTimelineCacheMutex.Unlock()
-
-	prID := fmt.Sprintf("%s/%s!%d", org, repo, idx)
-	Cache, IsCached := giteaTimelineCache[prID]
-	if IsCached {
-		Cache.lastCheck = Cache.lastCheck.Add(-time.Hour)
-	}
-}
-
 // returns timeline in reverse chronological create order
 func (gitea *GiteaTransport) GetTimeline(org, repo string, idx int64) ([]*models.TimelineComment, error) {
 	page := int64(1)

common/log.go

@@ -67,16 +67,6 @@ func GetLoggingLevel() LogLevel {
 	return logLevel
 }
 
-type Logger interface {
-	Log(args ...any)
-}
-
-var testLogger Logger
-
-func SetTestLogger(l Logger) {
-	testLogger = l
-}
-
 func SetLoggingLevelFromString(ll string) error {
 	switch ll {
 	case "info":
@@ -96,26 +86,18 @@ func SetLoggingLevelFromString(ll string) error {
 
 func LogError(params ...any) {
 	if logLevel >= LogLevelError {
-		logit("[E]", params...)
+		log.Println(append([]any{"[E]"}, params...)...)
 	}
 }
 
 func LogDebug(params ...any) {
 	if logLevel >= LogLevelDebug {
-		logit("[D]", params...)
+		log.Println(append([]any{"[D]"}, params...)...)
 	}
 }
 
 func LogInfo(params ...any) {
 	if logLevel >= LogLevelInfo {
-		logit("[I]", params...)
-	}
-}
-
-func logit(prefix string, params ...any) {
-	if testLogger != nil {
-		testLogger.Log(append([]any{prefix}, params...)...)
-	} else {
-		log.Println(append([]any{prefix}, params...)...)
+		log.Println(append([]any{"[I]"}, params...)...)
 	}
 }

common/maintainership.go

@@ -25,7 +25,6 @@ const ProjectFileKey = "_project"
 type MaintainershipMap struct {
 	Data         map[string][]string
 	IsDir        bool
-	Config       *AutogitConfig
 	FetchPackage func(string) ([]byte, error)
 }
 
@@ -40,9 +39,7 @@ func parseMaintainershipData(data []byte) (*MaintainershipMap, error) {
 	return maintainers, nil
 }
 
-func FetchProjectMaintainershipData(gitea GiteaMaintainershipReader, config *AutogitConfig) (*MaintainershipMap, error) {
-	org, prjGit, branch := config.GetPrjGit()
-
+func FetchProjectMaintainershipData(gitea GiteaMaintainershipReader, org, prjGit, branch string) (*MaintainershipMap, error) {
 	data, _, err := gitea.FetchMaintainershipDirFile(org, prjGit, branch, ProjectFileKey)
 	dir := true
 	if err != nil || data == nil {
@@ -64,7 +61,6 @@ func FetchProjectMaintainershipData(gitea GiteaMaintainershipReader, config *Aut
 
 	m, err := parseMaintainershipData(data)
 	if m != nil {
-		m.Config = config
 		m.IsDir = dir
 		m.FetchPackage = func(pkg string) ([]byte, error) {
 			data, _, err := gitea.FetchMaintainershipDirFile(org, prjGit, branch, pkg)
@@ -153,10 +149,7 @@ func (data *MaintainershipMap) IsApproved(pkg string, reviews []*models.PullRevi
 	}
 
 	LogDebug("Looking for review by:", reviewers)
-	slices.Sort(reviewers)
-	reviewers = slices.Compact(reviewers)
-	SubmitterIdxInReviewers := slices.Index(reviewers, submitter)
-	if SubmitterIdxInReviewers > -1 && (!data.Config.ReviewRequired || len(reviewers) == 1) {
+	if slices.Contains(reviewers, submitter) {
 		LogDebug("Submitter is maintainer. Approving.")
 		return true
 	}

common/maintainership_test.go

@@ -13,10 +13,10 @@ import (
 )
 
 func TestMaintainership(t *testing.T) {
-	config := &common.AutogitConfig{
+	config := common.AutogitConfig{
 		Branch:         "bar",
 		Organization:   "foo",
-		GitProjectName: common.DefaultGitPrj + "#bar",
+		GitProjectName: common.DefaultGitPrj,
 	}
 
 	packageTests := []struct {
@@ -141,7 +141,7 @@ func TestMaintainership(t *testing.T) {
 	notFoundError := repository.NewRepoGetContentsNotFound()
 	for _, test := range packageTests {
 		runTests := func(t *testing.T, mi common.GiteaMaintainershipReader) {
-			maintainers, err := common.FetchProjectMaintainershipData(mi, config)
+			maintainers, err := common.FetchProjectMaintainershipData(mi, config.Organization, config.GitProjectName, config.Branch)
 			if err != nil && !test.otherError {
 				if test.maintainersFileErr == nil {
 					t.Fatal("Unexpected error recieved", err)
@@ -172,7 +172,7 @@ func TestMaintainership(t *testing.T) {
 		}
 
 		t.Run(test.name+"_File", func(t *testing.T) {
-			ctl := NewController(t)
+			ctl := gomock.NewController(t)
 			mi := mock_common.NewMockGiteaMaintainershipReader(ctl)
 
 			// tests with maintainership file
@@ -185,7 +185,7 @@ func TestMaintainership(t *testing.T) {
 		})
 
 		t.Run(test.name+"_Dir", func(t *testing.T) {
-			ctl := NewController(t)
+			ctl := gomock.NewController(t)
 			mi := mock_common.NewMockGiteaMaintainershipReader(ctl)
 
 			// run same tests with directory maintainership data
@@ -253,43 +253,3 @@ func TestMaintainershipFileWrite(t *testing.T) {
 		})
 	}
 }
-
-func TestReviewRequired(t *testing.T) {
-	tests := []struct {
-		name        string
-		maintainers []string
-		config      *common.AutogitConfig
-		is_approved bool
-	}{
-		{
-			name:        "ReviewRequired=false",
-			maintainers: []string{"maintainer1", "maintainer2"},
-			config:      &common.AutogitConfig{ReviewRequired: false},
-			is_approved: true,
-		},
-		{
-			name:        "ReviewRequired=true",
-			maintainers: []string{"maintainer1", "maintainer2"},
-			config:      &common.AutogitConfig{ReviewRequired: true},
-			is_approved: false,
-		},
-		{
-			name:        "ReviewRequired=true",
-			maintainers: []string{"maintainer1"},
-			config:      &common.AutogitConfig{ReviewRequired: true},
-			is_approved: true,
-		},
-	}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			m := &common.MaintainershipMap{
-				Data: map[string][]string{"": test.maintainers},
-			}
-			m.Config = test.config
-			if approved := m.IsApproved("", nil, "maintainer1", nil); approved != test.is_approved {
-				t.Error("Expected m.IsApproved()->", test.is_approved, "but didn't get it")
-			}
-		})
-	}
-}

common/manifest_test.go

@@ -7,7 +7,6 @@ import (
 )
 
 func TestManifestSubdirAssignments(t *testing.T) {
-	common.SetTestLogger(t)
 	tests := []struct {
 		Name              string
 		ManifestContent   string

common/mock/gitea_utils.go

@@ -270,42 +270,6 @@ func (c *MockGiteaTimelineFetcherGetTimelineCall) DoAndReturn(f func(string, str
 	return c
 }
 
-// ResetTimelineCache mocks base method.
-func (m *MockGiteaTimelineFetcher) ResetTimelineCache(org, repo string, idx int64) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "ResetTimelineCache", org, repo, idx)
-}
-
-// ResetTimelineCache indicates an expected call of ResetTimelineCache.
-func (mr *MockGiteaTimelineFetcherMockRecorder) ResetTimelineCache(org, repo, idx any) *MockGiteaTimelineFetcherResetTimelineCacheCall {
-	mr.mock.ctrl.T.Helper()
-	call := mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "ResetTimelineCache", reflect.TypeOf((*MockGiteaTimelineFetcher)(nil).ResetTimelineCache), org, repo, idx)
-	return &MockGiteaTimelineFetcherResetTimelineCacheCall{Call: call}
-}
-
-// MockGiteaTimelineFetcherResetTimelineCacheCall wrap *gomock.Call
-type MockGiteaTimelineFetcherResetTimelineCacheCall struct {
-	*gomock.Call
-}
-
-// Return rewrite *gomock.Call.Return
-func (c *MockGiteaTimelineFetcherResetTimelineCacheCall) Return() *MockGiteaTimelineFetcherResetTimelineCacheCall {
-	c.Call = c.Call.Return()
-	return c
-}
-
-// Do rewrite *gomock.Call.Do
-func (c *MockGiteaTimelineFetcherResetTimelineCacheCall) Do(f func(string, string, int64)) *MockGiteaTimelineFetcherResetTimelineCacheCall {
-	c.Call = c.Call.Do(f)
-	return c
-}
-
-// DoAndReturn rewrite *gomock.Call.DoAndReturn
-func (c *MockGiteaTimelineFetcherResetTimelineCacheCall) DoAndReturn(f func(string, string, int64)) *MockGiteaTimelineFetcherResetTimelineCacheCall {
-	c.Call = c.Call.DoAndReturn(f)
-	return c
-}
-
 // MockGiteaComment is a mock of GiteaComment interface.
 type MockGiteaComment struct {
 	ctrl     *gomock.Controller
@@ -802,42 +766,6 @@ func (c *MockGiteaPRTimelineReviewFetcherGetTimelineCall) DoAndReturn(f func(str
 	return c
 }
 
-// ResetTimelineCache mocks base method.
-func (m *MockGiteaPRTimelineReviewFetcher) ResetTimelineCache(org, repo string, idx int64) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "ResetTimelineCache", org, repo, idx)
-}
-
-// ResetTimelineCache indicates an expected call of ResetTimelineCache.
-func (mr *MockGiteaPRTimelineReviewFetcherMockRecorder) ResetTimelineCache(org, repo, idx any) *MockGiteaPRTimelineReviewFetcherResetTimelineCacheCall {
-	mr.mock.ctrl.T.Helper()
-	call := mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "ResetTimelineCache", reflect.TypeOf((*MockGiteaPRTimelineReviewFetcher)(nil).ResetTimelineCache), org, repo, idx)
-	return &MockGiteaPRTimelineReviewFetcherResetTimelineCacheCall{Call: call}
-}
-
-// MockGiteaPRTimelineReviewFetcherResetTimelineCacheCall wrap *gomock.Call
-type MockGiteaPRTimelineReviewFetcherResetTimelineCacheCall struct {
-	*gomock.Call
-}
-
-// Return rewrite *gomock.Call.Return
-func (c *MockGiteaPRTimelineReviewFetcherResetTimelineCacheCall) Return() *MockGiteaPRTimelineReviewFetcherResetTimelineCacheCall {
-	c.Call = c.Call.Return()
-	return c
-}
-
-// Do rewrite *gomock.Call.Do
-func (c *MockGiteaPRTimelineReviewFetcherResetTimelineCacheCall) Do(f func(string, string, int64)) *MockGiteaPRTimelineReviewFetcherResetTimelineCacheCall {
-	c.Call = c.Call.Do(f)
-	return c
-}
-
-// DoAndReturn rewrite *gomock.Call.DoAndReturn
-func (c *MockGiteaPRTimelineReviewFetcherResetTimelineCacheCall) DoAndReturn(f func(string, string, int64)) *MockGiteaPRTimelineReviewFetcherResetTimelineCacheCall {
-	c.Call = c.Call.DoAndReturn(f)
-	return c
-}
-
 // MockGiteaCommitFetcher is a mock of GiteaCommitFetcher interface.
 type MockGiteaCommitFetcher struct {
 	ctrl     *gomock.Controller
@@ -1129,42 +1057,6 @@ func (c *MockGiteaReviewTimelineFetcherGetTimelineCall) DoAndReturn(f func(strin
 	return c
 }
 
-// ResetTimelineCache mocks base method.
-func (m *MockGiteaReviewTimelineFetcher) ResetTimelineCache(org, repo string, idx int64) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "ResetTimelineCache", org, repo, idx)
-}
-
-// ResetTimelineCache indicates an expected call of ResetTimelineCache.
-func (mr *MockGiteaReviewTimelineFetcherMockRecorder) ResetTimelineCache(org, repo, idx any) *MockGiteaReviewTimelineFetcherResetTimelineCacheCall {
-	mr.mock.ctrl.T.Helper()
-	call := mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "ResetTimelineCache", reflect.TypeOf((*MockGiteaReviewTimelineFetcher)(nil).ResetTimelineCache), org, repo, idx)
-	return &MockGiteaReviewTimelineFetcherResetTimelineCacheCall{Call: call}
-}
-
-// MockGiteaReviewTimelineFetcherResetTimelineCacheCall wrap *gomock.Call
-type MockGiteaReviewTimelineFetcherResetTimelineCacheCall struct {
-	*gomock.Call
-}
-
-// Return rewrite *gomock.Call.Return
-func (c *MockGiteaReviewTimelineFetcherResetTimelineCacheCall) Return() *MockGiteaReviewTimelineFetcherResetTimelineCacheCall {
-	c.Call = c.Call.Return()
-	return c
-}
-
-// Do rewrite *gomock.Call.Do
-func (c *MockGiteaReviewTimelineFetcherResetTimelineCacheCall) Do(f func(string, string, int64)) *MockGiteaReviewTimelineFetcherResetTimelineCacheCall {
-	c.Call = c.Call.Do(f)
-	return c
-}
-
-// DoAndReturn rewrite *gomock.Call.DoAndReturn
-func (c *MockGiteaReviewTimelineFetcherResetTimelineCacheCall) DoAndReturn(f func(string, string, int64)) *MockGiteaReviewTimelineFetcherResetTimelineCacheCall {
-	c.Call = c.Call.DoAndReturn(f)
-	return c
-}
-
 // MockGiteaPRChecker is a mock of GiteaPRChecker interface.
 type MockGiteaPRChecker struct {
 	ctrl     *gomock.Controller
@@ -1386,42 +1278,6 @@ func (c *MockGiteaPRCheckerGetTimelineCall) DoAndReturn(f func(string, string, i
 	return c
 }
 
-// ResetTimelineCache mocks base method.
-func (m *MockGiteaPRChecker) ResetTimelineCache(org, repo string, idx int64) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "ResetTimelineCache", org, repo, idx)
-}
-
-// ResetTimelineCache indicates an expected call of ResetTimelineCache.
-func (mr *MockGiteaPRCheckerMockRecorder) ResetTimelineCache(org, repo, idx any) *MockGiteaPRCheckerResetTimelineCacheCall {
-	mr.mock.ctrl.T.Helper()
-	call := mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "ResetTimelineCache", reflect.TypeOf((*MockGiteaPRChecker)(nil).ResetTimelineCache), org, repo, idx)
-	return &MockGiteaPRCheckerResetTimelineCacheCall{Call: call}
-}
-
-// MockGiteaPRCheckerResetTimelineCacheCall wrap *gomock.Call
-type MockGiteaPRCheckerResetTimelineCacheCall struct {
-	*gomock.Call
-}
-
-// Return rewrite *gomock.Call.Return
-func (c *MockGiteaPRCheckerResetTimelineCacheCall) Return() *MockGiteaPRCheckerResetTimelineCacheCall {
-	c.Call = c.Call.Return()
-	return c
-}
-
-// Do rewrite *gomock.Call.Do
-func (c *MockGiteaPRCheckerResetTimelineCacheCall) Do(f func(string, string, int64)) *MockGiteaPRCheckerResetTimelineCacheCall {
-	c.Call = c.Call.Do(f)
-	return c
-}
-
-// DoAndReturn rewrite *gomock.Call.DoAndReturn
-func (c *MockGiteaPRCheckerResetTimelineCacheCall) DoAndReturn(f func(string, string, int64)) *MockGiteaPRCheckerResetTimelineCacheCall {
-	c.Call = c.Call.DoAndReturn(f)
-	return c
-}
-
 // MockGiteaReviewFetcherAndRequesterAndUnrequester is a mock of GiteaReviewFetcherAndRequesterAndUnrequester interface.
 type MockGiteaReviewFetcherAndRequesterAndUnrequester struct {
 	ctrl     *gomock.Controller
@@ -1607,42 +1463,6 @@ func (c *MockGiteaReviewFetcherAndRequesterAndUnrequesterRequestReviewsCall) DoA
 	return c
 }
 
-// ResetTimelineCache mocks base method.
-func (m *MockGiteaReviewFetcherAndRequesterAndUnrequester) ResetTimelineCache(org, repo string, idx int64) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "ResetTimelineCache", org, repo, idx)
-}
-
-// ResetTimelineCache indicates an expected call of ResetTimelineCache.
-func (mr *MockGiteaReviewFetcherAndRequesterAndUnrequesterMockRecorder) ResetTimelineCache(org, repo, idx any) *MockGiteaReviewFetcherAndRequesterAndUnrequesterResetTimelineCacheCall {
-	mr.mock.ctrl.T.Helper()
-	call := mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "ResetTimelineCache", reflect.TypeOf((*MockGiteaReviewFetcherAndRequesterAndUnrequester)(nil).ResetTimelineCache), org, repo, idx)
-	return &MockGiteaReviewFetcherAndRequesterAndUnrequesterResetTimelineCacheCall{Call: call}
-}
-
-// MockGiteaReviewFetcherAndRequesterAndUnrequesterResetTimelineCacheCall wrap *gomock.Call
-type MockGiteaReviewFetcherAndRequesterAndUnrequesterResetTimelineCacheCall struct {
-	*gomock.Call
-}
-
-// Return rewrite *gomock.Call.Return
-func (c *MockGiteaReviewFetcherAndRequesterAndUnrequesterResetTimelineCacheCall) Return() *MockGiteaReviewFetcherAndRequesterAndUnrequesterResetTimelineCacheCall {
-	c.Call = c.Call.Return()
-	return c
-}
-
-// Do rewrite *gomock.Call.Do
-func (c *MockGiteaReviewFetcherAndRequesterAndUnrequesterResetTimelineCacheCall) Do(f func(string, string, int64)) *MockGiteaReviewFetcherAndRequesterAndUnrequesterResetTimelineCacheCall {
-	c.Call = c.Call.Do(f)
-	return c
-}
-
-// DoAndReturn rewrite *gomock.Call.DoAndReturn
-func (c *MockGiteaReviewFetcherAndRequesterAndUnrequesterResetTimelineCacheCall) DoAndReturn(f func(string, string, int64)) *MockGiteaReviewFetcherAndRequesterAndUnrequesterResetTimelineCacheCall {
-	c.Call = c.Call.DoAndReturn(f)
-	return c
-}
-
 // UnrequestReview mocks base method.
 func (m *MockGiteaReviewFetcherAndRequesterAndUnrequester) UnrequestReview(org, repo string, id int64, reviwers ...string) error {
 	m.ctrl.T.Helper()
@@ -1788,42 +1608,6 @@ func (c *MockGiteaUnreviewTimelineFetcherGetTimelineCall) DoAndReturn(f func(str
 	return c
 }
 
-// ResetTimelineCache mocks base method.
-func (m *MockGiteaUnreviewTimelineFetcher) ResetTimelineCache(org, repo string, idx int64) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "ResetTimelineCache", org, repo, idx)
-}
-
-// ResetTimelineCache indicates an expected call of ResetTimelineCache.
-func (mr *MockGiteaUnreviewTimelineFetcherMockRecorder) ResetTimelineCache(org, repo, idx any) *MockGiteaUnreviewTimelineFetcherResetTimelineCacheCall {
-	mr.mock.ctrl.T.Helper()
-	call := mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "ResetTimelineCache", reflect.TypeOf((*MockGiteaUnreviewTimelineFetcher)(nil).ResetTimelineCache), org, repo, idx)
-	return &MockGiteaUnreviewTimelineFetcherResetTimelineCacheCall{Call: call}
-}
-
-// MockGiteaUnreviewTimelineFetcherResetTimelineCacheCall wrap *gomock.Call
-type MockGiteaUnreviewTimelineFetcherResetTimelineCacheCall struct {
-	*gomock.Call
-}
-
-// Return rewrite *gomock.Call.Return
-func (c *MockGiteaUnreviewTimelineFetcherResetTimelineCacheCall) Return() *MockGiteaUnreviewTimelineFetcherResetTimelineCacheCall {
-	c.Call = c.Call.Return()
-	return c
-}
-
-// Do rewrite *gomock.Call.Do
-func (c *MockGiteaUnreviewTimelineFetcherResetTimelineCacheCall) Do(f func(string, string, int64)) *MockGiteaUnreviewTimelineFetcherResetTimelineCacheCall {
-	c.Call = c.Call.Do(f)
-	return c
-}
-
-// DoAndReturn rewrite *gomock.Call.DoAndReturn
-func (c *MockGiteaUnreviewTimelineFetcherResetTimelineCacheCall) DoAndReturn(f func(string, string, int64)) *MockGiteaUnreviewTimelineFetcherResetTimelineCacheCall {
-	c.Call = c.Call.DoAndReturn(f)
-	return c
-}
-
 // UnrequestReview mocks base method.
 func (m *MockGiteaUnreviewTimelineFetcher) UnrequestReview(org, repo string, id int64, reviwers ...string) error {
 	m.ctrl.T.Helper()
@@ -3543,42 +3327,6 @@ func (c *MockGiteaRequestReviewsCall) DoAndReturn(f func(*models.PullRequest, ..
 	return c
 }
 
-// ResetTimelineCache mocks base method.
-func (m *MockGitea) ResetTimelineCache(org, repo string, idx int64) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "ResetTimelineCache", org, repo, idx)
-}
-
-// ResetTimelineCache indicates an expected call of ResetTimelineCache.
-func (mr *MockGiteaMockRecorder) ResetTimelineCache(org, repo, idx any) *MockGiteaResetTimelineCacheCall {
-	mr.mock.ctrl.T.Helper()
-	call := mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "ResetTimelineCache", reflect.TypeOf((*MockGitea)(nil).ResetTimelineCache), org, repo, idx)
-	return &MockGiteaResetTimelineCacheCall{Call: call}
-}
-
-// MockGiteaResetTimelineCacheCall wrap *gomock.Call
-type MockGiteaResetTimelineCacheCall struct {
-	*gomock.Call
-}
-
-// Return rewrite *gomock.Call.Return
-func (c *MockGiteaResetTimelineCacheCall) Return() *MockGiteaResetTimelineCacheCall {
-	c.Call = c.Call.Return()
-	return c
-}
-
-// Do rewrite *gomock.Call.Do
-func (c *MockGiteaResetTimelineCacheCall) Do(f func(string, string, int64)) *MockGiteaResetTimelineCacheCall {
-	c.Call = c.Call.Do(f)
-	return c
-}
-
-// DoAndReturn rewrite *gomock.Call.DoAndReturn
-func (c *MockGiteaResetTimelineCacheCall) DoAndReturn(f func(string, string, int64)) *MockGiteaResetTimelineCacheCall {
-	c.Call = c.Call.DoAndReturn(f)
-	return c
-}
-
 // SetCommitStatus mocks base method.
 func (m *MockGitea) SetCommitStatus(org, repo, hash string, status *models.CommitStatus) (*models.CommitStatus, error) {
 	m.ctrl.T.Helper()

common/pr.go

@@ -162,8 +162,6 @@ func FetchPRSet(user string, gitea GiteaPRTimelineReviewFetcher, org, repo strin
 	var pr *models.PullRequest
 	var err error
 
-	gitea.ResetTimelineCache(org, repo, num)
-
 	prjGitOrg, prjGitRepo, _ := config.GetPrjGit()
 	if prjGitOrg == org && prjGitRepo == repo {
 		if pr, err = gitea.GetPullRequest(org, repo, num); err != nil {
@@ -188,7 +186,6 @@ func FetchPRSet(user string, gitea GiteaPRTimelineReviewFetcher, org, repo strin
 
 	for _, pr := range prs {
 		org, repo, idx := pr.PRComponents()
-		gitea.ResetTimelineCache(org, repo, idx)
 		reviews, err := FetchGiteaReviews(gitea, org, repo, idx)
 		if err != nil {
 			LogError("Error fetching reviews for", PRtoString(pr.PR), ":", err)
@@ -321,10 +318,7 @@ func (rs *PRSet) FindMissingAndExtraReviewers(maintainers MaintainershipData, id
 		// only need project maintainer reviews if:
 		//    * not created by a bot and has other PRs, or
 		//    * not created by maintainer
-		noReviewPRCreators := []string{}
-		if !rs.Config.ReviewRequired {
-			noReviewPRCreators = prjMaintainers
-		}
+		noReviewPRCreators := prjMaintainers
 		if len(rs.PRs) > 1 {
 			noReviewPRCreators = append(noReviewPRCreators, rs.BotUser)
 		}
@@ -347,10 +341,7 @@ func (rs *PRSet) FindMissingAndExtraReviewers(maintainers MaintainershipData, id
 		pkg := pr.PR.Base.Repo.Name
 		pkgMaintainers := maintainers.ListPackageMaintainers(pkg, nil)
 		Maintainers := slices.Concat(prjMaintainers, pkgMaintainers)
-		noReviewPkgPRCreators := []string{}
-		if !rs.Config.ReviewRequired {
-			noReviewPkgPRCreators = pkgMaintainers
-		}
+		noReviewPkgPRCreators := pkgMaintainers
 
 		LogDebug("packakge maintainers:", Maintainers)
 

common/pr_linkage_test.go

@@ -45,10 +45,9 @@ func TestFetchPRSet_Linkage(t *testing.T) {
 	}
 
 	t.Run("Fetch from ProjectGit PR", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		defer ctl.Finish()
 		mockGitea := mock_common.NewMockGiteaPRTimelineReviewFetcher(ctl)
-		mockGitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 
 		// Expect fetch of prjGitPR
 		mockGitea.EXPECT().GetPullRequest("test-org", "prjgit", int64(500)).Return(prjGitPR, nil)
@@ -74,10 +73,9 @@ func TestFetchPRSet_Linkage(t *testing.T) {
 	})
 
 	t.Run("Fetch from Package PR via Timeline", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		defer ctl.Finish()
 		mockGitea := mock_common.NewMockGiteaPRTimelineReviewFetcher(ctl)
-		mockGitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 
 		// 1. FetchPRSet for pkgPR will call LastPrjGitRefOnTimeline
 		mockGitea.EXPECT().GetTimeline("target-org", "pkg1", int64(101)).Return([]*models.TimelineComment{

common/pr_merge_special_test.go

@@ -10,7 +10,7 @@ import (
 )
 
 func TestPRSet_Merge_Special(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	mockGitea := mock_common.NewMockGiteaReviewUnrequester(ctl)

common/pr_test.go

@@ -561,9 +561,8 @@ func TestPR(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			ctl := NewController(t)
+			ctl := gomock.NewController(t)
 			pr_mock := mock_common.NewMockGiteaPRTimelineReviewFetcher(ctl)
-			pr_mock.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 			review_mock := mock_common.NewMockGiteaPRChecker(ctl)
 			//				reviewer_mock := mock_common.NewMockGiteaReviewRequester(ctl)
 
@@ -873,6 +872,7 @@ func TestFindMissingAndExtraReviewers(t *testing.T) {
 				[]string{"autogits_obs_staging_bot", "user1"},
 			},
 		},
+
 		{
 			name: "Add reviewer if also maintainer where review by maintainer is not needed",
 			prset: &common.PRSet{
@@ -1134,67 +1134,8 @@ func TestFindMissingAndExtraReviewers(t *testing.T) {
 			expected_missing_reviewers: [][]string{{"pkgm2", "prj2"}},
 			expected_extra_reviewers:   [][]string{{}, {"prj1"}},
 		},
-		{
-			name: "Package maintainer submitter, AlwaysRequireReview=false",
-			prset: &common.PRSet{
-				PRs: []*common.PRInfo{
-					{
-						PR: &models.PullRequest{
-							User: &models.User{UserName: "pkgmaintainer"},
-							Base: &models.PRBranchInfo{Name: "main", Repo: &models.Repository{Name: "pkg", Owner: &models.User{UserName: "org"}}},
-						},
-						Reviews: &common.PRReviews{},
-					},
-				},
-				Config: &common.AutogitConfig{
-					GitProjectName: "prg/repo#main",
-					Organization:   "org",
-					Branch:         "main",
-					Reviewers:      []string{},
-					ReviewRequired: false,
-				},
-			},
-			maintainers: &common.MaintainershipMap{
-				Data: map[string][]string{
-					"pkg": {"pkgmaintainer", "pkgm1"},
-				},
-			},
-			noAutoStaging: true,
-			expected_missing_reviewers: [][]string{
-				{},
-			},
-		},
-		{
-			name: "Package maintainer submitter, AlwaysRequireReview=true",
-			prset: &common.PRSet{
-				PRs: []*common.PRInfo{
-					{
-						PR: &models.PullRequest{
-							User: &models.User{UserName: "pkgmaintainer"},
-							Base: &models.PRBranchInfo{Name: "main", Repo: &models.Repository{Name: "pkg", Owner: &models.User{UserName: "org"}}},
-						},
-						Reviews: &common.PRReviews{},
-					},
-				},
-				Config: &common.AutogitConfig{
-					GitProjectName: "prg/repo#main",
-					Organization:   "org",
-					Branch:         "main",
-					Reviewers:      []string{},
-					ReviewRequired: true,
-				},
-			},
-			maintainers: &common.MaintainershipMap{
-				Data: map[string][]string{
-					"pkg": {"pkgmaintainer", "pkgm1"},
-				},
-			},
-			noAutoStaging: true,
-			expected_missing_reviewers: [][]string{
-				{"pkgm1"},
-			},
-		},
 	}
+
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			test.prset.HasAutoStaging = !test.noAutoStaging
@@ -1307,9 +1248,8 @@ func TestPRMerge(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			ctl := NewController(t)
+			ctl := gomock.NewController(t)
 			mock := mock_common.NewMockGiteaPRTimelineReviewFetcher(ctl)
-			mock.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 			reviewUnrequestMock := mock_common.NewMockGiteaReviewUnrequester(ctl)
 
 			reviewUnrequestMock.EXPECT().UnrequestReview(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes()
@@ -1381,9 +1321,8 @@ func TestPRChanges(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			ctl := NewController(t)
+			ctl := gomock.NewController(t)
 			mock_fetcher := mock_common.NewMockGiteaPRTimelineReviewFetcher(ctl)
-			mock_fetcher.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 			mock_fetcher.EXPECT().GetPullRequest("org", "prjgit", int64(42)).Return(test.PrjPRs, nil).AnyTimes()
 			mock_fetcher.EXPECT().GetTimeline("org", "prjgit", int64(42)).Return(nil, nil).AnyTimes()
 			mock_fetcher.EXPECT().GetPullRequestReviews("org", "prjgit", int64(42)).Return(nil, nil).AnyTimes()

common/request_handler.go

@@ -21,6 +21,8 @@ package common
 import (
 	"encoding/json"
 	"fmt"
+	"log"
+	"os"
 )
 
 type RequestType interface {
@@ -85,14 +87,24 @@ func ParseRequestJSON(reqType string, data []byte) (req *Request, err error) {
 }
 
 type RequestHandler struct {
+	StdLogger, ErrLogger *log.Logger
 	Request              *Request
 }
 
 func (r *RequestHandler) WriteError() {
-	LogError("internal error sent")
+	r.ErrLogger.Println("internal error sent")
 }
 
 func CreateRequestHandler() (*RequestHandler, error) {
 	var h *RequestHandler = new(RequestHandler)
+
+	h.StdLogger, h.ErrLogger = CreateStdoutLogger(os.Stdout, os.Stderr)
+
+	/*	var err error
+		h.Git, err = CreateGitHandler(git_author, name)
+		if err != nil {
+			return nil, err
+		}
+	*/
 	return h, nil
 }

common/request_pr_test.go

@@ -19,6 +19,7 @@ package common
  */
 
 import (
+	"os"
 	"strings"
 	"testing"
 )
@@ -26,6 +27,8 @@ import (
 func TestPrParsing(t *testing.T) {
 	t.Run("Test parsing", func(t *testing.T) {
 		var h RequestHandler
+		h.StdLogger, h.ErrLogger = CreateStdoutLogger(os.Stdout, os.Stdout)
+
 		pr, err := h.parsePullRequest(strings.NewReader(samplePR_JSON))
 		if err != nil {
 			t.Fatalf("error parsing PR: %v\n", err)

common/request_push.go

@@ -62,7 +62,7 @@ func (h *RequestHandler) ParsePushRequest(data io.Reader) (*PushWebhookEvent, er
 		return nil, fmt.Errorf("Unexpected URL for SSH repository: '%s'", action.Repository.Name)
 	}
 
-	LogInfo("Request push for repo:", action.Repository.Full_Name)
+	h.StdLogger.Printf("Request push for repo: %s\n", action.Repository.Full_Name)
 	h.Request = &Request{
 		Type: RequestType_Push,
 		Data: action,

common/request_push_test.go

@@ -19,6 +19,7 @@ package common_test
  */
 
 import (
+	"os"
 	"strings"
 	"testing"
 
@@ -26,10 +27,10 @@ import (
 )
 
 func TestPushRequestParsing(t *testing.T) {
-	common.SetTestLogger(t)
 	t.Run("parsing repo creation message", func(t *testing.T) {
 		var h common.RequestHandler
 
+		h.StdLogger, h.ErrLogger = common.CreateStdoutLogger(os.Stdout, os.Stderr)
 		json, err := h.ParsePushRequest(strings.NewReader(examplePushJSON))
 		if err != nil {
 			t.Fatalf("failed to parser push request: %v", err)

common/request_repo.go

@@ -117,7 +117,7 @@ func (h *RequestHandler) ParseRepositoryRequest(dataReader io.Reader) (data *Rep
 
 	data.PrjGit = data.Repository.Ssh_Url[:repoIdx+1] + DefaultGitPrj + ".git"
 
-	LogInfo(data.Action, "request for repo:", data.Repository.Full_Name)
+	h.StdLogger.Printf("Request '%s' for repo: %s\n", data.Action, data.Repository.Full_Name)
 	if len(data.Action) < 1 {
 		return nil, fmt.Errorf("Request has no data.... skipping")
 	}

common/request_repo_test.go

@@ -19,6 +19,7 @@ package common_test
  */
 
 import (
+	"os"
 	"strings"
 	"testing"
 
@@ -35,10 +36,10 @@ func (s *testLogger) WriteString(str2 string) (int, error) {
 }
 
 func TestRepositoryRequestParsing(t *testing.T) {
-	common.SetTestLogger(t)
 	t.Run("parsing repo creation message", func(t *testing.T) {
 		var h common.RequestHandler
 
+		h.StdLogger, h.ErrLogger = common.CreateStdoutLogger(os.Stdout, os.Stdout)
 		json, err := h.ParseRepositoryRequest(strings.NewReader(repoCreateJSON))
 		if err != nil {
 			t.Fatalf("Can't parse struct: %s", err)

common/request_status.go

@@ -52,7 +52,7 @@ func (h *RequestHandler) ParseStatusRequest(data io.Reader) (*StatusWebhookEvent
 		return nil, fmt.Errorf("Got error while parsing: %w", err)
 	}
 
-	LogInfo("Request status for repo:", action.Repository.Full_Name+"#"+action.Sha)
+	h.StdLogger.Printf("Request status for repo: %s#%s\n", action.Repository.Full_Name, action.Sha)
 	h.Request = &Request{
 		Type: RequestType_Status,
 		Data: action,

common/request_status_test.go

@@ -1,6 +1,7 @@
 package common_test
 
 import (
+	"os"
 	"strings"
 	"testing"
 
@@ -8,10 +9,10 @@ import (
 )
 
 func TestStatusRequestParsing(t *testing.T) {
-	common.SetTestLogger(t)
 	t.Run("parsing repo creation message", func(t *testing.T) {
 		var h common.RequestHandler
 
+		h.StdLogger, h.ErrLogger = common.CreateStdoutLogger(os.Stdout, os.Stdout)
 		json, err := h.ParseStatusRequest(strings.NewReader(requestStatusJSON))
 		if err != nil {
 			t.Fatalf("Can't parse struct: %s", err)

common/review_group_test.go

@@ -8,7 +8,6 @@ import (
 )
 
 func TestMaintainerGroupReplacer(t *testing.T) {
-	common.SetTestLogger(t)
 	GroupName := "my_group"
 
 	tests := []struct {

common/reviewers_test.go

@@ -8,7 +8,6 @@ import (
 )
 
 func TestReviewers(t *testing.T) {
-	common.SetTestLogger(t)
 	tests := []struct {
 		name  string
 		input []string

common/reviews_test.go

@@ -4,6 +4,7 @@ import (
 	"errors"
 	"testing"
 
+	"go.uber.org/mock/gomock"
 	"src.opensuse.org/autogits/common"
 	"src.opensuse.org/autogits/common/gitea-generated/models"
 	mock_common "src.opensuse.org/autogits/common/mock"
@@ -141,7 +142,7 @@ func TestReviews(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			ctl := NewController(t)
+			ctl := gomock.NewController(t)
 			rf := mock_common.NewMockGiteaReviewTimelineFetcher(ctl)
 
 			if test.timeline == nil {

common/submodules_test.go

@@ -10,7 +10,6 @@ import (
 )
 
 func TestSubmodulesParsing(t *testing.T) {
-	common.SetTestLogger(t)
 	tests := []struct {
 		name      string
 		file      string
@@ -124,7 +123,6 @@ func TestSubmodulesParsing(t *testing.T) {
 }
 
 func TestSubmodulesWriting(t *testing.T) {
-	common.SetTestLogger(t)
 	tests := []struct {
 		name      string
 		subs      []common.Submodule

common/utils.go

@@ -286,4 +286,3 @@ func TrimRemovedBranchSuffix(branchName string) string {
 
 	return branchName
 }
-

common/utils_test.go

@@ -3,7 +3,6 @@ package common_test
 import (
 	"reflect"
 	"testing"
-	"go.uber.org/mock/gomock"
 
 	"src.opensuse.org/autogits/common"
 )
@@ -306,8 +305,3 @@ func TestNewPackageIssueParsing(t *testing.T) {
 		})
 	}
 }
-
-func NewController(t *testing.T) *gomock.Controller {
-	common.SetTestLogger(t)
-	return gomock.NewController(t)
-}

group-review/README.md

@@ -1,54 +1,43 @@
 Group Review Bot
 ================
 
-This workaround is mainly needed because Gitea does not track which team member performed a review on behalf of a team.
+Areas of responsibility
+-----------------------
 
-Main Tasks
-----------
+1. Is used to handle reviews associated with groups defined in the
+   ProjectGit.
 
-Awaits a comment in the format “@groupreviewbot-name: approve”, then approves the PR with the comment “<user> approved a review on behalf of <groupreviewbot-name>.”
+2. Assumes: workflow-pr needs to associate and define the PR set from
+   which the groups.json is read (Base of the PrjGit PR)
 
 Target Usage
 ------------
 
 Projects where policy reviews are required.
 
-Configuration
+Configiuration
 --------------
 
-The bot is configured via the `ReviewGroups` field in the `workflow.config` file, located in the ProjectGit repository.
+Groups are defined in the workflow.config inside the project git. They take following options,
 
-See `ReviewGroups` in the [workflow-pr configuration](../workflow-pr/README.md#config-file).
-
-```json
 {
-  ...
-  "ReviewGroups": [
-    {
-      "Name": "name of the group user",
-      "Reviewers": ["members", "of", "group"],
-      "Silent": "(true, false) -- if true, do not explicitly require review requests of group members"
-    }
-  ],
-  ...
+...
+ReviewGroups: [
+     {
+        "Name": "name of the group user",
+        "Reviewers": ["members", "of", "group"],
+        "Silent": (true, false) -- if true, do not explicitly require review requests of group members
+     },
+],
+...
 }
-```
-
-Server configuration
---------------------------
-
-**Configuration file:**
-
-| Field | Type | Notes |
-| ----- | ----- | ----- |
-| root | Array of string  | Format **org/repo\#branch** |
 
 Requirements
 ------------
-Gitea token with following permissions:
-- R/W PullRequest
-- R/W Notification
-- R User
+  * Gitea token to:
+     + R/W PullRequest
+     + R/W Notification
+     + R   User
 
 Env Variables
 -------------

group-review/main.go

@@ -18,23 +18,20 @@ import (
 	"src.opensuse.org/autogits/common/gitea-generated/models"
 )
 
-type ReviewBot struct {
-	configs   common.AutogitConfigs
-	acceptRx  *regexp.Regexp
-	rejectRx  *regexp.Regexp
-	groupName string
-	gitea     common.Gitea
+var configs common.AutogitConfigs
+var acceptRx *regexp.Regexp
+var rejectRx *regexp.Regexp
+var groupName string
+
+func InitRegex(newGroupName string) {
+	groupName = newGroupName
+	acceptRx = regexp.MustCompile("^:\\s*(LGTM|approved?)")
+	rejectRx = regexp.MustCompile("^:\\s*")
 }
 
-func (bot *ReviewBot) InitRegex(newGroupName string) {
-	bot.groupName = newGroupName
-	bot.acceptRx = regexp.MustCompile("^:\\s*(LGTM|approved?)")
-	bot.rejectRx = regexp.MustCompile("^:\\s*")
-}
-
-func (bot *ReviewBot) ParseReviewLine(reviewText string) (bool, string) {
+func ParseReviewLine(reviewText string) (bool, string) {
 	line := strings.TrimSpace(reviewText)
-	groupTextName := "@" + bot.groupName
+	groupTextName := "@" + groupName
 	glen := len(groupTextName)
 	if len(line) < glen || line[0:glen] != groupTextName {
 		return false, line
@@ -54,20 +51,20 @@ func (bot *ReviewBot) ParseReviewLine(reviewText string) (bool, string) {
 	return false, line
 }
 
-func (bot *ReviewBot) ReviewAccepted(reviewText string) bool {
+func ReviewAccepted(reviewText string) bool {
 	for _, line := range common.SplitStringNoEmpty(reviewText, "\n") {
-		if matched, reviewLine := bot.ParseReviewLine(line); matched {
-			return bot.acceptRx.MatchString(reviewLine)
+		if matched, reviewLine := ParseReviewLine(line); matched {
+			return acceptRx.MatchString(reviewLine)
 		}
 	}
 	return false
 }
 
-func (bot *ReviewBot) ReviewRejected(reviewText string) bool {
+func ReviewRejected(reviewText string) bool {
 	for _, line := range common.SplitStringNoEmpty(reviewText, "\n") {
-		if matched, reviewLine := bot.ParseReviewLine(line); matched {
-			if bot.rejectRx.MatchString(reviewLine) {
-				return !bot.acceptRx.MatchString(reviewLine)
+		if matched, reviewLine := ParseReviewLine(line); matched {
+			if rejectRx.MatchString(reviewLine) {
+				return !acceptRx.MatchString(reviewLine)
 			}
 		}
 	}
@@ -117,10 +114,10 @@ var commentStrings = []string{
     "change_time_estimate",
 }*/
 
-func (bot *ReviewBot) FindAcceptableReviewInTimeline(user string, timeline []*models.TimelineComment, reviews []*models.PullReview) *models.TimelineComment {
+func FindAcceptableReviewInTimeline(user string, timeline []*models.TimelineComment, reviews []*models.PullReview) *models.TimelineComment {
 	for _, t := range timeline {
 		if t.Type == common.TimelineCommentType_Comment && t.User.UserName == user && t.Created == t.Updated {
-			if bot.ReviewAccepted(t.Body) || bot.ReviewRejected(t.Body) {
+			if ReviewAccepted(t.Body) || ReviewRejected(t.Body) {
 				return t
 			}
 		}
@@ -129,9 +126,9 @@ func (bot *ReviewBot) FindAcceptableReviewInTimeline(user string, timeline []*mo
 	return nil
 }
 
-func (bot *ReviewBot) FindOurLastReviewInTimeline(timeline []*models.TimelineComment) *models.TimelineComment {
+func FindOurLastReviewInTimeline(timeline []*models.TimelineComment) *models.TimelineComment {
 	for _, t := range timeline {
-		if t.Type == common.TimelineCommentType_Review && t.User.UserName == bot.groupName && t.Created == t.Updated {
+		if t.Type == common.TimelineCommentType_Review && t.User.UserName == groupName && t.Created == t.Updated {
 			return t
 		}
 	}
@@ -139,13 +136,13 @@ func (bot *ReviewBot) FindOurLastReviewInTimeline(timeline []*models.TimelineCom
 	return nil
 }
 
-func (bot *ReviewBot) UnrequestReviews(org, repo string, id int64, users []string) {
-	if err := bot.gitea.UnrequestReview(org, repo, id, users...); err != nil {
+func UnrequestReviews(gitea common.Gitea, org, repo string, id int64, users []string) {
+	if err := gitea.UnrequestReview(org, repo, id, users...); err != nil {
 		common.LogError("Can't remove reviewrs after a review:", err)
 	}
 }
 
-func (bot *ReviewBot) ProcessNotifications(notification *models.NotificationThread) {
+func ProcessNotifications(notification *models.NotificationThread, gitea common.Gitea) {
 	defer func() {
 		if r := recover(); r != nil {
 			common.LogInfo("panic cought --- recovered")
@@ -172,14 +169,14 @@ func (bot *ReviewBot) ProcessNotifications(notification *models.NotificationThre
 	id, _ := strconv.ParseInt(match[3], 10, 64)
 
 	common.LogInfo("processing:", fmt.Sprintf("%s/%s!%d", org, repo, id))
-	pr, err := bot.gitea.GetPullRequest(org, repo, id)
+	pr, err := gitea.GetPullRequest(org, repo, id)
 	if err != nil {
 		common.LogError("  ** Cannot fetch PR associated with review:", subject.URL, "Error:", err)
 		return
 	}
 
-	if err := bot.ProcessPR(pr); err == nil && !common.IsDryRun {
-		if err := bot.gitea.SetNotificationRead(notification.ID); err != nil {
+	if err := ProcessPR(pr); err == nil && !common.IsDryRun {
+		if err := gitea.SetNotificationRead(notification.ID); err != nil {
 			common.LogDebug("  Cannot set notification as read", err)
 		}
 	} else if err != nil && err != ReviewNotFinished {
@@ -189,24 +186,24 @@ func (bot *ReviewBot) ProcessNotifications(notification *models.NotificationThre
 
 var ReviewNotFinished = fmt.Errorf("Review is not finished")
 
-func (bot *ReviewBot) ProcessPR(pr *models.PullRequest) error {
+func ProcessPR(pr *models.PullRequest) error {
 	org := pr.Base.Repo.Owner.UserName
 	repo := pr.Base.Repo.Name
 	id := pr.Index
 
 	found := false
 	for _, reviewer := range pr.RequestedReviewers {
-		if reviewer != nil && reviewer.UserName == bot.groupName {
+		if reviewer != nil && reviewer.UserName == groupName {
 			found = true
 			break
 		}
 	}
 	if !found {
-		common.LogInfo("   review is not requested for", bot.groupName)
+		common.LogInfo("   review is not requested for", groupName)
 		return nil
 	}
 
-	config := bot.configs.GetPrjGitConfig(org, repo, pr.Base.Name)
+	config := configs.GetPrjGitConfig(org, repo, pr.Base.Name)
 	if config == nil {
 		return fmt.Errorf("Cannot find config for: %s", pr.URL)
 	}
@@ -216,17 +213,17 @@ func (bot *ReviewBot) ProcessPR(pr *models.PullRequest) error {
 		return nil
 	}
 
-	reviews, err := bot.gitea.GetPullRequestReviews(org, repo, id)
+	reviews, err := gitea.GetPullRequestReviews(org, repo, id)
 	if err != nil {
 		return fmt.Errorf("Failed to fetch reviews for: %v: %w", pr.URL, err)
 	}
 
-	timeline, err := common.FetchTimelineSinceReviewRequestOrPush(bot.gitea, bot.groupName, pr.Head.Sha, org, repo, id)
+	timeline, err := common.FetchTimelineSinceReviewRequestOrPush(gitea, groupName, pr.Head.Sha, org, repo, id)
 	if err != nil {
 		return fmt.Errorf("Failed to fetch timeline to review. %w", err)
 	}
 
-	groupConfig, err := config.GetReviewGroup(bot.groupName)
+	groupConfig, err := config.GetReviewGroup(groupName)
 	if err != nil {
 		return fmt.Errorf("Failed to fetch review group. %w", err)
 	}
@@ -237,30 +234,30 @@ func (bot *ReviewBot) ProcessPR(pr *models.PullRequest) error {
 	//	pr.Head.Sha
 
 	for _, reviewer := range requestReviewers {
-		if review := bot.FindAcceptableReviewInTimeline(reviewer, timeline, reviews); review != nil {
-			if bot.ReviewAccepted(review.Body) {
+		if review := FindAcceptableReviewInTimeline(reviewer, timeline, reviews); review != nil {
+			if ReviewAccepted(review.Body) {
 				if !common.IsDryRun {
-					text := reviewer + " approved a review on behalf of " + bot.groupName
-					if review := bot.FindOurLastReviewInTimeline(timeline); review == nil || review.Body != text {
-						_, err := bot.gitea.AddReviewComment(pr, common.ReviewStateApproved, text)
+					text := reviewer + " approved a review on behalf of " + groupName
+					if review := FindOurLastReviewInTimeline(timeline); review == nil || review.Body != text {
+						_, err := gitea.AddReviewComment(pr, common.ReviewStateApproved, text)
 						if err != nil {
 							common.LogError("    -> failed to write approval comment", err)
 						}
-						bot.UnrequestReviews(org, repo, id, requestReviewers)
+						UnrequestReviews(gitea, org, repo, id, requestReviewers)
 					}
 				}
 				common.LogInfo("  -> approved by", reviewer)
 				common.LogInfo("     review at", review.Created)
 				return nil
-			} else if bot.ReviewRejected(review.Body) {
+			} else if ReviewRejected(review.Body) {
 				if !common.IsDryRun {
-					text := reviewer + " requested changes on behalf of " + bot.groupName + ". See " + review.HTMLURL
-					if review := bot.FindOurLastReviewInTimeline(timeline); review == nil || review.Body != text {
-						_, err := bot.gitea.AddReviewComment(pr, common.ReviewStateRequestChanges, text)
+					text := reviewer + " requested changes on behalf of " + groupName + ". See " + review.HTMLURL
+					if review := FindOurLastReviewInTimeline(timeline); review == nil || review.Body != text {
+						_, err := gitea.AddReviewComment(pr, common.ReviewStateRequestChanges, text)
 						if err != nil {
 							common.LogError("    -> failed to write rejecting comment", err)
 						}
-						bot.UnrequestReviews(org, repo, id, requestReviewers)
+						UnrequestReviews(gitea, org, repo, id, requestReviewers)
 					}
 				}
 				common.LogInfo("  -> declined by", reviewer)
@@ -274,7 +271,7 @@ func (bot *ReviewBot) ProcessPR(pr *models.PullRequest) error {
 	if !groupConfig.Silent && len(requestReviewers) > 0 {
 		common.LogDebug("  Requesting reviews for:", requestReviewers)
 		if !common.IsDryRun {
-			if _, err := bot.gitea.RequestReviews(pr, requestReviewers...); err != nil {
+			if _, err := gitea.RequestReviews(pr, requestReviewers...); err != nil {
 				common.LogDebug("   -> err:", err)
 			}
 		} else {
@@ -287,40 +284,42 @@ func (bot *ReviewBot) ProcessPR(pr *models.PullRequest) error {
 	// add a helpful comment, if not yet added
 	found_help_comment := false
 	for _, t := range timeline {
-		if t.Type == common.TimelineCommentType_Comment && t.User != nil && t.User.UserName == bot.groupName {
+		if t.Type == common.TimelineCommentType_Comment && t.User != nil && t.User.UserName == groupName {
 			found_help_comment = true
 			break
 		}
 	}
 
 	if !found_help_comment && !common.IsDryRun {
-		helpComment := fmt.Sprintln("Review by", bot.groupName, "represents a group of reviewers:", strings.Join(requestReviewers, ", "), ".\n\n"+
+		helpComment := fmt.Sprintln("Review by", groupName, "represents a group of reviewers:", strings.Join(requestReviewers, ", "), ".\n\n"+
 			"Do **not** use standard review interface to review on behalf of the group.\n"+
-			"To accept the review on behalf of the group, create the following comment: `@"+bot.groupName+": approve`.\n"+
-			"To request changes on behalf of the group, create the following comment: `@"+bot.groupName+": decline` followed with lines justifying the decision.\n"+
+			"To accept the review on behalf of the group, create the following comment: `@"+groupName+": approve`.\n"+
+			"To request changes on behalf of the group, create the following comment: `@"+groupName+": decline` followed with lines justifying the decision.\n"+
 			"Future edits of the comments are ignored, a new comment is required to change the review state.")
 		if slices.Contains(groupConfig.Reviewers, pr.User.UserName) {
 			helpComment = helpComment + "\n\n" +
 				"Submitter is member of this review group, hence they are excluded from being one of the reviewers here"
 		}
-		bot.gitea.AddComment(pr, helpComment)
+		gitea.AddComment(pr, helpComment)
 	}
 
 	return ReviewNotFinished
 }
 
-func (bot *ReviewBot) PeriodReviewCheck() {
-	notifications, err := bot.gitea.GetNotifications(common.GiteaNotificationType_Pull, nil)
+func PeriodReviewCheck() {
+	notifications, err := gitea.GetNotifications(common.GiteaNotificationType_Pull, nil)
 	if err != nil {
 		common.LogError("   Error fetching unread notifications: %w", err)
 		return
 	}
 
 	for _, notification := range notifications {
-		bot.ProcessNotifications(notification)
+		ProcessNotifications(notification, gitea)
 	}
 }
 
+var gitea common.Gitea
+
 func main() {
 	giteaUrl := flag.String("gitea-url", "https://src.opensuse.org", "Gitea instance used for reviews")
 	rabbitMqHost := flag.String("rabbit-url", "amqps://rabbit.opensuse.org", "RabbitMQ instance where Gitea webhook notifications are sent")
@@ -356,7 +355,7 @@ func main() {
 		flag.Usage()
 		return
 	}
-	targetGroupName := args[0]
+	groupName = args[0]
 
 	if *configFile == "" {
 		common.LogError("Missing config file")
@@ -379,14 +378,14 @@ func main() {
 		return
 	}
 
-	giteaTransport := common.AllocateGiteaTransport(*giteaUrl)
-	configs, err := common.ResolveWorkflowConfigs(giteaTransport, configData)
+	gitea = common.AllocateGiteaTransport(*giteaUrl)
+	configs, err = common.ResolveWorkflowConfigs(gitea, configData)
 	if err != nil {
 		common.LogError("Cannot parse workflow configs:", err)
 		return
 	}
 
-	reviewer, err := giteaTransport.GetCurrentUser()
+	reviewer, err := gitea.GetCurrentUser()
 	if err != nil {
 		common.LogError("Cannot fetch review user:", err)
 		return
@@ -396,18 +395,14 @@ func main() {
 		*interval = 1
 	}
 
-	bot := &ReviewBot{
-		gitea:   giteaTransport,
-		configs: configs,
-	}
-	bot.InitRegex(targetGroupName)
+	InitRegex(groupName)
 
-	common.LogInfo(" ** processing group reviews for group:", bot.groupName)
+	common.LogInfo(" ** processing group reviews for group:", groupName)
 	common.LogInfo(" ** username in Gitea:", reviewer.UserName)
 	common.LogInfo(" ** polling interval:", *interval, "min")
 	common.LogInfo(" ** connecting to RabbitMQ:", *rabbitMqHost)
 
-	if bot.groupName != reviewer.UserName {
+	if groupName != reviewer.UserName {
 		common.LogError(" ***** Reviewer does not match group name. Aborting. *****")
 		return
 	}
@@ -419,13 +414,10 @@ func main() {
 	}
 
 	config_update := ConfigUpdatePush{
-		bot:             bot,
 		config_modified: make(chan *common.AutogitConfig),
 	}
 
-	process_issue_pr := IssueCommentProcessor{
-		bot: bot,
-	}
+	process_issue_pr := IssueCommentProcessor{}
 
 	configUpdates := &common.RabbitMQGiteaEventsProcessor{
 		Orgs: []string{},
@@ -435,7 +427,7 @@ func main() {
 		},
 	}
 	configUpdates.Connection().RabbitURL = u
-	for _, c := range bot.configs {
+	for _, c := range configs {
 		if org, _, _ := c.GetPrjGit(); !slices.Contains(configUpdates.Orgs, org) {
 			configUpdates.Orgs = append(configUpdates.Orgs, org)
 		}
@@ -448,17 +440,17 @@ func main() {
 			select {
 			case configTouched, ok := <-config_update.config_modified:
 				if ok {
-					for idx, c := range bot.configs {
+					for idx, c := range configs {
 						if c == configTouched {
 							org, repo, branch := c.GetPrjGit()
 							prj := fmt.Sprintf("%s/%s#%s", org, repo, branch)
 							common.LogInfo("Detected config update for", prj)
 
-							new_config, err := common.ReadWorkflowConfig(bot.gitea, prj)
+							new_config, err := common.ReadWorkflowConfig(gitea, prj)
 							if err != nil {
 								common.LogError("Failed parsing Project config for", prj, err)
 							} else {
-								bot.configs[idx] = new_config
+								configs[idx] = new_config
 							}
 						}
 					}
@@ -468,7 +460,7 @@ func main() {
 			}
 		}
 
-		bot.PeriodReviewCheck()
+		PeriodReviewCheck()
 		time.Sleep(time.Duration(*interval * int64(time.Minute)))
 	}
 }

group-review/main_test.go

@@ -1,359 +1,6 @@
 package main
 
-import (
-	"fmt"
-	"testing"
-
-	"go.uber.org/mock/gomock"
-	"src.opensuse.org/autogits/common"
-	"src.opensuse.org/autogits/common/gitea-generated/models"
-	mock_common "src.opensuse.org/autogits/common/mock"
-)
-
-func TestProcessPR(t *testing.T) {
-	ctrl := gomock.NewController(t)
-	defer ctrl.Finish()
-
-	mockGitea := mock_common.NewMockGitea(ctrl)
-	groupName := "testgroup"
-
-	bot := &ReviewBot{
-		gitea:     mockGitea,
-		groupName: groupName,
-	}
-	bot.InitRegex(groupName)
-
-	org := "myorg"
-	repo := "myrepo"
-	prIndex := int64(1)
-	headSha := "abcdef123456"
-
-	pr := &models.PullRequest{
-		Index: prIndex,
-		URL:   "http://gitea/pr/1",
-		State: "open",
-		Base: &models.PRBranchInfo{
-			Name: "main",
-			Repo: &models.Repository{
-				Name: repo,
-				Owner: &models.User{
-					UserName: org,
-				},
-			},
-		},
-		Head: &models.PRBranchInfo{
-			Sha: headSha,
-		},
-		User: &models.User{
-			UserName: "submitter",
-		},
-		RequestedReviewers: []*models.User{
-			{UserName: groupName},
-		},
-	}
-
-	prjConfig := &common.AutogitConfig{
-		GitProjectName: org + "/" + repo + "#main",
-		ReviewGroups: []*common.ReviewGroup{
-			{
-				Name:      groupName,
-				Reviewers: []string{"reviewer1", "reviewer2"},
-			},
-		},
-	}
-	bot.configs = common.AutogitConfigs{prjConfig}
-
-	t.Run("Review not requested for group", func(t *testing.T) {
-		prNoRequest := *pr
-		prNoRequest.RequestedReviewers = nil
-		err := bot.ProcessPR(&prNoRequest)
-		if err != nil {
-			t.Errorf("Expected no error, got %v", err)
-		}
-	})
-
-	t.Run("PR is closed", func(t *testing.T) {
-		prClosed := *pr
-		prClosed.State = "closed"
-		err := bot.ProcessPR(&prClosed)
-		if err != nil {
-			t.Errorf("Expected no error, got %v", err)
-		}
-	})
-
-	t.Run("Successful Approval", func(t *testing.T) {
-		common.IsDryRun = false
-		mockGitea.EXPECT().GetPullRequestReviews(org, repo, prIndex).Return(nil, nil)
-		// reviewer1 approved in timeline
-		timeline := []*models.TimelineComment{
-			{
-				Type: common.TimelineCommentType_Comment,
-				User: &models.User{UserName: "reviewer1"},
-				Body: "@" + groupName + ": approve",
-			},
-		}
-
-		mockGitea.EXPECT().GetTimeline(org, repo, prIndex).Return(timeline, nil)
-
-		expectedText := "reviewer1 approved a review on behalf of " + groupName
-		mockGitea.EXPECT().AddReviewComment(pr, common.ReviewStateApproved, expectedText).Return(nil, nil)
-		mockGitea.EXPECT().UnrequestReview(org, repo, prIndex, gomock.Any()).Return(nil)
-
-		err := bot.ProcessPR(pr)
-		if err != nil {
-			t.Errorf("Expected nil error, got %v", err)
-		}
-	})
-
-	t.Run("Dry Run - No actions taken", func(t *testing.T) {
-		common.IsDryRun = true
-		mockGitea.EXPECT().GetPullRequestReviews(org, repo, prIndex).Return(nil, nil)
-		timeline := []*models.TimelineComment{
-			{
-				Type: common.TimelineCommentType_Comment,
-				User: &models.User{UserName: "reviewer1"},
-				Body: "@" + groupName + ": approve",
-			},
-		}
-		mockGitea.EXPECT().GetTimeline(org, repo, prIndex).Return(timeline, nil)
-
-		// No AddReviewComment or UnrequestReview should be called
-		err := bot.ProcessPR(pr)
-		if err != nil {
-			t.Errorf("Expected nil error, got %v", err)
-		}
-	})
-
-	t.Run("Approval already exists - No new comment", func(t *testing.T) {
-		common.IsDryRun = false
-		mockGitea.EXPECT().GetPullRequestReviews(org, repo, prIndex).Return(nil, nil)
-
-		approvalText := "reviewer1 approved a review on behalf of " + groupName
-		timeline := []*models.TimelineComment{
-			{
-				Type: common.TimelineCommentType_Review,
-				User: &models.User{UserName: groupName},
-				Body: approvalText,
-			},
-			{
-				Type: common.TimelineCommentType_Comment,
-				User: &models.User{UserName: "reviewer1"},
-				Body: "@" + groupName + ": approve",
-			},
-			{
-				Type: common.TimelineCommentType_Comment,
-				User: &models.User{UserName: groupName},
-				Body: "Help comment",
-			},
-		}
-
-		mockGitea.EXPECT().GetTimeline(org, repo, prIndex).Return(timeline, nil)
-
-		// No AddReviewComment, UnrequestReview, or AddComment should be called
-		err := bot.ProcessPR(pr)
-		if err != nil {
-			t.Errorf("Expected nil error, got %v", err)
-		}
-	})
-
-	t.Run("Rejection already exists - No new comment", func(t *testing.T) {
-		common.IsDryRun = false
-		mockGitea.EXPECT().GetPullRequestReviews(org, repo, prIndex).Return(nil, nil)
-
-		rejectionText := "reviewer1 requested changes on behalf of " + groupName + ". See http://gitea/comment/123"
-		timeline := []*models.TimelineComment{
-			{
-				Type: common.TimelineCommentType_Review,
-				User: &models.User{UserName: groupName},
-				Body: rejectionText,
-			},
-			{
-				Type:    common.TimelineCommentType_Comment,
-				User:    &models.User{UserName: "reviewer1"},
-				Body:    "@" + groupName + ": decline",
-				HTMLURL: "http://gitea/comment/123",
-			},
-			{
-				Type: common.TimelineCommentType_Comment,
-				User: &models.User{UserName: groupName},
-				Body: "Help comment",
-			},
-		}
-
-		mockGitea.EXPECT().GetTimeline(org, repo, prIndex).Return(timeline, nil)
-
-		err := bot.ProcessPR(pr)
-		if err != nil {
-			t.Errorf("Expected nil error, got %v", err)
-		}
-	})
-
-	t.Run("Pending review - Help comment already exists", func(t *testing.T) {
-		common.IsDryRun = false
-		mockGitea.EXPECT().GetPullRequestReviews(org, repo, prIndex).Return(nil, nil)
-
-		timeline := []*models.TimelineComment{
-			{
-				Type: common.TimelineCommentType_Comment,
-				User: &models.User{UserName: groupName},
-				Body: "Some help comment",
-			},
-		}
-
-		mockGitea.EXPECT().GetTimeline(org, repo, prIndex).Return(timeline, nil)
-
-		// It will try to request reviews
-		mockGitea.EXPECT().RequestReviews(pr, "reviewer1", "reviewer2").Return(nil, nil)
-
-		// AddComment should NOT be called because bot already has a comment in timeline
-		err := bot.ProcessPR(pr)
-		if err != ReviewNotFinished {
-			t.Errorf("Expected ReviewNotFinished error, got %v", err)
-		}
-	})
-
-	t.Run("Submitter is group member - Excluded from review request", func(t *testing.T) {
-		common.IsDryRun = false
-		prSubmitterMember := *pr
-		prSubmitterMember.User = &models.User{UserName: "reviewer1"}
-		mockGitea.EXPECT().GetPullRequestReviews(org, repo, prIndex).Return(nil, nil)
-		mockGitea.EXPECT().GetTimeline(org, repo, prIndex).Return(nil, nil)
-		mockGitea.EXPECT().RequestReviews(&prSubmitterMember, "reviewer2").Return(nil, nil)
-		mockGitea.EXPECT().AddComment(&prSubmitterMember, gomock.Any()).Return(nil)
-		err := bot.ProcessPR(&prSubmitterMember)
-		if err != ReviewNotFinished {
-			t.Errorf("Expected ReviewNotFinished error, got %v", err)
-		}
-	})
-
-	t.Run("Successful Rejection", func(t *testing.T) {
-		common.IsDryRun = false
-		mockGitea.EXPECT().GetPullRequestReviews(org, repo, prIndex).Return(nil, nil)
-		timeline := []*models.TimelineComment{
-			{
-				Type:    common.TimelineCommentType_Comment,
-				User:    &models.User{UserName: "reviewer2"},
-				Body:    "@" + groupName + ": decline",
-				HTMLURL: "http://gitea/comment/999",
-			},
-		}
-		mockGitea.EXPECT().GetTimeline(org, repo, prIndex).Return(timeline, nil)
-		expectedText := "reviewer2 requested changes on behalf of " + groupName + ". See http://gitea/comment/999"
-		mockGitea.EXPECT().AddReviewComment(pr, common.ReviewStateRequestChanges, expectedText).Return(nil, nil)
-		mockGitea.EXPECT().UnrequestReview(org, repo, prIndex, gomock.Any()).Return(nil)
-		err := bot.ProcessPR(pr)
-		if err != nil {
-			t.Errorf("Expected nil error, got %v", err)
-		}
-	})
-
-	t.Run("Config not found", func(t *testing.T) {
-		bot.configs = common.AutogitConfigs{}
-		err := bot.ProcessPR(pr)
-		if err == nil {
-			t.Error("Expected error when config is missing, got nil")
-		}
-	})
-
-	t.Run("Gitea error in GetPullRequestReviews", func(t *testing.T) {
-		bot.configs = common.AutogitConfigs{prjConfig}
-		mockGitea.EXPECT().GetPullRequestReviews(org, repo, prIndex).Return(nil, fmt.Errorf("gitea error"))
-		err := bot.ProcessPR(pr)
-		if err == nil {
-			t.Error("Expected error from gitea, got nil")
-		}
-	})
-}
-
-func TestProcessNotifications(t *testing.T) {
-	ctrl := gomock.NewController(t)
-	defer ctrl.Finish()
-
-	mockGitea := mock_common.NewMockGitea(ctrl)
-	groupName := "testgroup"
-
-	bot := &ReviewBot{
-		gitea:     mockGitea,
-		groupName: groupName,
-	}
-	bot.InitRegex(groupName)
-
-	org := "myorg"
-	repo := "myrepo"
-	prIndex := int64(123)
-	notificationID := int64(456)
-
-	notification := &models.NotificationThread{
-		ID: notificationID,
-		Subject: &models.NotificationSubject{
-			URL: fmt.Sprintf("http://gitea/api/v1/repos/%s/%s/pulls/%d", org, repo, prIndex),
-		},
-	}
-
-	t.Run("Notification Success", func(t *testing.T) {
-		common.IsDryRun = false
-		pr := &models.PullRequest{
-			Index: prIndex,
-			Base: &models.PRBranchInfo{
-				Name: "main",
-				Repo: &models.Repository{
-					Name:  repo,
-					Owner: &models.User{UserName: org},
-				},
-			},
-
-			Head: &models.PRBranchInfo{
-				Sha: "headsha",
-				Repo: &models.Repository{
-					Name:  repo,
-					Owner: &models.User{UserName: org},
-				},
-			},
-
-			User:               &models.User{UserName: "submitter"},
-			RequestedReviewers: []*models.User{{UserName: groupName}},
-		}
-
-		mockGitea.EXPECT().GetPullRequest(org, repo, prIndex).Return(pr, nil)
-
-		prjConfig := &common.AutogitConfig{
-			GitProjectName: org + "/" + repo + "#main",
-			ReviewGroups:   []*common.ReviewGroup{{Name: groupName, Reviewers: []string{"r1"}}},
-		}
-		bot.configs = common.AutogitConfigs{prjConfig}
-		mockGitea.EXPECT().GetPullRequestReviews(org, repo, prIndex).Return(nil, nil)
-		timeline := []*models.TimelineComment{
-			{
-				Type: common.TimelineCommentType_Comment,
-				User: &models.User{UserName: "r1"},
-				Body: "@" + groupName + ": approve",
-			},
-		}
-		mockGitea.EXPECT().GetTimeline(org, repo, prIndex).Return(timeline, nil)
-		expectedText := "r1 approved a review on behalf of " + groupName
-		mockGitea.EXPECT().AddReviewComment(pr, common.ReviewStateApproved, expectedText).Return(nil, nil)
-		mockGitea.EXPECT().UnrequestReview(org, repo, prIndex, gomock.Any()).Return(nil)
-
-		mockGitea.EXPECT().SetNotificationRead(notificationID).Return(nil)
-
-		bot.ProcessNotifications(notification)
-
-	})
-
-	t.Run("Invalid Notification URL", func(t *testing.T) {
-		badNotification := &models.NotificationThread{
-			Subject: &models.NotificationSubject{
-				URL: "http://gitea/invalid/url",
-			},
-		}
-		bot.ProcessNotifications(badNotification)
-	})
-
-	t.Run("Gitea error in GetPullRequest", func(t *testing.T) {
-		mockGitea.EXPECT().GetPullRequest(org, repo, prIndex).Return(nil, fmt.Errorf("gitea error"))
-		bot.ProcessNotifications(notification)
-	})
-}
+import "testing"
 
 func TestReviewApprovalCheck(t *testing.T) {
 	tests := []struct {
@@ -413,78 +60,16 @@ func TestReviewApprovalCheck(t *testing.T) {
 			InString:  "@group2: disapprove",
 			Rejected:  true,
 		},
-		{
-			Name:      "Whitespace before colon",
-			GroupName: "group",
-			InString:  "@group  : LGTM",
-			Approved:  true,
-		},
-		{
-			Name:      "No whitespace after colon",
-			GroupName: "group",
-			InString:  "@group:LGTM",
-			Approved:  true,
-		},
-		{
-			Name:      "Leading and trailing whitespace on line",
-			GroupName: "group",
-			InString:  "   @group: LGTM   ",
-			Approved:  true,
-		},
-		{
-			Name:      "Multiline: Approved on second line",
-			GroupName: "group",
-			InString:  "Random noise\n@group: approved",
-			Approved:  true,
-		},
-		{
-			Name:      "Multiline: Multiple group mentions, first wins",
-			GroupName: "group",
-			InString:  "@group: decline\n@group: approve",
-			Rejected:  true,
-		},
-		{
-			Name:      "Multiline: Approved on second line",
-			GroupName: "group",
-			InString:  "noise\n@group: approve\nmore noise",
-			Approved:  true,
-		},
-		{
-			Name:      "Not at start of line (even with whitespace)",
-			GroupName: "group",
-			InString:  "Hello @group: approve",
-			Approved:  false,
-		},
-		{
-			Name:      "Rejecting with reason",
-			GroupName: "group",
-			InString:  "@group: decline because of X, Y and Z",
-			Rejected:  true,
-		},
-		{
-			Name:      "No colon after group",
-			GroupName: "group",
-			InString:  "@group LGTM",
-			Approved:  false,
-			Rejected:  false,
-		},
-		{
-			Name:      "Invalid char after group",
-			GroupName: "group",
-			InString:  "@group! LGTM",
-			Approved:  false,
-			Rejected:  false,
-		},
 	}
+
 	for _, test := range tests {
 		t.Run(test.Name, func(t *testing.T) {
-			bot := &ReviewBot{}
-			bot.InitRegex(test.GroupName)
+			InitRegex(test.GroupName)
 
-			if r := bot.ReviewAccepted(test.InString); r != test.Approved {
+			if r := ReviewAccepted(test.InString); r != test.Approved {
 				t.Error("ReviewAccepted() returned", r, "expecting", test.Approved)
 			}
-			if r := bot.ReviewRejected(test.InString); r != test.Rejected {
+			if r := ReviewRejected(test.InString); r != test.Rejected {
 				t.Error("ReviewRejected() returned", r, "expecting", test.Rejected)
 			}
 		})

group-review/rabbit.go

@@ -7,9 +7,7 @@ import (
 	"src.opensuse.org/autogits/common"
 )
 
-type IssueCommentProcessor struct {
-	bot *ReviewBot
-}
+type IssueCommentProcessor struct{}
 
 func (s *IssueCommentProcessor) ProcessFunc(req *common.Request) error {
 	if req.Type != common.RequestType_IssueComment {
@@ -21,15 +19,14 @@ func (s *IssueCommentProcessor) ProcessFunc(req *common.Request) error {
 	repo := data.Repository.Name
 	index := int64(data.Issue.Number)
 
-	pr, err := s.bot.gitea.GetPullRequest(org, repo, index)
+	pr, err := gitea.GetPullRequest(org, repo, index)
 	if err != nil {
 		return fmt.Errorf("Failed to fetch PullRequest from event: %s/%s!%d  Error: %w", org, repo, index, err)
 	}
-	return s.bot.ProcessPR(pr)
+	return ProcessPR(pr)
 }
 
 type ConfigUpdatePush struct {
-	bot             *ReviewBot
 	config_modified chan *common.AutogitConfig
 }
 
@@ -49,7 +46,7 @@ func (s *ConfigUpdatePush) ProcessFunc(req *common.Request) error {
 	}
 	branch := data.Ref[len(branch_ref):]
 
-	c := s.bot.configs.GetPrjGitConfig(org, repo, branch)
+	c := configs.GetPrjGitConfig(org, repo, branch)
 	if c == nil {
 		return nil
 	}
@@ -67,7 +64,7 @@ func (s *ConfigUpdatePush) ProcessFunc(req *common.Request) error {
 	}
 
 	if modified_config {
-		for _, config := range s.bot.configs {
+		for _, config := range configs {
 			if o, r, _ := config.GetPrjGit(); o == org && r == repo {
 				s.config_modified <- config
 			}

group-review/rabbit_test.go

@@ -1,203 +0,0 @@
-package main
-
-import (
-	"fmt"
-	"testing"
-
-	"go.uber.org/mock/gomock"
-	"src.opensuse.org/autogits/common"
-	"src.opensuse.org/autogits/common/gitea-generated/models"
-	mock_common "src.opensuse.org/autogits/common/mock"
-)
-
-func TestIssueCommentProcessor(t *testing.T) {
-	ctrl := gomock.NewController(t)
-	defer ctrl.Finish()
-
-	mockGitea := mock_common.NewMockGitea(ctrl)
-	groupName := "testgroup"
-	bot := &ReviewBot{
-		gitea:     mockGitea,
-		groupName: groupName,
-	}
-	bot.InitRegex(groupName)
-
-	processor := &IssueCommentProcessor{bot: bot}
-
-	org := "myorg"
-	repo := "myrepo"
-	index := 123
-
-	event := &common.IssueCommentWebhookEvent{
-		Repository: &common.Repository{
-			Name: repo,
-			Owner: &common.Organization{
-				Username: org,
-			},
-		},
-		Issue: &common.IssueDetail{
-			Number: index,
-		},
-	}
-
-	req := &common.Request{
-		Type: common.RequestType_IssueComment,
-		Data: event,
-	}
-
-	t.Run("Successful Processing", func(t *testing.T) {
-		pr := &models.PullRequest{
-			Index: int64(index),
-			Base: &models.PRBranchInfo{
-				Name: "main",
-				Repo: &models.Repository{
-					Name: repo,
-					Owner: &models.User{UserName: org},
-				},
-			},
-			Head: &models.PRBranchInfo{
-				Sha: "headsha",
-				Repo: &models.Repository{
-					Name: repo,
-					Owner: &models.User{UserName: org},
-				},
-			},
-			User:               &models.User{UserName: "submitter"},
-			RequestedReviewers: []*models.User{{UserName: groupName}},
-		}
-
-		mockGitea.EXPECT().GetPullRequest(org, repo, int64(index)).Return(pr, nil)
-
-		prjConfig := &common.AutogitConfig{
-			GitProjectName: org + "/" + repo + "#main",
-			ReviewGroups: []*common.ReviewGroup{{Name: groupName, Reviewers: []string{"r1"}}},
-		}
-		bot.configs = common.AutogitConfigs{prjConfig}
-		mockGitea.EXPECT().GetPullRequestReviews(org, repo, int64(index)).Return(nil, nil)
-		mockGitea.EXPECT().GetTimeline(org, repo, int64(index)).Return(nil, nil)
-		mockGitea.EXPECT().RequestReviews(pr, "r1").Return(nil, nil)
-		mockGitea.EXPECT().AddComment(pr, gomock.Any()).Return(nil)
-
-		err := processor.ProcessFunc(req)
-		if err != ReviewNotFinished {
-			t.Errorf("Expected ReviewNotFinished, got %v", err)
-		}
-	})
-
-	t.Run("Gitea error in GetPullRequest", func(t *testing.T) {
-		mockGitea.EXPECT().GetPullRequest(org, repo, int64(index)).Return(nil, fmt.Errorf("gitea error"))
-		err := processor.ProcessFunc(req)
-		if err == nil {
-			t.Error("Expected error, got nil")
-		}
-	})
-
-	t.Run("Wrong Request Type", func(t *testing.T) {
-		wrongReq := &common.Request{Type: common.RequestType_Push}
-		err := processor.ProcessFunc(wrongReq)
-		if err == nil {
-			t.Error("Expected error for wrong request type, got nil")
-		}
-	})
-}
-
-func TestConfigUpdatePush(t *testing.T) {
-	ctrl := gomock.NewController(t)
-	defer ctrl.Finish()
-
-	groupName := "testgroup"
-	bot := &ReviewBot{
-		groupName: groupName,
-	}
-	bot.InitRegex(groupName)
-
-	configChan := make(chan *common.AutogitConfig, 1)
-	processor := &ConfigUpdatePush{
-		bot:             bot,
-		config_modified: configChan,
-	}
-
-	org := "myorg"
-	repo := "myrepo"
-	branch := "main"
-
-	prjConfig := &common.AutogitConfig{
-		GitProjectName: org + "/" + repo + "#" + branch,
-		Organization:   org,
-		Branch:         branch,
-	}
-	bot.configs = common.AutogitConfigs{prjConfig}
-
-	event := &common.PushWebhookEvent{
-		Ref: "refs/heads/" + branch,
-		Repository: &common.Repository{
-			Name: repo,
-			Owner: &common.Organization{
-				Username: org,
-			},
-		},
-		Commits: []common.Commit{
-			{
-				Modified: []string{common.ProjectConfigFile},
-			},
-		},
-	}
-
-	req := &common.Request{
-		Type: common.RequestType_Push,
-		Data: event,
-	}
-
-	t.Run("Config Modified", func(t *testing.T) {
-		err := processor.ProcessFunc(req)
-		if err != nil {
-			t.Errorf("Expected nil error, got %v", err)
-		}
-
-		select {
-		case modified := <-configChan:
-			if modified != prjConfig {
-				t.Errorf("Expected modified config to be %v, got %v", prjConfig, modified)
-			}
-		default:
-			t.Error("Expected config modification signal, but none received")
-		}
-	})
-
-	t.Run("No Config Modified", func(t *testing.T) {
-		noConfigEvent := *event
-		noConfigEvent.Commits = []common.Commit{{Modified: []string{"README.md"}}}
-		noConfigReq := &common.Request{Type: common.RequestType_Push, Data: &noConfigEvent}
-
-		err := processor.ProcessFunc(noConfigReq)
-		if err != nil {
-			t.Errorf("Expected nil error, got %v", err)
-		}
-
-		select {
-		case <-configChan:
-			t.Error("Did not expect config modification signal")
-		default:
-			// Success
-		}
-	})
-
-	t.Run("Wrong Branch Ref", func(t *testing.T) {
-		wrongBranchEvent := *event
-		wrongBranchEvent.Ref = "refs/tags/v1.0"
-		wrongBranchReq := &common.Request{Type: common.RequestType_Push, Data: &wrongBranchEvent}
-
-		err := processor.ProcessFunc(wrongBranchReq)
-		if err == nil {
-			t.Error("Expected error for wrong branch ref, got nil")
-		}
-	})
-
-	t.Run("Config Not Found", func(t *testing.T) {
-		bot.configs = common.AutogitConfigs{}
-		err := processor.ProcessFunc(req)
-		if err != nil {
-			t.Errorf("Expected nil error even if config not found, got %v", err)
-		}
-	})
-}

obs-staging-bot/README.md

@@ -4,15 +4,11 @@ OBS Staging Bot
 Build a PR against a ProjectGit, if review is requested.
 
 
-Main Tasks
-----------
+Areas of Responsibility
+-----------------------
 
-* A build in OBS is initiated when a review for this bot is requested.
-* The overall build status is reported:
-  * Build successful
-  * Build failed
-* It checks the build status only for the involved packages compared to the last state of the project for all architectures and all flavors.
-* It adds an svg with detailed building status.
+* Monitors Notification API in Gitea for review requests
+* Reviews Package build results in OBS for all changed packages in ProjectGit PR
 
 
 Target Usage
@@ -25,48 +21,22 @@ Configuration File
 ------------------
 
 Bot reads `staging.config` from the project git or the PR to the project git.
-It's a JSON file with following syntax:
+It's a JSON file with following syntax
 
-```json
+```
 {
- "ObsProject": "SUSE:SLFO:1.2",
- "StagingProject": "SUSE:SLFO:1.2:PullRequest",
- "QA": [
-   {
-     "Name": "SLES",
-     "Origin": "SUSE:SLFO:Products:SLES:16.0",
-     "BuildDisableRepos": ["product"]
-   }
- ]
+  "ObsProject": "home:foo:project",
+  "StagingProject": "home:foo:project:staging",
+  "QA": [
+    {
+      "Name": "ProjectBuild",
+      "Origin": "home:foo:product:images"
+    }
+  ]
 }
 ```
 
-| Field name | Details | Mandatory | Type | Allowed Values | Default |
-| ----- | ----- | ----- | ----- | ----- | ----- |
-| *ObsProject* | Product OBS project. Builds in this project will be used to compare to builds based on sources from the PR. | yes | string | `[a-zA-Z0-9-_:]+` | |
-| *StagingProject* | Used both as base project and prefix for all OBS staging projects. Upon being added as a reviewer to a PrjGit PR, this bot automatically generates an OBS project named *StagingProject:<PR_Number>*. It must be a sub-project of the *ObsProject*. | yes | string | `[a-zA-Z0-9-_:]+` | |
-| *QA* | Crucial for generating a product build (such as an ISO or FTP tree) that incorporates the packages. | no | array of objects | | |
-| *QA > Name* | Suffix for the QA OBS staging project. The project is named *StagingProject:<PR_Number>:Name*. | no | string | | |
-| *QA > Origin* | OBS reference project | no | string | | |
-| *QA > BuildDisableRepos* | The names of OBS repositories to build-disable, if any. | no | array of strings | | [] |
-
-
-Details
--------
-
-* **OBS staging projects are deleted** when the relative PrjGit PR is closed or merged.
-
-* **PrjGit PR - staging project**
-  * The OBS staging project utilizes an **scmsync** tag, configured with the `onlybuild` flag, to exclusively build packages associated with this specific PrjGit PR.
-  * The **build config** is inherited from the PrjGit PR config file (even if unchanged).
-  * The **project meta** creates a standard repository following the StagingProject as a project path.
-  * The base *StagingProject* has the macro **FromScratch:** set in its config, which prevents inheriting the configuration from the included project paths.
-  * The bot copies the project maintainers from *StagingProject* to the specific staging project (*StagingProject:<PR_Number>*).
-  * The bot reports “Build successful” only if the build is successful for all repositories and all architectures.
-
-* **PrjGit PR - QA staging project**
-  * The QA staging project is meant for building the product; the relative build config is inherited from the `QA > Origin` project.
-  * In this case, the **scmsync** tag is inherited from the `QA > Origin` project.
-  * It is desirable in some cases to avoid building some specific build service repositories when not needed. In this case, `QA > BuildDisableRepos` can be specified.
-    These repositories would be disabled in the project meta when generating the QA project.
+* ObsProject: (**required**) Project where the base project is built. Builds in this project will be used to compare to builds based on sources from the PR
+* StagingProject: template project that will be used as template for the staging project. Omitting this will use the ObsProject repositories to create the staging. Staging project will be created under the template, or in the bot's home directory if not specified.
+* QA: set of projects to build ontop of the binaries built in staging.
 

obs-staging-bot/main.go

@@ -109,11 +109,6 @@ const (
 	BuildStatusSummaryUnknown  = 4
 )
 
-type DisableFlag struct {
-	XMLName string `xml:"disable"`
-	Name    string `xml:"repository,attr"`
-}
-
 func ProcessBuildStatus(project, refProject *common.BuildResultList) BuildStatusSummary {
 	if _, finished := refProject.BuildResultSummary(); !finished {
 		common.LogDebug("refProject not finished building??")
@@ -382,7 +377,7 @@ func GenerateObsPrjMeta(git common.Git, gitea common.Gitea, pr *models.PullReque
 // stagingProject:$buildProject
 //  ^-  stagingProject:$buildProject:$subProjectName (based on templateProject)
 
-func CreateQASubProject(stagingConfig *common.StagingConfig, git common.Git, gitea common.Gitea, pr *models.PullRequest, stagingProject, templateProject, subProjectName string, buildDisableRepos []string) error {
+func CreateQASubProject(stagingConfig *common.StagingConfig, git common.Git, gitea common.Gitea, pr *models.PullRequest, stagingProject, templateProject, subProjectName string) error {
 	common.LogDebug("Setup QA sub projects")
 	templateMeta, err := ObsClient.GetProjectMeta(templateProject)
 	if err != nil {
@@ -412,21 +407,7 @@ func CreateQASubProject(stagingConfig *common.StagingConfig, git common.Git, git
 		repository.Fragment  = branch.SHA
 		templateMeta.ScmSync = repository.String()
 		common.LogDebug("Setting scmsync url to ", templateMeta.ScmSync)
-	}
-	// Build-disable repositories if asked
-	if len(buildDisableRepos) > 0 {
-		toDisable := make([]DisableFlag, len(buildDisableRepos))
-		for idx, repositoryName := range buildDisableRepos {
-			toDisable[idx] = DisableFlag{Name: repositoryName}
-		}
-
-		output, err := xml.Marshal(toDisable)
-		if err != nil {
-			common.LogError("error while marshalling, skipping BuildDisableRepos: ", err)
-		} else {
-			templateMeta.BuildFlags.Contents += string(output)
-		}
-	}
+        }
 	// Cleanup ReleaseTarget and modify affected path entries
 	for idx, r := range templateMeta.Repositories {
 		templateMeta.Repositories[idx].ReleaseTargets = nil
@@ -941,8 +922,7 @@ func ProcessPullRequest(gitea common.Gitea, org, repo string, id int64) (bool, e
 				CreateQASubProject(stagingConfig, git, gitea, pr,
 					stagingProject,
 					setup.Origin,
-					setup.Name,
-					setup.BuildDisableRepos)
+					setup.Name)
 				msg = msg + ObsWebHost + "/project/show/" +
 					stagingProject + ":" + setup.Name + "\n"
 			}

workflow-direct/README.md

@@ -1,41 +1,29 @@
 Direct Workflow bot
 ===================
 
-The project submodule is automatically updated by the direct bot whenever a branch is updated in a package repository.
-This bot can coexist with the Workflow PR bot, which is instead triggered by a new package PR.
-
-Target Usage
-------------
-
-Devel project, where direct pushes to package git are possible.
-
 Areas of responsibility
 -----------------------
 
 1. Keep ProjectGit in sync with packages in the organization
-   * **On pushes to package**: updates the submodule commit ID to the default branch HEAD (as configured in Gitea).
-   * **On repository adds**: creates a new submodule (if non-empty).
-   * **On repository removal**: removes the submodule.
-
-**Note:** If you want to revert a change in a package, you need to do that manually in the project git.
+   * on pushes to package, updates the submodule commit id
+     to the default branch HEAD (as configured in Gitea)
+   * on repository adds, creates a new submodule (if non empty)
+   * on repository removal, removes the submodule
 
 
 Configuration
 -------------
 
-Uses `workflow.config` for configuration.
+Uses `workflow.config` for configuration. Parameters
 
-| Field name | Details | Mandatory | Type | Allowed Values | Default |
-| ----- | ----- | ----- | ----- | ----- | ----- |
-| *Workflows* | Type of workflow | yes | string | “direct” | |
-| *Organization* | The organization that holds all the packages | yes | string | | |
-| *Branch* | The designated branch for packages | no | string | | blank (default package branch) |
-| *GitProjectName* | Repository and branch where the ProjectGit lives. | no | string | **Format**: `org/project_repo#branch` | By default assumes `_ObsPrj` with default branch in the *Organization* |
+* _Workflows_: ["direct"] -- direct entry enables direct workflow. **Mandatory**
+* _Organization_: organization that holds all the packages. **Mandatory**
+* _Branch_: branch updated in repo's, or blank for default package branch
+* _GitProjectName_: package in above org, or `org/package#branch` for PrjGit. By default assumes `_ObsPrj` with default branch and in the `Organization`
 
 NOTE: `-rm`, `-removed`, `-deleted` are all removed suffixes used to indicate current branch is a placeholder for previously existing package. These branches will be ignored by the bot,  and if default, the package will be removed and will not be added to the project.
 
-
-Environment Variables
+Running
 -------
 
  * `GITEA_TOKEN` (required)
@@ -49,3 +37,8 @@ Environment Variables
  * `AUTOGITS_REPO_PATH` - default is temporary directory
  * `AUTOGITS_IDENTITY_FILE` - in case where we need explicit identify path for ssh specified
 
+Target Usage
+------------
+
+Devel project, where direct pushes to package git are possible
+

workflow-pr/README.md

@@ -1,65 +1,55 @@
 Workflow-PR bot
 ===============
 
-Keeps ProjectGit PRs in-sync with the relative PackageGit PRs.
+Keeps ProjectGit PR in-sync with a PackageGit PR
+
+
+Areas of Responsibility
+-----------------------
+
+* Detects a PackageGit PR creation against a package and creates a coresponsing PR against the ProjectGit
+* When a PackageGit PR is updated, the corresponding PR against the ProjectGit is updated
+* Stores reference to the PackageGit PR in the headers of the ProjectGit PR comments, for later reference
+   * this allows ProjectGit PR to be merged to seperated later (via another tool, for example)
+* Initiates all staging workflows via review requests
+
 
 Target Usage
 ------------
 
-Any project (devel, codestream, product, etc.) that accepts PRs.
+Any project (devel, etc) that accepts PR
 
 
-Main Tasks
-----------
-
-* **Synchronization**:
-    * When a **PackageGit PR** is created for a package on a specific project branch, a corresponding PR is automatically generated in **ProjectGit**.
-    * When a PackageGit PR is updated, the corresponding PR against the ProjectGit is updated.
-    * A link to the PackageGit PR is stored in the body of the ProjectGit PR comments in the following format:
-      * `PR: organization/package_name!pull_request_number`
-      * Example: `PR: pool/curl!4`
-    * It closes an empty ProjectGit PR (e.g., if a PR was initially created for a single package but later integrated into a larger ProjectGit PR).
-    * It forwards the Work In Progress (WIP) flag to the ProjectGit PR. If the ProjectGit PR references multiple Package PRs, triggering the WIP flag on the ProjectGit PR side only requires a single WIP package PR.
-
-* **Reviewer Management**:
-    * It adds required reviewers in the ProjectGit PR.
-    * It adds required reviewers in the PackageGit PR.
-    * If new commits are added to a PackageGit PR, reviewers who have already approved it will be re-added.
-
-* **Merge Management**:
-    * Manages PR merges based on configuration flags (`ManualMergeOnly`, `ManualMergeProject`).
-    * In general, merge only happens if all mandatory reviews are completed.
-    * **ManualMergeProject** is stricter than **ManualMergeOnly** and has higher priority.
-
-    | Flag | Value | Behavior |
-    | ----- | ----- | ----- |
-    | ManualMergeProject | true | Both ProjectGit and PackageGit PRs are merged upon an allowed project maintainer commenting "merge ok” in the ProjectGit PR. |
-    | ManualMergeOnly | true | Both PackageGit PR and ProjectGit PR are merged upon an allowed package maintainer or project maintainer commenting “merge ok” in the PackageGit PR. |
-    | ManualMergeOnly and ManualMergeProject | false | Both ProjectGit and PackageGit PRs are merged as soon as all reviews are completed in both PrjGit and PkgGit PRs. |
-
 Config file
 -----------
+JSON
+* _Workflows_: ["pr"] -- pr entry enables pr workflow. **Mandatory**
+* _Organization_: organization that holds all the packages **Mandatory**
+* _Branch_: branch updated in repo's **Mandatory**
+* _GitProjectName_: package in above org, or `org/package#branch` for PrjGit. By default assumes `_ObsPrj` with default branch and in the `Organization`
+* _Reviewers_: accounts associated with mandatory reviews for PrjGit. Can trigger additional
+               review requests for PrjGit or associated PkgGit repos. Only when all reviews are
+               satisfied, will the PrjGit PR be merged. See Reviewers below.
+* _ManualMergeOnly_: (true, false) only merge if "merge ok" comment/review by package or project maintainers or reviewers
+* _ManualMergeProject_: (true, false) only merge if "merge ok" by project maintainers or reviewers
+* _ReviewRequired_: (true, false) ignores that submitter is a maintainer and require a review from other maintainer IFF available
+* _NoProjectGitPR_: (true, false) do not create PrjGit PRs, but still process reviews, etc.
+* _Permissions_: permissions and associated accounts/groups. See below.
+* _Labels_: (string, string) Labels for PRs. See below.
 
-* Filename: `workflow.config`
-* Location: ProjectGit
-* Format: non-standard JSON (comments allowed)
-
-| Field name | Details | Mandatory | Type | Allowed Values | Default |
-| ----- | ----- | ----- | ----- | ----- | ----- |
-| *Workflows* | Type of workflow | yes | string | “pr” | |
-| *Organization* | The organization where PackageGit PRs are expected to occur | yes | string | | |
-| *Branch* | The designated branch for PackageGit PRs | yes | string |  | |
-| *GitProjectName* | Repository and branch where the ProjectGit lives. | no | string | **Format**: `org/project_repo#branch` | By default assumes `_ObsPrj` with default branch in the *Organization* |
-| *ManualMergeOnly* | Merges are permitted only upon receiving a "merge ok" comment from designated maintainers in the PkgGit PR. | no | bool | true, false | false |
-| *ManualMergeProject* | Merges are permitted only upon receiving a "merge ok" comment in the ProjectGit PR from project maintainers. | no | bool | true, false | false |
-| *ReviewRequired* | If submitter is a maintainer, require review from another maintainer if available. | no | bool | true, false | false |
-| *NoProjectGitPR* | Do not create PrjGit PR, but still perform other tasks. | no | bool | true, false | false |
-| *Reviewers* | PrjGit reviewers. Additional review requests are triggered for associated PkgGit PRs. PrjGit PR is merged only when all reviews are complete. | no | array of strings | | `[]` |
-| *ReviewGroups* | If a group is specified in Reviewers, its members are listed here. | no | array of objects | | `[]` |
-| *ReviewGroups > Name* | Name of the group | no | string | | |
-| *ReviewGroups > Reviewers* | Members of the group | no | array of strings | | |
-| *ReviewGroups > Silent* | Add members for notifications. If true, members are not explicitly requested to review. If one member approves, others are removed. | no | bool | true, false | false |
+NOTE: `-rm`, `-removed`, `-deleted` are all removed suffixes used to indicate current branch is a placeholder for previously existing package. These branches will be ignored by the bot,  and if default, the package will be removed and will not be added to the project.
+example:
 
+    [
+     {
+        "Workflows": ["pr", "direct"],
+        "Organization": "autogits",
+        "GitProjectName": "HiddenPrj",
+        "Branch": "hidden",
+        "Reviewers": []
+     },
+     ...
+    ]
 
 Reviewers
 ---------
@@ -68,30 +58,21 @@ Reviews is a list of accounts that need to review package and/or project. They h
 
     [~][*|-|+]username
 
-A tilde (`~`) before a prefix signifies an advisory reviewer. Their input is requested, but their review status will not otherwise affect the process.
+General prefix of ~ indicates advisory reviewer. They will be requested, but ignored otherwise.
 
 Other prefixes indicate project or package association of the reviewer:
-
 * `*` indicates project *and* package
 * `-` indicates project-only reviewer
 * `+` indicates package-only reviewer
 
-`+` is implied.
+`+` is implied. For example
 
-For example: `[foo, -bar, ~*moo]` results in:
-* foo: package reviews
-* bar: project reviews
-* moo: package and project reviews, but ignored
+    `[foo, -bar, ~*moo]`
 
-Package Deletion Requests
--------------------------
-(NOT YET IMPLEMENTED)
-
-* **Removing a Package:**
-  To remove a package from a project, submit a ProjectGit Pull Request (PR) that removes the corresponding submodule. The bot will then rename the project branch in the pool by appending "-removed" to its name.
-
-* **Adding a Package Again:**
-  If you wish to re-add a package, create a new PrjGit PR which adds again the submodule on the branch that has the "-removed" suffix. The bot will automatically remove this suffix from the project branch in the pool.
+results in
+* foo -> package reviews
+* bar -> project reviews
+* moo -> package and project reviews, but ignored
 
 
 Labels
@@ -102,38 +83,26 @@ The following labels are used, when defined in Repo/Org.
 | Label Config Entry | Default label  | Description
 |--------------------|----------------|----------------------------------------
 | StagingAuto        | staging/Auto   | Assigned to Project Git PRs when first staged
-| ReviewPending      | review/Pending | Assigned to Project Git PR when package reviews are still pending
-| ReviewDone         | review/Done    | Assigned to Project Git PR when reviews are complete on all package PRs
+| ReviewPending      | review/Pending | Assigned to PR when reviews are still pending
+| ReviewDone         | review/Done    | Assigned to PR when reviews are complete on this particular PR
 
 
 Maintainership
 --------------
 
-Filename: \_maintainership.json  
-Location: ProjectGit  
-Format: JSON  
-Fields:
+Maintainership information is defined per project. For reviews, package maintainers are coalesced
+with project maintainers. A review by any of the maintainers is acceptable.
 
-| Key  | Value | Notes |
-| ----- | ----- | ----- |
-| package name | array of strings representing the package maintainers | List of package maintainers |
-| “” (empty string) | array of strings representing the project maintainers | List of project maintainers |
+example:
 
-Maintainership information is defined per project. For PackageGit PR reviews, package maintainers are combined with project maintainers. A review by any of these maintainers is acceptable. 
+    {
+        "package1": [ "reviewer", "reviewer2"],
+        "package2": [],
 
-If the submitter is a maintainer it will not get a review requested.
+        // "project" maintainer
+        "": ["reviewer3", "reviewer4"]
+    }
 
-Example:
-
-```
-{
-    "package1": [ "reviewer", "reviewer2"],
-    "package2": [],
-
-    // "project" maintainer
-    "": ["reviewer3", "reviewer4"]
-}
-```
 
 Permissions
 -----------
@@ -153,11 +122,3 @@ the `workflow.config`.
 
 NOTE: Project Maintainers have these permissions automatically.
 
-Server configuration
---------------------------
-
-**Configuration file:**
-
-| Field | Type | Notes |
-| ----- | ----- | ----- |
-| root | Array of string  | Format **org/repo\#branch** |

workflow-pr/issue_processor.go

@@ -1,314 +0,0 @@
-package main
-
-import (
-	"fmt"
-	"slices"
-	"strings"
-
-	"src.opensuse.org/autogits/common"
-	"src.opensuse.org/autogits/common/gitea-generated/models"
-)
-
-func FindSourceRepository(org, repo string) (*models.Repository, error) {
-	srcRepo, err := Gitea.GetRepository(org, repo)
-	if err != nil {
-		return nil, err
-	}
-	if srcRepo == nil {
-		return nil, fmt.Errorf("Source repository not found: %s/%s", org, repo)
-	}
-
-	if srcRepo.Parent == nil {
-		return nil, fmt.Errorf("Source has no parents: %s/%s", org, repo)
-	}
-
-	return srcRepo, nil
-}
-
-func createEmptyBranch(git common.Git, PackageName, Branch string) {
-	git.GitExecOrPanic(PackageName, "checkout", "--detach")
-	git.GitExec(PackageName, "branch", "-D", Branch)
-	git.GitExecOrPanic(PackageName, "checkout", "-f", "--orphan", Branch)
-	git.GitExecOrPanic(PackageName, "rm", "-rf", ".")
-	git.GitExecOrPanic(PackageName, "commit", "--allow-empty", "-m", "Initial empty branch")
-}
-
-type TimelineInterface interface {
-	FindPullRequestReferences(org, repo string, idx int64, creator []string) []*models.TimelineComment
-}
-
-type Timeline []*models.TimelineComment
-
-func (timeline *Timeline) FindIssuePullRequestRererences(org, repo string, idx int64, creator []string) []*models.TimelineComment {
-	ret := make([]*models.TimelineComment, 0, 1)
-
-	for _, t := range *timeline {
-		if t.Type == common.TimelineCommentType_PullRequestRef &&
-			t.RefIssue != nil &&
-			t.RefIssue.Repository.Owner == org &&
-			t.RefIssue.Repository.Name == repo &&
-			(idx == 0 || t.RefIssue.Index == idx) &&
-			(len(creator) == 0 || slices.Contains(creator, t.User.UserName)) {
-
-			ret = append(ret, t)
-		}
-	}
-	return ret
-}
-
-type IssueProcessorInterface interface {
-	IsAddIssue() bool
-	IsRmIssue() bool
-	GetTargetBranch() string
-}
-
-type IssueProcessor struct {
-	issue *models.Issue
-
-	IssueTimeline Timeline
-	TargetBranch  string
-}
-
-func (i *IssueProcessor) GetTargetBranch() string {
-	const BranchPrefix = "refs/heads/"
-	branch := i.issue.Ref
-
-	if branch, found := strings.CutPrefix(branch, BranchPrefix); found {
-		return branch
-	} else {
-		common.LogDebug("Invalid branch specified:", branch, ". Using default.")
-		branch = ""
-	}
-
-	return branch
-}
-
-func ProcessIssue(issue *models.Issue, configs common.AutogitConfigs) error {
-	i := &IssueProcessor{issue: issue}
-	return i.ProcessIssue(configs)
-}
-
-func (i *IssueProcessor) IsAddIssue() bool {
-	if i == nil || i.issue == nil {
-		return false
-	}
-
-	title := i.issue.Title
-	return len(title) > 5 && strings.EqualFold(title[0:5], "[ADD]")
-}
-
-func (i *IssueProcessor) IsRmIssue() bool {
-	if i == nil || i.issue == nil {
-		return false
-	}
-
-	title := i.issue.Title
-	return len(title) > 4 && strings.EqualFold(title[0:4], "[RM]")
-}
-
-func (i *IssueProcessor) ProcessAddIssue(config *common.AutogitConfig) error {
-	issue := i.issue
-
-	org := issue.Repository.Owner
-	repo := issue.Repository.Name
-	//	idx := issue.Index
-
-	// we need "New Package" label and "Approval Required" label, unless already approved
-	// either via Label "Approved" or via review comment.
-	NewIssues := common.FindNewReposInIssueBody(issue.Body)
-	if NewIssues == nil {
-		common.LogDebug("No new repos found in issue body")
-		return nil
-	}
-
-	git, err := GitHandler.CreateGitHandler(config.Organization)
-	if err != nil {
-		return err
-	}
-	defer git.Close()
-
-	for _, nr := range NewIssues.Repos {
-		common.LogDebug(" - Processing new repository src:", nr.Organization+"/"+nr.PackageName+"#"+nr.Branch)
-
-		targetRepo, err := Gitea.GetRepository(config.Organization, nr.PackageName)
-		if err != nil {
-			return err
-		}
-
-		if targetRepo == nil {
-			common.LogInfo(" - Repository", config.Organization+"/"+nr.PackageName, "does not exist. Labeling issue.")
-			if !common.IsDryRun && issue.State == "open" {
-				Gitea.SetLabels(org, repo, issue.Index, []string{config.Label(common.Label_NewRepository)})
-			}
-			common.LogDebug(" # Done for now with this repo")
-			continue
-		}
-
-		// check if we already have created a PR here
-		// TODO, we need to filter by project config permissions of target project, not just assume bot here.
-		users := []string{CurrentUser.UserName}
-		prs := i.IssueTimeline.FindIssuePullRequestRererences(config.Organization, nr.PackageName, 0, users)
-		for _, t := range prs {
-			pr, err := Gitea.GetPullRequest(config.Organization, nr.PackageName, t.RefIssue.Index)
-			if err != nil {
-				common.LogError("Failed to fetch PR", common.PRtoString(pr), ":", err)
-			}
-
-			if issue.State == "open" {
-				// PR already created, we just need to update it now
-				common.LogInfo("Update PR ", common.PRtoString(pr), "only... Nothing to do now")
-				return nil
-			}
-
-			// so, issue is closed .... close associated package PR
-			_, err = Gitea.UpdateIssue(config.Organization, nr.PackageName, t.RefIssue.Index, &models.EditIssueOption{State: "closed"})
-			if err != nil {
-				common.LogError("Failed to close associated PR", common.PRtoString(pr), ":", err)
-			}
-
-			// remove branch if it's a new repository.
-			return err
-		}
-
-		srcRepo, err := FindSourceRepository(nr.Organization, nr.Repository)
-		if err != nil {
-			continue
-		}
-
-		if len(nr.Branch) == 0 {
-			nr.Branch = srcRepo.DefaultBranch
-		}
-
-		srcRemoteName, err := git.GitClone(nr.PackageName, nr.Branch, srcRepo.SSHURL)
-		if err != nil {
-			return err
-		}
-		remoteName, err := git.GitClone(nr.PackageName, nr.Branch, targetRepo.SSHURL)
-		if err != nil {
-			return err
-		}
-
-		// Check that fork/parent repository relationship exists
-		if srcRepo.Parent.Name != targetRepo.Name || srcRepo.Parent.Owner.UserName != targetRepo.Owner.UserName {
-			common.LogError("Source repository is not fork of the Target repository. Fork of:", srcRepo.Parent.Owner.UserName+"/"+srcRepo.Parent.Name)
-			continue
-		}
-
-		srcBranch := nr.Branch
-		if srcBranch == "" {
-			srcBranch = srcRepo.DefaultBranch
-		}
-
-		// We are ready to setup a pending PR.
-		//   1. empty target branch with empty commit, this will be discarded no merge
-		//   2. create PR from source to target
-		//      a) if source is not branch, create a source branch in target repo that contains the relevant commit
-		SourceCommitList := common.SplitLines(git.GitExecWithOutputOrPanic(nr.PackageName, "rev-list", "--first-parent", srcRemoteName+"/"+nr.Branch))
-		CommitLength := len(SourceCommitList)
-		SourceCommitId := SourceCommitList[CommitLength-1]
-		if CommitLength > 20 {
-			SourceCommitId = SourceCommitList[20]
-		}
-
-		if CommitLength < 2 {
-			// only 1 commit, then we need empty branch on target
-			if dl, err := git.GitDirectoryContentList(nr.PackageName, nr.Branch); err == nil && len(dl) > 0 {
-				createEmptyBranch(git, nr.PackageName, nr.Branch)
-			}
-		} else {
-			git.GitExecOrPanic(nr.PackageName, "checkout", "-B", nr.Branch, SourceCommitId)
-		}
-		if !common.IsDryRun {
-			git.GitExecOrPanic(nr.PackageName, "push", "-f", remoteName, nr.Branch)
-		}
-
-		head := nr.Organization + ":" + srcBranch
-		isBranch := false
-		// Hash can be branch name! Check if it's a branch or tag on the remote
-		out, err := git.GitExecWithOutput(nr.PackageName, "ls-remote", "--heads", srcRepo.SSHURL, srcBranch)
-		if err == nil && strings.Contains(out, "refs/heads/"+srcBranch) {
-			isBranch = true
-		}
-
-		if !isBranch {
-			tempBranch := fmt.Sprintf("new_package_%d_%s", issue.Index, nr.PackageName)
-			// Re-clone or use existing if branch check was done above
-			remoteName, err := git.GitClone(nr.PackageName, srcBranch, targetRepo.SSHURL)
-			if err != nil {
-				return err
-			}
-
-			git.GitExecOrPanic(nr.PackageName, "remote", "add", "source", srcRepo.SSHURL)
-			git.GitExecOrPanic(nr.PackageName, "fetch", "source", srcBranch)
-			git.GitExecOrPanic(nr.PackageName, "checkout", "-B", tempBranch, "FETCH_HEAD")
-			if !common.IsDryRun {
-				git.GitExecOrPanic(nr.PackageName, "push", "-f", remoteName, tempBranch)
-			}
-			head = tempBranch
-		}
-
-		title := fmt.Sprintf("Add package %s", nr.PackageName)
-		prjGitOrg, prjGitRepo, _ := config.GetPrjGit()
-		body := fmt.Sprintf("See issue %s/%s#%d", prjGitOrg, prjGitRepo, issue.Index)
-		br := i.TargetBranch
-		if len(br) == 0 {
-			br = targetRepo.DefaultBranch
-		}
-		pr, err, isNew := Gitea.CreatePullRequestIfNotExist(targetRepo, head, br, title, body)
-		if err != nil {
-			common.LogError(targetRepo.Name, head, i.TargetBranch, title, body)
-			return err
-		}
-		if !isNew && (pr.Body != body || !pr.AllowMaintainerEdit) {
-			Gitea.UpdatePullRequest(pr.Base.Repo.Owner.UserName, pr.Base.Repo.Name, pr.Index, &models.EditPullRequestOption{
-				AllowMaintainerEdit: true,
-				Body:                body,
-			})
-		}
-
-		if isNew {
-			if _, err := Gitea.SetLabels(config.Organization, nr.PackageName, pr.Index, []string{config.Label(common.Label_NewRepository)}); err != nil {
-				common.LogError("Failed to set label:", common.Label_NewRepository, err)
-			}
-		}
-	}
-
-	return nil
-}
-
-func (i *IssueProcessor) ProcessIssue(configs common.AutogitConfigs) error {
-	issue := i.issue
-
-	org := issue.Repository.Owner
-	repo := issue.Repository.Name
-	idx := issue.Index
-
-	//	out, _ := json.MarshalIndent(issue, "", "   ")
-	//	common.LogDebug(string(out))
-
-	var err error
-	i.IssueTimeline, err = Gitea.GetTimeline(org, repo, idx)
-	if err != nil {
-		common.LogError("  timeline fetch failed:", err)
-		return err
-	}
-
-	i.TargetBranch = i.GetTargetBranch()
-	config := configs.GetPrjGitConfig(org, repo, i.TargetBranch)
-	if config == nil {
-		return fmt.Errorf("Cannot find config for %s/%s#%s", org, repo, i.TargetBranch)
-	}
-	common.LogDebug("issue processing:", common.IssueToString(issue), "@", i.TargetBranch)
-
-	if i.IsAddIssue() {
-		i.ProcessAddIssue(config)
-	} else if i.IsRmIssue() {
-		// to remove a package, no approval is required. This should happen via
-		// project git PR reviews
-	} else {
-		common.LogError("Non-standard issue created. Ignoring", common.IssueToString(issue))
-		return nil
-	}
-
-	return nil
-}

workflow-pr/issue_processor_test.go

@@ -1,523 +0,0 @@
-package main
-
-import (
-	"go.uber.org/mock/gomock"
-	"src.opensuse.org/autogits/common"
-	"src.opensuse.org/autogits/common/gitea-generated/models"
-	mock_common "src.opensuse.org/autogits/common/mock"
-	"testing"
-)
-
-func TestProcessIssue_Add(t *testing.T) {
-	ctl := NewController(t)
-	defer ctl.Finish()
-	gitea := mock_common.NewMockGitea(ctl)
-	Gitea = gitea
-	common.IsDryRun = false
-	gitea.EXPECT().GetTimeline(gomock.Any(), gomock.Any(), gomock.Not(int64(999))).Return([]*models.TimelineComment{}, nil).AnyTimes()
-	CurrentUser = &models.User{UserName: "bot-user"}
-	config := &common.AutogitConfig{
-		Organization:   "target-org",
-		GitProjectName: "test-org/test-prj#main",
-	}
-	configs := []*common.AutogitConfig{config}
-	issue := &models.Issue{
-		Title: "[ADD] pkg1",
-		Body:  "src-org/pkg1#master",
-		Index: 123,
-		Repository: &models.RepositoryMeta{
-			Owner: "test-org",
-			Name:  "test-prj",
-		},
-		Ref:   "refs/heads/main",
-		State: "open",
-	}
-	expectedBody := "See issue test-org/test-prj#123"
-	t.Run("Repository does not exist - labels issue", func(t *testing.T) {
-		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
-		GitHandler = mockGitGen
-		mockGit := mock_common.NewMockGit(ctl)
-		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
-		mockGit.EXPECT().Close().Return(nil)
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(nil, nil)
-		gitea.EXPECT().SetLabels("test-org", "test-prj", int64(123), []string{"new/New Repository"}).Return(nil, nil)
-		err := ProcessIssue(issue, configs)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-	t.Run("Source is SHA - creates temp branch in target", func(t *testing.T) {
-		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
-		GitHandler = mockGitGen
-		mockGit := mock_common.NewMockGit(ctl)
-		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
-		mockGit.EXPECT().Close().Return(nil)
-		targetRepo := &models.Repository{
-			Name:   "pkg1",
-			SSHURL: "target-ssh-url",
-			Owner:  &models.User{UserName: "target-org"},
-		}
-		srcRepo := &models.Repository{
-			Name:          "pkg1",
-			SSHURL:        "src-ssh-url",
-			DefaultBranch: "master",
-			Owner:         &models.User{UserName: "src-org"},
-			Parent: &models.Repository{
-				Name:  "pkg1",
-				Owner: &models.User{UserName: "target-org"},
-			},
-		}
-		sha := "abcdef0123456789abcdef0123456789abcdef01"
-		issueSHA := &models.Issue{
-			Title:      "[ADD] pkg1",
-			Body:       "src-org/pkg1#" + sha,
-			Index:      123,
-			Repository: &models.RepositoryMeta{Owner: "test-org", Name: "test-prj"},
-			Ref:        "refs/heads/main",
-			State:      "open",
-		}
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
-		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
-		mockGit.EXPECT().GitClone("pkg1", sha, "src-ssh-url").Return("src-remote", nil)
-		mockGit.EXPECT().GitClone("pkg1", sha, "target-ssh-url").Return("origin", nil)
-		// Source commit list and reset logic
-		mockGit.EXPECT().GitExecWithOutputOrPanic("pkg1", "rev-list", "--first-parent", "src-remote/"+sha).Return(sha + "\n" + "parent-sha")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-B", sha, "parent-sha")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", sha)
-		mockGit.EXPECT().GitExecWithOutput("pkg1", "ls-remote", "--heads", "src-ssh-url", sha).Return("", nil)
-		// SHA source logic (creates temp branch)
-		tempBranch := "new_package_123_pkg1"
-		mockGit.EXPECT().GitClone("pkg1", sha, "target-ssh-url").Return("origin", nil)
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "remote", "add", "source", "src-ssh-url")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "fetch", "source", sha)
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-B", tempBranch, "FETCH_HEAD")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", tempBranch)
-		// PR creation using temp branch
-		pr := &models.PullRequest{
-			Index: 456,
-			Body:  expectedBody,
-			Base: &models.PRBranchInfo{
-				Repo: targetRepo,
-			},
-		}
-		gitea.EXPECT().CreatePullRequestIfNotExist(targetRepo, tempBranch, "main", gomock.Any(), gomock.Any()).Return(pr, nil, true)
-		gitea.EXPECT().SetLabels("target-org", "pkg1", int64(456), []string{"new/New Repository"}).Return(nil, nil)
-		err := ProcessIssue(issueSHA, configs)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-	t.Run("Repository exists - continue processing and create PR", func(t *testing.T) {
-		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
-		GitHandler = mockGitGen
-		mockGit := mock_common.NewMockGit(ctl)
-		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
-		mockGit.EXPECT().Close().Return(nil)
-		targetRepo := &models.Repository{
-			Name:   "pkg1",
-			SSHURL: "target-ssh-url",
-			Owner:  &models.User{UserName: "target-org"},
-		}
-		srcRepo := &models.Repository{
-			Name:          "pkg1",
-			SSHURL:        "src-ssh-url",
-			DefaultBranch: "master",
-			Owner:         &models.User{UserName: "src-org"},
-			Parent: &models.Repository{
-				Name:  "pkg1",
-				Owner: &models.User{UserName: "target-org"},
-			},
-		}
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
-		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
-		mockGit.EXPECT().GitClone("pkg1", "master", "src-ssh-url").Return("src-remote", nil)
-		mockGit.EXPECT().GitClone("pkg1", "master", "target-ssh-url").Return("origin", nil)
-		// Commit list logic
-		mockGit.EXPECT().GitExecWithOutputOrPanic("pkg1", "rev-list", "--first-parent", "src-remote/master").Return("sha1\nsha2")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-B", "master", "sha2")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", "master")
-		// Check if source is a branch via ls-remote
-		mockGit.EXPECT().GitExecWithOutput("pkg1", "ls-remote", "--heads", "src-ssh-url", "master").Return("sha1 refs/heads/master", nil)
-		// PR creation
-		pr := &models.PullRequest{
-			Index: 456,
-			Body:  expectedBody,
-			Base: &models.PRBranchInfo{
-				Repo: targetRepo,
-			},
-		}
-		gitea.EXPECT().CreatePullRequestIfNotExist(targetRepo, "src-org:master", "main", gomock.Any(), gomock.Any()).Return(pr, nil, true)
-		gitea.EXPECT().SetLabels("target-org", "pkg1", int64(456), []string{"new/New Repository"}).Return(nil, nil)
-		err := ProcessIssue(issue, configs)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-	t.Run("Source repository is not fork of target repository - aborts", func(t *testing.T) {
-		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
-		GitHandler = mockGitGen
-		mockGit := mock_common.NewMockGit(ctl)
-		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
-		mockGit.EXPECT().Close().Return(nil)
-		targetRepo := &models.Repository{
-			Name:   "pkg1",
-			SSHURL: "target-ssh-url",
-			Owner:  &models.User{UserName: "target-org"},
-		}
-		srcRepo := &models.Repository{
-			Name:   "pkg1",
-			Owner:  &models.User{UserName: "src-org"},
-			SSHURL: "src-ssh-url",
-			Parent: &models.Repository{
-				Name:  "other-repo",
-				Owner: &models.User{UserName: "other-org"},
-			},
-		}
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
-		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
-		mockGit.EXPECT().GitClone("pkg1", "master", "src-ssh-url").Return("src-remote", nil)
-		mockGit.EXPECT().GitClone("pkg1", "master", "target-ssh-url").Return("origin", nil)
-		err := ProcessIssue(issue, configs)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-	t.Run("Source repository is fork of target repository - proceeds", func(t *testing.T) {
-		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
-		GitHandler = mockGitGen
-		mockGit := mock_common.NewMockGit(ctl)
-		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
-		mockGit.EXPECT().Close().Return(nil)
-		targetRepo := &models.Repository{
-			Name:   "pkg1",
-			Owner:  &models.User{UserName: "target-org"},
-			SSHURL: "target-ssh-url",
-		}
-		srcRepo := &models.Repository{
-			Name:   "pkg1",
-			Owner:  &models.User{UserName: "src-org"},
-			SSHURL: "src-ssh-url",
-			Parent: &models.Repository{
-				Name:  "pkg1",
-				Owner: &models.User{UserName: "target-org"},
-			},
-			DefaultBranch: "master",
-		}
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
-		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
-		mockGit.EXPECT().GitClone("pkg1", "master", "src-ssh-url").Return("src-remote", nil)
-		mockGit.EXPECT().GitClone("pkg1", "master", "target-ssh-url").Return("origin", nil)
-		mockGit.EXPECT().GitExecWithOutputOrPanic("pkg1", "rev-list", "--first-parent", "src-remote/master").Return("sha1\nsha2")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-B", "master", "sha2")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", "master")
-		mockGit.EXPECT().GitExecWithOutput("pkg1", "ls-remote", "--heads", "src-ssh-url", "master").Return("sha1 refs/heads/master", nil)
-		pr := &models.PullRequest{
-			Index: 456,
-			Body:  expectedBody,
-			Base: &models.PRBranchInfo{
-				Repo: targetRepo,
-			},
-		}
-		gitea.EXPECT().CreatePullRequestIfNotExist(targetRepo, "src-org:master", "main", gomock.Any(), gomock.Any()).Return(pr, nil, false)
-		gitea.EXPECT().UpdatePullRequest("target-org", "pkg1", int64(456), gomock.Any())
-		err := ProcessIssue(issue, configs)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-	t.Run("Source repository has no parent (not a fork) - aborts", func(t *testing.T) {
-		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
-		GitHandler = mockGitGen
-		mockGit := mock_common.NewMockGit(ctl)
-		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
-		mockGit.EXPECT().Close().Return(nil)
-		targetRepo := &models.Repository{
-			Name:   "pkg1",
-			Owner:  &models.User{UserName: "target-org"},
-			SSHURL: "target-ssh-url",
-		}
-		srcRepo := &models.Repository{
-			Name:          "pkg1",
-			Owner:         &models.User{UserName: "src-org"},
-			SSHURL:        "src-ssh-url",
-			Parent:        nil,
-			DefaultBranch: "master",
-		}
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
-		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
-		err := ProcessIssue(issue, configs)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-	t.Run("Target branch missing - creates orphan branch", func(t *testing.T) {
-		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
-		GitHandler = mockGitGen
-		mockGit := mock_common.NewMockGit(ctl)
-		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
-		mockGit.EXPECT().Close().Return(nil)
-		targetRepo := &models.Repository{
-			Name:   "pkg1",
-			SSHURL: "target-ssh-url",
-			Owner:  &models.User{UserName: "target-org"},
-		}
-		srcRepo := &models.Repository{
-			Name:          "pkg1",
-			SSHURL:        "src-ssh-url",
-			DefaultBranch: "master",
-			Owner:         &models.User{UserName: "src-org"},
-			Parent: &models.Repository{
-				Name:  "pkg1",
-				Owner: &models.User{UserName: "target-org"},
-			},
-		}
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
-		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
-		mockGit.EXPECT().GitClone("pkg1", "master", "src-ssh-url").Return("src-remote", nil)
-		mockGit.EXPECT().GitClone("pkg1", "master", "target-ssh-url").Return("origin", nil)
-		// Branch check - rev-list works but says only 1 commit
-		mockGit.EXPECT().GitExecWithOutputOrPanic("pkg1", "rev-list", "--first-parent", "src-remote/master").Return("sha1")
-		// Orphan branch creation via createEmptyBranch
-		mockGit.EXPECT().GitDirectoryContentList("pkg1", "master").Return(map[string]string{"file": "sha"}, nil)
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "--detach")
-		mockGit.EXPECT().GitExec("pkg1", "branch", "-D", "master")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-f", "--orphan", "master")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "rm", "-rf", ".")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "commit", "--allow-empty", "-m", "Initial empty branch")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", "master")
-		mockGit.EXPECT().GitExecWithOutput("pkg1", "ls-remote", "--heads", "src-ssh-url", "master").Return("sha1 refs/heads/master", nil)
-		// PR creation
-		pr := &models.PullRequest{
-			Index: 456,
-			Body:  expectedBody,
-			Base: &models.PRBranchInfo{
-				Repo: targetRepo,
-			},
-		}
-		gitea.EXPECT().CreatePullRequestIfNotExist(targetRepo, "src-org:master", "main", gomock.Any(), gomock.Any()).Return(pr, nil, true)
-		gitea.EXPECT().SetLabels("target-org", "pkg1", int64(456), []string{"new/New Repository"}).Return(nil, nil)
-		err := ProcessIssue(issue, configs)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-	t.Run("Config not found", func(t *testing.T) {
-		issueNoConfig := &models.Issue{
-			Title: "[ADD] pkg1",
-			Body:  "src-org/pkg1#master",
-			Index: 123,
-			Repository: &models.RepositoryMeta{
-				Owner: "other-org",
-				Name:  "other-prj",
-			},
-			Ref:   "refs/heads/main",
-			State: "open",
-		}
-		err := ProcessIssue(issueNoConfig, configs)
-		if err == nil || err.Error() != "Cannot find config for other-org/other-prj#main" {
-			t.Errorf("Expected config not found error, got %v", err)
-		}
-	})
-	t.Run("No repos in body", func(t *testing.T) {
-		err := ProcessIssue(&models.Issue{
-			Title: "[ADD] pkg1",
-			Body:  "nothing here",
-			Ref:   "refs/heads/main",
-			Repository: &models.RepositoryMeta{
-				Owner: "test-org",
-				Name:  "test-prj",
-			},
-			State: "open",
-		}, configs)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-	t.Run("Source SHA update - updates existing temp branch", func(t *testing.T) {
-		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
-		GitHandler = mockGitGen
-		mockGit := mock_common.NewMockGit(ctl)
-		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil).Times(2)
-		mockGit.EXPECT().Close().Return(nil).Times(2)
-		targetRepo := &models.Repository{
-			Name:   "pkg1",
-			SSHURL: "target-ssh-url",
-			Owner:  &models.User{UserName: "target-org"},
-		}
-		srcRepo := &models.Repository{
-			Name:          "pkg1",
-			SSHURL:        "src-ssh-url",
-			DefaultBranch: "master",
-			Owner:         &models.User{UserName: "src-org"},
-			Parent: &models.Repository{
-				Name:  "pkg1",
-				Owner: &models.User{UserName: "target-org"},
-			},
-		}
-		sha1 := "abcdef0123456789abcdef0123456789abcdef01"
-		issue1 := &models.Issue{
-			Title:      "[ADD] pkg1",
-			Body:       "src-org/pkg1#" + sha1,
-			Index:      123,
-			Repository: &models.RepositoryMeta{Owner: "test-org", Name: "test-prj"},
-			Ref:        "refs/heads/main",
-			State:      "open",
-		}
-		// First call expectations
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
-		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
-		mockGit.EXPECT().GitClone("pkg1", sha1, "src-ssh-url").Return("src-remote", nil)
-		mockGit.EXPECT().GitClone("pkg1", sha1, "target-ssh-url").Return("origin", nil)
-		mockGit.EXPECT().GitExecWithOutputOrPanic("pkg1", "rev-list", "--first-parent", "src-remote/"+sha1).Return(sha1 + "\n" + "parent")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-B", sha1, "parent")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", sha1)
-		mockGit.EXPECT().GitExecWithOutput("pkg1", "ls-remote", "--heads", "src-ssh-url", sha1).Return("", nil)
-		tempBranch := "new_package_123_pkg1"
-		mockGit.EXPECT().GitClone("pkg1", sha1, "target-ssh-url").Return("origin", nil)
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "remote", "add", "source", "src-ssh-url")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "fetch", "source", sha1)
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-B", tempBranch, "FETCH_HEAD")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", tempBranch)
-		pr := &models.PullRequest{
-			Index: 456,
-			Body:  expectedBody,
-			Base: &models.PRBranchInfo{
-				Repo: targetRepo,
-			},
-		}
-		gitea.EXPECT().CreatePullRequestIfNotExist(targetRepo, tempBranch, "main", gomock.Any(), gomock.Any()).Return(pr, nil, true)
-		gitea.EXPECT().SetLabels("target-org", "pkg1", int64(456), []string{"new/New Repository"}).Return(nil, nil)
-		err := ProcessIssue(issue1, configs)
-		if err != nil {
-			t.Errorf("First call failed: %v", err)
-		}
-		// Second call with different SHA
-		sha2 := "0123456789abcdef0123456789abcdef01234567"
-		issue2 := &models.Issue{
-			Title:      "[ADD] pkg1",
-			Body:       "src-org/pkg1#" + sha2,
-			Index:      123,
-			Repository: &models.RepositoryMeta{Owner: "test-org", Name: "test-prj"},
-			Ref:        "refs/heads/main",
-			State:      "open",
-		}
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
-		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
-		mockGit.EXPECT().GitClone("pkg1", sha2, "src-ssh-url").Return("src-remote", nil)
-		mockGit.EXPECT().GitClone("pkg1", sha2, "target-ssh-url").Return("origin", nil)
-		mockGit.EXPECT().GitExecWithOutputOrPanic("pkg1", "rev-list", "--first-parent", "src-remote/"+sha2).Return(sha2 + "\n" + "parent")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-B", sha2, "parent")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", sha2)
-		mockGit.EXPECT().GitExecWithOutput("pkg1", "ls-remote", "--heads", "src-ssh-url", sha2).Return("", nil)
-		mockGit.EXPECT().GitClone("pkg1", sha2, "target-ssh-url").Return("origin", nil)
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "remote", "add", "source", "src-ssh-url")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "fetch", "source", sha2)
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-B", tempBranch, "FETCH_HEAD")
-		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", tempBranch)
-		// CreatePullRequestIfNotExist should be called with same tempBranch, return existing PR
-		gitea.EXPECT().CreatePullRequestIfNotExist(targetRepo, tempBranch, "main", gomock.Any(), gomock.Any()).Return(pr, nil, false)
-		gitea.EXPECT().UpdatePullRequest("target-org", "pkg1", int64(456), gomock.Any())
-		err = ProcessIssue(issue2, configs)
-		if err != nil {
-			t.Errorf("Second call failed: %v", err)
-		}
-	})
-	t.Run("PR already exists and issue is open - does nothing", func(t *testing.T) {
-		issue999 := &models.Issue{
-			Title: "[ADD] pkg1",
-			Body:  "src-org/pkg1#master",
-			Index: 999,
-			Repository: &models.RepositoryMeta{
-				Owner: "test-org",
-				Name:  "test-prj",
-			},
-			Ref:   "refs/heads/main",
-			State: "open",
-		}
-		timeline := []*models.TimelineComment{
-			{
-				Type: common.TimelineCommentType_PullRequestRef,
-				RefIssue: &models.Issue{
-					Index: 456,
-					Repository: &models.RepositoryMeta{
-						Owner: "target-org",
-						Name:  "pkg1",
-					},
-				},
-				User: &models.User{UserName: "bot-user"},
-			},
-		}
-		// We need to override the default GetTimeline mock
-		gitea.EXPECT().GetTimeline("test-org", "test-prj", int64(999)).Return(timeline, nil)
-		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
-		GitHandler = mockGitGen
-		mockGit := mock_common.NewMockGit(ctl)
-		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
-		mockGit.EXPECT().Close().Return(nil)
-		targetRepo := &models.Repository{
-			Name:  "pkg1",
-			Owner: &models.User{UserName: "target-org"},
-		}
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
-		pr := &models.PullRequest{
-			Index: 456,
-			Base: &models.PRBranchInfo{
-				Repo: targetRepo,
-			},
-		}
-		gitea.EXPECT().GetPullRequest("target-org", "pkg1", int64(456)).Return(pr, nil)
-		err := ProcessIssue(issue999, configs)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-	t.Run("PR already exists and issue is closed - closes PR", func(t *testing.T) {
-		closedIssue := &models.Issue{
-			Title: "[ADD] pkg1",
-			Body:  "src-org/pkg1#master",
-			Index: 999,
-			Repository: &models.RepositoryMeta{
-				Owner: "test-org",
-				Name:  "test-prj",
-			},
-			Ref:   "refs/heads/main",
-			State: "closed",
-		}
-		timeline := []*models.TimelineComment{
-			{
-				Type: common.TimelineCommentType_PullRequestRef,
-				RefIssue: &models.Issue{
-					Index: 456,
-					Repository: &models.RepositoryMeta{
-						Owner: "target-org",
-						Name:  "pkg1",
-					},
-				},
-				User: &models.User{UserName: "bot-user"},
-			},
-		}
-		gitea.EXPECT().GetTimeline("test-org", "test-prj", int64(999)).Return(timeline, nil)
-		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
-		GitHandler = mockGitGen
-		mockGit := mock_common.NewMockGit(ctl)
-		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
-		mockGit.EXPECT().Close().Return(nil)
-		targetRepo := &models.Repository{
-			Name:  "pkg1",
-			Owner: &models.User{UserName: "target-org"},
-		}
-		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
-		pr := &models.PullRequest{
-			Index: 456,
-			Base: &models.PRBranchInfo{
-				Repo: targetRepo,
-			},
-		}
-		gitea.EXPECT().GetPullRequest("target-org", "pkg1", int64(456)).Return(pr, nil)
-		gitea.EXPECT().UpdateIssue("target-org", "pkg1", int64(456), gomock.Any()).Return(nil, nil)
-		err := ProcessIssue(closedIssue, configs)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-}

workflow-pr/main.go

@@ -151,10 +151,7 @@ func main() {
 					common.LogError("PR processor returned error", err)
 				}
 			} else if issue, err := Gitea.GetIssue(org, repo, num); err == nil && issue != nil {
-				processor := &IssueProcessor{
-					issue: issue,
-				}
-				if err = processor.ProcessIssue(configs); err != nil {
+				if err = ProcessIssue(issue, configs); err != nil {
 					common.LogError("issue processor returned error:", err)
 				}
 			} else {

workflow-pr/main_test.go

@@ -14,7 +14,6 @@ import (
 )
 
 func TestProjectBranchName(t *testing.T) {
-	common.SetTestLogger(t)
 	branchName := prGitBranchNameForPR("testingRepo", 10)
 	if branchName != "PR_testingRepo#10" {
 		t.Error("Unexpected branch name:", branchName)
@@ -22,7 +21,6 @@ func TestProjectBranchName(t *testing.T) {
 }
 
 func TestUpdatePrBranch(t *testing.T) {
-	common.SetTestLogger(t)
 	var buf bytes.Buffer
 	origLogger := log.Writer()
 	log.SetOutput(&buf)
@@ -60,7 +58,6 @@ func TestUpdatePrBranch(t *testing.T) {
 }
 
 func TestCreatePrBranch(t *testing.T) {
-	common.SetTestLogger(t)
 	var buf bytes.Buffer
 	origLogger := log.Writer()
 	log.SetOutput(&buf)

workflow-pr/pr_processor.go

@@ -294,9 +294,6 @@ func (pr *PRProcessor) UpdatePrjGitPR(prset *common.PRSet) error {
 
 	git := pr.git
 	if len(prset.PRs) == 1 {
-		if len(PrjGitPR.RemoteName) == 0 {
-			PrjGitPR.RemoteName, _ = git.GitClone(common.DefaultGitPrj, "", PrjGitPR.PR.Base.Repo.SSHURL)
-		}
 		git.GitExecOrPanic(common.DefaultGitPrj, "fetch", PrjGitPR.RemoteName, PrjGitPR.PR.Head.Sha)
 		common.LogDebug("Only project git in PR. Nothing to update.")
 		return nil
@@ -508,7 +505,7 @@ func (pr *PRProcessor) Process(req *models.PullRequest) error {
 	// make sure that prjgit is consistent and only submodules that are to be *updated*
 	// reset anything that changed that is not part of the prset
 	// package removals/additions are *not* counted here
-
+	org, repo, branch := config.GetPrjGit()
 	// TODO: this is broken...
 	if pr, err := prset.GetPrjGitPR(); err == nil && false {
 		common.LogDebug("Submodule parse begin")
@@ -557,7 +554,7 @@ func (pr *PRProcessor) Process(req *models.PullRequest) error {
 	} else {
 		common.LogInfo("* No prjgit")
 	}
-	maintainers, err := common.FetchProjectMaintainershipData(Gitea, config)
+	maintainers, err := common.FetchProjectMaintainershipData(Gitea, org, repo, branch)
 	if err != nil {
 		return err
 	}
@@ -642,6 +639,186 @@ func ProcesPullRequest(pr *models.PullRequest, configs []*common.AutogitConfig)
 	return PRProcessor.Process(pr)
 }
 
+func ProcessIssue(issue *models.Issue, configs []*common.AutogitConfig) error {
+	title := issue.Title
+	/*
+		org := issue.Repository.Owner
+		repo := issue.Repository.Name
+		idx := issue.Index
+	*/
+	const BranchPrefix = "refs/heads/"
+	branch := issue.Ref
+
+	if strings.HasPrefix(branch, BranchPrefix) {
+		branch = strings.TrimPrefix(branch, BranchPrefix)
+	} else {
+		common.LogDebug("Invalid branch specified:", branch, ". Using default.")
+		branch = ""
+	}
+
+	//	out, _ := json.MarshalIndent(issue, "", "   ")
+	//	common.LogDebug(string(out))
+	common.LogDebug("issue processing:", common.IssueToString(issue), "@", branch)
+
+	if len(title) > 5 && strings.EqualFold(title[0:5], "[ADD]") {
+		// we need "New Package" label and "Approval Required" label, unless already approved
+		// either via Label "Approved" or via review comment.
+		NewIssues := common.FindNewReposInIssueBody(issue.Body)
+		if NewIssues == nil {
+			common.LogDebug("No new repos found in issue body")
+			return nil
+		}
+
+		org := issue.Repository.Owner
+		repo := issue.Repository.Name
+
+		config := common.AutogitConfigs(configs).GetPrjGitConfig(org, repo, branch)
+		if config == nil {
+			return fmt.Errorf("Cannot find config for %s/%s#%s", org, repo, branch)
+		}
+
+		if len(branch) == 0 {
+			branch = config.Branch
+		}
+
+		git, err := GitHandler.CreateGitHandler(config.Organization)
+		if err != nil {
+			return err
+		}
+		defer git.Close()
+
+		for _, nr := range NewIssues.Repos {
+			common.LogDebug(" - Processing new repository src:", nr.Organization+"/"+nr.PackageName+"#"+nr.Branch)
+			targetRepo, err := Gitea.GetRepository(config.Organization, nr.PackageName)
+			if err != nil {
+				return err
+			}
+
+			if targetRepo == nil {
+				common.LogInfo(" - Repository", config.Organization+"/"+nr.PackageName, "does not exist. Labeling issue.")
+				if !common.IsDryRun {
+					Gitea.SetLabels(org, repo, issue.Index, []string{config.Label(common.Label_NewRepository)})
+				}
+				common.LogDebug(" # Done for now with this repo")
+				continue
+			}
+
+			srcRepo, err := Gitea.GetRepository(nr.Organization, nr.Repository)
+			if err != nil {
+				return err
+			}
+			if srcRepo == nil {
+				common.LogError("Source repository not found:", nr.Organization+"/"+nr.Repository)
+				continue
+			}
+
+			if srcRepo.Parent == nil {
+				common.LogError("Source has no parents.")
+				continue
+			}
+
+			if len(nr.Branch) == 0 {
+				nr.Branch = srcRepo.DefaultBranch
+			}
+
+			remoteName, err := git.GitClone(nr.PackageName, nr.Branch, targetRepo.SSHURL)
+			if err != nil {
+				return err
+			}
+
+			// Check that fork/parent repository relationship exists
+			if srcRepo.Parent.Name != targetRepo.Name || srcRepo.Parent.Owner.UserName != targetRepo.Owner.UserName {
+				common.LogError("Source repository is not fork of the Target repository. Fork of:", srcRepo.Parent.Owner.UserName+"/"+srcRepo.Parent.Name)
+				continue
+			}
+
+			srcBranch := nr.Branch
+			if srcBranch == "" {
+				srcBranch = srcRepo.DefaultBranch
+			}
+
+			// We are ready to setup a pending PR.
+			//   1. empty target branch with empty commit, this will be discarded no merge
+			//   2. create PR from source to target
+			//      a) if source is not branch, create a source branch in target repo that contains the relevant commit
+			CreateEmptyBranch := true
+			if err := git.GitExec(nr.PackageName, "checkout", "-B", nr.Branch, remoteName+"/"+nr.Branch); err == nil {
+				// verify that our branch is empty
+				dir, err := git.GitDirectoryContentList(nr.PackageName, "HEAD")
+				if err != nil {
+					common.LogError("Failed to list directory of", nr.Branch, "Aborting", err)
+					return err
+				}
+				if len(dir) == 0 {
+					common.LogDebug("New package branch is already empty.")
+					CreateEmptyBranch = false
+				}
+			}
+			if CreateEmptyBranch {
+				git.GitExecOrPanic(nr.PackageName, "checkout", "--detach")
+				git.GitExec(nr.PackageName, "branch", "-D", nr.Branch)
+				git.GitExecOrPanic(nr.PackageName, "checkout", "-f", "--orphan", nr.Branch)
+				git.GitExecOrPanic(nr.PackageName, "rm", "-rf", ".")
+				git.GitExecOrPanic(nr.PackageName, "commit", "--allow-empty", "-m", "Initial empty branch")
+				if !common.IsDryRun {
+					git.GitExecOrPanic(nr.PackageName, "push", "-f", remoteName, nr.Branch)
+				}
+			}
+
+			head := nr.Organization + ":" + srcBranch
+			isBranch := false
+			// Hash can be branch name! Check if it's a branch or tag on the remote
+			out, err := git.GitExecWithOutput(nr.PackageName, "ls-remote", "--heads", srcRepo.SSHURL, srcBranch)
+			if err == nil && strings.Contains(out, "refs/heads/"+srcBranch) {
+				isBranch = true
+			}
+
+			if !isBranch {
+				tempBranch := fmt.Sprintf("new_package_%d_%s", issue.Index, nr.PackageName)
+				// Re-clone or use existing if branch check was done above
+				remoteName, err := git.GitClone(nr.PackageName, srcBranch, targetRepo.SSHURL)
+				if err != nil {
+					return err
+				}
+
+				git.GitExecOrPanic(nr.PackageName, "remote", "add", "source", srcRepo.SSHURL)
+				git.GitExecOrPanic(nr.PackageName, "fetch", "source", srcBranch)
+				git.GitExecOrPanic(nr.PackageName, "checkout", "-B", tempBranch, "FETCH_HEAD")
+				if !common.IsDryRun {
+					git.GitExecOrPanic(nr.PackageName, "push", "-f", remoteName, tempBranch)
+				}
+				head = tempBranch
+			}
+
+			title := fmt.Sprintf("Add package %s", nr.PackageName)
+			body := fmt.Sprintf("See issue %s/%s#%d", org, repo, issue.Index)
+			br := branch
+			if len(br) == 0 {
+				br = targetRepo.DefaultBranch
+			}
+			pr, err, isNew := Gitea.CreatePullRequestIfNotExist(targetRepo, head, br, title, body)
+			if err != nil {
+				common.LogError(targetRepo.Name, head, branch, title, body)
+				return err
+			}
+
+			if isNew {
+				if _, err := Gitea.SetLabels(config.Organization, nr.PackageName, pr.Index, []string{config.Label(common.Label_NewRepository)}); err != nil {
+					common.LogError("Failed to set label:", common.Label_NewRepository, err)
+				}
+			}
+		}
+	} else if len(title) > 4 && strings.EqualFold(title[0:4], "[RM]") {
+		// to remove a package, no approval is required. This should happen via
+		// project git PR reviews
+	} else {
+		common.LogError("Non-standard issue created. Ignoring", common.IssueToString(issue))
+		return nil
+	}
+
+	return nil
+}
+
 func (w *RequestProcessor) ProcessFunc(request *common.Request) (err error) {
 	defer func() {
 		if r := recover(); r != nil {
@@ -681,10 +858,7 @@ func (w *RequestProcessor) ProcessFunc(request *common.Request) (err error) {
 			common.LogError("*** Cannot find config for org:", req.Repository.Owner.Username)
 			return nil
 		}
-		processor := &IssueProcessor{
-			issue: issue,
-		}
-		return processor.ProcessIssue(configs)
+		return ProcessIssue(issue, configs)
 	} else {
 		common.LogError("*** Invalid data format for PR processing.")
 		return fmt.Errorf("*** Invalid data format for PR processing.")

workflow-pr/pr_processor_issue_test.go

@@ -0,0 +1,381 @@
+package main
+
+import (
+	"fmt"
+	"testing"
+
+	"go.uber.org/mock/gomock"
+	"src.opensuse.org/autogits/common"
+	"src.opensuse.org/autogits/common/gitea-generated/models"
+	mock_common "src.opensuse.org/autogits/common/mock"
+)
+
+func TestProcessIssue_Add(t *testing.T) {
+	ctl := gomock.NewController(t)
+	defer ctl.Finish()
+
+	gitea := mock_common.NewMockGitea(ctl)
+	Gitea = gitea
+	common.IsDryRun = false
+
+	config := &common.AutogitConfig{
+		Organization:   "target-org",
+		GitProjectName: "test-org/test-prj#main",
+	}
+	configs := []*common.AutogitConfig{config}
+
+	issue := &models.Issue{
+		Title: "[ADD] pkg1",
+		Body:  "src-org/pkg1#master",
+		Index: 123,
+		Repository: &models.RepositoryMeta{
+			Owner: "test-org",
+			Name:  "test-prj",
+		},
+		Ref: "refs/heads/main",
+	}
+
+	t.Run("Repository does not exist - labels issue", func(t *testing.T) {
+		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
+		GitHandler = mockGitGen
+		mockGit := mock_common.NewMockGit(ctl)
+
+		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
+		mockGit.EXPECT().Close().Return(nil)
+
+		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(nil, nil)
+		gitea.EXPECT().SetLabels("test-org", "test-prj", int64(123), []string{"new/New Repository"}).Return(nil, nil)
+
+		err := ProcessIssue(issue, configs)
+
+		if err != nil {
+			t.Errorf("Unexpected error: %v", err)
+		}
+	})
+
+	t.Run("Source is SHA - creates temp branch in target", func(t *testing.T) {
+		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
+		GitHandler = mockGitGen
+		mockGit := mock_common.NewMockGit(ctl)
+
+		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
+		mockGit.EXPECT().GetPath().Return("/tmp/test").AnyTimes()
+		mockGit.EXPECT().Close().Return(nil)
+
+		targetRepo := &models.Repository{
+			Name:   "pkg1",
+			SSHURL: "target-ssh-url",
+			Owner:  &models.User{UserName: "target-org"},
+		}
+		srcRepo := &models.Repository{
+			Name:          "pkg1",
+			SSHURL:        "src-ssh-url",
+			DefaultBranch: "master",
+			Owner:         &models.User{UserName: "src-org"},
+			Parent: &models.Repository{
+				Name:  "pkg1",
+				Owner: &models.User{UserName: "target-org"},
+			},
+		}
+
+		issueSHA := &models.Issue{
+			Title:      "[ADD] pkg1",
+			Body:       "src-org/pkg1#abcdef0123456789abcdef0123456789abcdef01",
+			Index:      123,
+			Repository: &models.RepositoryMeta{Owner: "test-org", Name: "test-prj"},
+			Ref:        "refs/heads/main",
+		}
+
+		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
+		mockGit.EXPECT().GitClone("pkg1", "abcdef0123456789abcdef0123456789abcdef01", "target-ssh-url").Return("origin", nil)
+
+		// New orphan branch logic
+		mockGit.EXPECT().GitExec("pkg1", "checkout", "-B", "abcdef0123456789abcdef0123456789abcdef01", "origin/abcdef0123456789abcdef0123456789abcdef01").Return(fmt.Errorf("error"))
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "--detach")
+		mockGit.EXPECT().GitExec("pkg1", "branch", "-D", "abcdef0123456789abcdef0123456789abcdef01")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-f", "--orphan", "abcdef0123456789abcdef0123456789abcdef01")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "rm", "-rf", ".")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "commit", "--allow-empty", "-m", "Initial empty branch")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", "abcdef0123456789abcdef0123456789abcdef01")
+
+		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
+		mockGit.EXPECT().GitExecWithOutput("pkg1", "ls-remote", "--heads", "src-ssh-url", "abcdef0123456789abcdef0123456789abcdef01").Return("", nil)
+
+		// SHA source logic
+		tempBranch := "new_package_123_pkg1"
+		mockGit.EXPECT().GitClone("pkg1", "abcdef0123456789abcdef0123456789abcdef01", "target-ssh-url").Return("origin", nil)
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "remote", "add", "source", "src-ssh-url")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "fetch", "source", "abcdef0123456789abcdef0123456789abcdef01")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-B", tempBranch, "FETCH_HEAD")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", tempBranch)
+
+		// PR creation using temp branch
+		gitea.EXPECT().CreatePullRequestIfNotExist(targetRepo, tempBranch, "main", gomock.Any(), gomock.Any()).Return(&models.PullRequest{Index: 456}, nil, false)
+
+		err := ProcessIssue(issueSHA, configs)
+		if err != nil {
+			t.Errorf("Unexpected error: %v", err)
+		}
+	})
+
+	t.Run("Repository exists - continue processing and create PR", func(t *testing.T) {
+		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
+		GitHandler = mockGitGen
+		mockGit := mock_common.NewMockGit(ctl)
+
+		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
+		mockGit.EXPECT().Close().Return(nil)
+
+		targetRepo := &models.Repository{
+			Name:   "pkg1",
+			SSHURL: "target-ssh-url",
+			Owner:  &models.User{UserName: "target-org"},
+		}
+		srcRepo := &models.Repository{
+			Name:          "pkg1",
+			SSHURL:        "src-ssh-url",
+			DefaultBranch: "master",
+			Owner:         &models.User{UserName: "src-org"},
+			Parent: &models.Repository{
+				Name:  "pkg1",
+				Owner: &models.User{UserName: "target-org"},
+			},
+		}
+
+		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
+		// 4. Branch check - exists via local git
+		mockGit.EXPECT().GitClone("pkg1", "master", "target-ssh-url").Return("origin", nil)
+		mockGit.EXPECT().GitExec("pkg1", "checkout", "-B", "master", "origin/master").Return(nil)
+		mockGit.EXPECT().GitDirectoryContentList("pkg1", "HEAD").Return(map[string]string{"some-file": "some-sha"}, nil)
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "--detach")
+		mockGit.EXPECT().GitExec("pkg1", "branch", "-D", "master")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-f", "--orphan", "master")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "rm", "-rf", ".")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "commit", "--allow-empty", "-m", gomock.Any())
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", "master")
+
+		// 5. Source repo fetch
+		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
+		// Check if source is a branch via ls-remote
+		mockGit.EXPECT().GitExecWithOutput("pkg1", "ls-remote", "--heads", "src-ssh-url", "master").Return("src-sha refs/heads/master", nil)
+
+		// PR creation
+		packagePR := &models.PullRequest{
+			Index: 456,
+			Base: &models.PRBranchInfo{
+				Ref:  "main",
+				Repo: targetRepo,
+				Name: "main",
+			},
+			Head: &models.PRBranchInfo{
+				Ref:  "master",
+				Repo: srcRepo,
+				Sha:  "src-sha",
+			},
+			URL: "http://gitea/pr/456",
+		}
+		gitea.EXPECT().CreatePullRequestIfNotExist(targetRepo, "src-org:master", "main", gomock.Any(), gomock.Any()).Return(packagePR, nil, true)
+		gitea.EXPECT().SetLabels("target-org", "pkg1", int64(456), []string{"new/New Repository"}).Return(nil, nil)
+
+		err := ProcessIssue(issue, configs)
+		if err != nil {
+			t.Errorf("Unexpected error: %v", err)
+		}
+	})
+
+	t.Run("Source repository is not fork of target repository - aborts", func(t *testing.T) {
+		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
+		GitHandler = mockGitGen
+		mockGit := mock_common.NewMockGit(ctl)
+
+		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
+		mockGit.EXPECT().Close().Return(nil)
+
+		targetRepo := &models.Repository{
+			Name:   "pkg1",
+			SSHURL: "target-ssh-url",
+			Owner:  &models.User{UserName: "target-org"},
+		}
+		srcRepo := &models.Repository{
+			Name:  "pkg1",
+			Owner: &models.User{UserName: "src-org"},
+			Parent: &models.Repository{
+				Name:  "other-repo",
+				Owner: &models.User{UserName: "other-org"},
+			},
+		}
+
+		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
+		mockGit.EXPECT().GitClone("pkg1", "master", "target-ssh-url").Return("origin", nil)
+
+		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
+
+		err := ProcessIssue(issue, configs)
+
+		if err != nil {
+			t.Errorf("Unexpected error: %v", err)
+		}
+	})
+
+	t.Run("Source repository is fork of target repository - proceeds", func(t *testing.T) {
+		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
+		GitHandler = mockGitGen
+		mockGit := mock_common.NewMockGit(ctl)
+
+		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
+		mockGit.EXPECT().Close().Return(nil)
+
+		targetRepo := &models.Repository{
+			Name:   "pkg1",
+			Owner:  &models.User{UserName: "target-org"},
+			SSHURL: "target-ssh-url",
+		}
+		srcRepo := &models.Repository{
+			Name:   "pkg1",
+			Owner:  &models.User{UserName: "src-org"},
+			SSHURL: "src-ssh-url",
+			Parent: &models.Repository{
+				Name:  "pkg1",
+				Owner: &models.User{UserName: "target-org"},
+			},
+			DefaultBranch: "master",
+		}
+
+		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
+		mockGit.EXPECT().GitClone("pkg1", "master", "target-ssh-url").Return("origin", nil)
+		mockGit.EXPECT().GitExec("pkg1", "checkout", "-B", "master", "origin/master").Return(nil)
+		mockGit.EXPECT().GitDirectoryContentList("pkg1", "HEAD").Return(map[string]string{"some-file": "some-sha"}, nil)
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "--detach")
+		mockGit.EXPECT().GitExec("pkg1", "branch", "-D", "master")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-f", "--orphan", "master")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "rm", "-rf", ".")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "commit", "--allow-empty", "-m", gomock.Any())
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", "master")
+
+		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
+		mockGit.EXPECT().GitExecWithOutput("pkg1", "ls-remote", "--heads", "src-ssh-url", "master").Return("src-sha refs/heads/master", nil)
+		gitea.EXPECT().CreatePullRequestIfNotExist(targetRepo, "src-org:master", "main", gomock.Any(), gomock.Any()).Return(&models.PullRequest{Index: 456}, nil, false)
+
+		err := ProcessIssue(issue, configs)
+		if err != nil {
+			t.Errorf("Unexpected error: %v", err)
+		}
+	})
+
+	t.Run("Source repository has no parent (not a fork) - aborts", func(t *testing.T) {
+		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
+		GitHandler = mockGitGen
+		mockGit := mock_common.NewMockGit(ctl)
+
+		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
+		mockGit.EXPECT().Close().Return(nil)
+
+		targetRepo := &models.Repository{
+			Name:   "pkg1",
+			Owner:  &models.User{UserName: "target-org"},
+			SSHURL: "target-ssh-url",
+		}
+		srcRepo := &models.Repository{
+			Name:          "pkg1",
+			Owner:         &models.User{UserName: "src-org"},
+			SSHURL:        "src-ssh-url",
+			Parent:        nil,
+			DefaultBranch: "master",
+		}
+
+		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
+
+		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
+
+		err := ProcessIssue(issue, configs)
+		if err != nil {
+			t.Errorf("Unexpected error: %v", err)
+		}
+	})
+
+	t.Run("Target branch missing - creates orphan branch", func(t *testing.T) {
+		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
+		GitHandler = mockGitGen
+		mockGit := mock_common.NewMockGit(ctl)
+
+		mockGitGen.EXPECT().CreateGitHandler("target-org").Return(mockGit, nil)
+		mockGit.EXPECT().GetPath().Return("/tmp/test").AnyTimes()
+		mockGit.EXPECT().Close().Return(nil)
+
+		targetRepo := &models.Repository{
+			Name:   "pkg1",
+			SSHURL: "target-ssh-url",
+			Owner:  &models.User{UserName: "target-org"},
+		}
+		srcRepo := &models.Repository{
+			Name:          "pkg1",
+			SSHURL:        "src-ssh-url",
+			DefaultBranch: "master",
+			Owner:         &models.User{UserName: "src-org"},
+			Parent: &models.Repository{
+				Name:  "pkg1",
+				Owner: &models.User{UserName: "target-org"},
+			},
+		}
+
+		gitea.EXPECT().GetRepository("target-org", "pkg1").Return(targetRepo, nil)
+		// 4. Branch check - missing
+		mockGit.EXPECT().GitClone("pkg1", "master", "target-ssh-url").Return("origin", nil)
+		mockGit.EXPECT().GitExec(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(fmt.Errorf("not found"))
+
+		// Orphan branch creation
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "--detach")
+		mockGit.EXPECT().GitExec("pkg1", "branch", "-D", "master")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "checkout", "-f", "--orphan", "master")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "rm", "-rf", ".")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "commit", "--allow-empty", "-m", "Initial empty branch")
+		mockGit.EXPECT().GitExecOrPanic("pkg1", "push", "-f", "origin", "master")
+
+		// 5. Source repo fetch
+		gitea.EXPECT().GetRepository("src-org", "pkg1").Return(srcRepo, nil)
+		mockGit.EXPECT().GitExecWithOutput("pkg1", "ls-remote", "--heads", "src-ssh-url", "master").Return("src-sha refs/heads/master", nil)
+
+		// PR creation
+		gitea.EXPECT().CreatePullRequestIfNotExist(targetRepo, "src-org:master", "main", gomock.Any(), gomock.Any()).Return(&models.PullRequest{Index: 456}, nil, false)
+
+		err := ProcessIssue(issue, configs)
+		if err != nil {
+			t.Errorf("Unexpected error: %v", err)
+		}
+	})
+
+	t.Run("Config not found", func(t *testing.T) {
+		issueNoConfig := &models.Issue{
+			Title: "[ADD] pkg1",
+			Body:  "src-org/pkg1#master",
+			Index: 123,
+			Repository: &models.RepositoryMeta{
+				Owner: "other-org",
+				Name:  "other-prj",
+			},
+			Ref: "refs/heads/main",
+		}
+		err := ProcessIssue(issueNoConfig, configs)
+		if err == nil || err.Error() != "Cannot find config for other-org/other-prj#main" {
+			t.Errorf("Expected config not found error, got %v", err)
+		}
+	})
+
+	t.Run("No repos in body", func(t *testing.T) {
+		mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
+		GitHandler = mockGitGen
+		err := ProcessIssue(&models.Issue{
+			Title: "[ADD] pkg1",
+			Body:  "nothing here",
+			Ref:   "refs/heads/main",
+			Repository: &models.RepositoryMeta{
+				Owner: "test-org",
+				Name:  "test-prj",
+			},
+		}, configs)
+		if err != nil {
+			t.Errorf("Unexpected error: %v", err)
+		}
+	})
+}
+

workflow-pr/pr_processor_opened_test.go

@@ -109,9 +109,8 @@ func TestOpenPR(t *testing.T) {
 	}
 
 	t.Run("PR git opened request against PrjGit == no action", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 		Gitea = gitea
 
 		git.GitPath = t.TempDir()
@@ -156,9 +155,8 @@ func TestOpenPR(t *testing.T) {
 	})
 
 	t.Run("Open PrjGit PR", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 
 		Gitea = gitea
 
@@ -210,9 +208,8 @@ func TestOpenPR(t *testing.T) {
 	})
 
 	t.Run("Cannot create prjgit repository", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 
 		Gitea = gitea
 
@@ -259,9 +256,8 @@ func TestOpenPR(t *testing.T) {
 		}
 	})
 	t.Run("Cannot create PR", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 
 		Gitea = gitea
 
@@ -311,9 +307,8 @@ func TestOpenPR(t *testing.T) {
 		}
 	})
 	t.Run("Open PrjGit PR", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 
 		Gitea = gitea
 

workflow-pr/pr_processor_sync_test.go

@@ -74,10 +74,9 @@ func TestSyncPR(t *testing.T) {
 	}
 
 	t.Run("PR_sync_request_against_PrjGit_==_no_action", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		defer ctl.Finish()
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 		Gitea = gitea
 
 		// Common expectations for FetchPRSet and downstream checks
@@ -109,10 +108,9 @@ func TestSyncPR(t *testing.T) {
 	})
 
 	t.Run("Missing PrjGit PR for the sync", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		defer ctl.Finish()
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 		Gitea = gitea
 
 		gitea.EXPECT().GetPullRequestReviews(gomock.Any(), gomock.Any(), gomock.Any()).Return([]*models.PullReview{}, nil).AnyTimes()
@@ -131,10 +129,9 @@ func TestSyncPR(t *testing.T) {
 	})
 
 	t.Run("PR sync", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		defer ctl.Finish()
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 		Gitea = gitea
 
 		setupGitForTests(t, git)

workflow-pr/pr_processor_test.go

@@ -64,7 +64,7 @@ func TestPrjGitDescription(t *testing.T) {
 }
 
 func TestAllocatePRProcessor(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
@@ -104,7 +104,7 @@ func TestAllocatePRProcessor(t *testing.T) {
 }
 
 func TestAllocatePRProcessor_Failures(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
@@ -154,7 +154,7 @@ func TestAllocatePRProcessor_Failures(t *testing.T) {
 }
 
 func TestSetSubmodulesToMatchPRSet_Failures(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	mockGit := mock_common.NewMockGit(ctl)
@@ -178,7 +178,7 @@ func TestSetSubmodulesToMatchPRSet_Failures(t *testing.T) {
 }
 
 func TestSetSubmodulesToMatchPRSet(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	mockGit := mock_common.NewMockGit(ctl)
@@ -226,7 +226,7 @@ func TestSetSubmodulesToMatchPRSet(t *testing.T) {
 }
 
 func TestRebaseAndSkipSubmoduleCommits(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	mockGit := mock_common.NewMockGit(ctl)
@@ -299,12 +299,11 @@ func TestRebaseAndSkipSubmoduleCommits(t *testing.T) {
 }
 
 func TestUpdatePrjGitPR(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	mockGit := mock_common.NewMockGit(ctl)
 	gitea := mock_common.NewMockGitea(ctl)
-	gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	Gitea = gitea
 	CurrentUser = &models.User{UserName: "bot"}
 
@@ -346,36 +345,6 @@ func TestUpdatePrjGitPR(t *testing.T) {
 		}
 	})
 
-	t.Run("Only project git in PR - needs clone", func(t *testing.T) {
-		prset := &common.PRSet{
-			Config: config,
-			PRs: []*common.PRInfo{
-				{
-					RemoteName: "", // Triggers GitClone
-					PR: &models.PullRequest{
-						Base: &models.PRBranchInfo{
-							Name: "main",
-							Repo: &models.Repository{
-								Name:   "test-prj",
-								Owner:  &models.User{UserName: "test-org"},
-								SSHURL: "ssh://git@example.com/test-prj.git",
-							},
-						},
-						Head: &models.PRBranchInfo{
-							Sha: "sha1",
-						},
-					},
-				},
-			},
-		}
-		mockGit.EXPECT().GitClone(common.DefaultGitPrj, "", "ssh://git@example.com/test-prj.git").Return("origin", nil)
-		mockGit.EXPECT().GitExecOrPanic(common.DefaultGitPrj, "fetch", "origin", "sha1")
-		err := processor.UpdatePrjGitPR(prset)
-		if err != nil {
-			t.Errorf("Unexpected error: %v", err)
-		}
-	})
-
 	t.Run("PR on another remote", func(t *testing.T) {
 		prset := &common.PRSet{
 			Config: config,
@@ -547,12 +516,11 @@ func TestUpdatePrjGitPR(t *testing.T) {
 }
 
 func TestCreatePRjGitPR_Integration(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	mockGit := mock_common.NewMockGit(ctl)
 	gitea := mock_common.NewMockGitea(ctl)
-	gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	Gitea = gitea
 
 	config := &common.AutogitConfig{
@@ -667,12 +635,11 @@ func TestMultiPackagePRSet(t *testing.T) {
 }
 
 func TestPRProcessor_Process_EdgeCases(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	mockGit := mock_common.NewMockGit(ctl)
 	gitea := mock_common.NewMockGitea(ctl)
-	gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	Gitea = gitea
 	CurrentUser = &models.User{UserName: "bot"}
 
@@ -791,11 +758,10 @@ func TestPRProcessor_Process_EdgeCases(t *testing.T) {
 }
 
 func TestVerifyRepositoryConfiguration(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	gitea := mock_common.NewMockGitea(ctl)
-	gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	Gitea = gitea
 
 	repo := &models.Repository{
@@ -837,11 +803,10 @@ func TestVerifyRepositoryConfiguration(t *testing.T) {
 }
 
 func TestProcessFunc(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	gitea := mock_common.NewMockGitea(ctl)
-	gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	Gitea = gitea
 	mockGit := mock_common.NewMockGit(ctl)
 	mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)

workflow-pr/repo_check_extended_test.go

@@ -13,11 +13,10 @@ import (
 )
 
 func TestPrjGitSubmoduleCheck(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	gitea := mock_common.NewMockGitea(ctl)
-	gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	mockGit := mock_common.NewMockGit(ctl)
 	Gitea = gitea
 
@@ -94,11 +93,10 @@ func TestPrjGitSubmoduleCheck(t *testing.T) {
 }
 
 func TestPrjGitSubmoduleCheck_Failures(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	gitea := mock_common.NewMockGitea(ctl)
-	gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	mockGit := mock_common.NewMockGit(ctl)
 	Gitea = gitea
 
@@ -152,11 +150,10 @@ func TestPullRequestToEventState(t *testing.T) {
 }
 
 func TestDefaultStateChecker_ProcessPR(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	gitea := mock_common.NewMockGitea(ctl)
-	gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	Gitea = gitea
 	mockGit := mock_common.NewMockGit(ctl)
 	mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
@@ -200,11 +197,10 @@ func TestDefaultStateChecker_ProcessPR(t *testing.T) {
 }
 
 func TestDefaultStateChecker_VerifyProjectState(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	gitea := mock_common.NewMockGitea(ctl)
-	gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	Gitea = gitea
 	mockGit := mock_common.NewMockGit(ctl)
 	mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)
@@ -264,11 +260,10 @@ func TestDefaultStateChecker_VerifyProjectState(t *testing.T) {
 }
 
 func TestDefaultStateChecker_CheckRepos(t *testing.T) {
-	ctl := NewController(t)
+	ctl := gomock.NewController(t)
 	defer ctl.Finish()
 
 	gitea := mock_common.NewMockGitea(ctl)
-	gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 	Gitea = gitea
 	mockGit := mock_common.NewMockGit(ctl)
 	mockGitGen := mock_common.NewMockGitHandlerGenerator(ctl)

workflow-pr/repo_check_test.go

@@ -20,7 +20,7 @@ func TestRepoCheck(t *testing.T) {
 
 	t.Run("Consistency Check On Start", func(t *testing.T) {
 		c := CreateDefaultStateChecker(true, nil, nil, 100)
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		state := NewMockStateChecker(ctl)
 		c.i = state
 		state.EXPECT().CheckRepos().Do(func() {
@@ -40,7 +40,7 @@ func TestRepoCheck(t *testing.T) {
 
 	t.Run("No consistency Check On Start", func(t *testing.T) {
 		c := CreateDefaultStateChecker(true, nil, nil, 100)
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		state := NewMockStateChecker(ctl)
 		c.i = state
 
@@ -62,10 +62,9 @@ func TestRepoCheck(t *testing.T) {
 	})
 
 	t.Run("CheckRepos() calls CheckProjectState() for each project", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		state := NewMockStateChecker(ctl)
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 
 		config1 := &common.AutogitConfig{
 			GitProjectName: "git_repo1",
@@ -99,10 +98,9 @@ func TestRepoCheck(t *testing.T) {
 	})
 
 	t.Run("CheckRepos errors", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		state := NewMockStateChecker(ctl)
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 
 		config1 := &common.AutogitConfig{
 			GitProjectName: "git_repo1",
@@ -145,9 +143,8 @@ func TestVerifyProjectState(t *testing.T) {
 	defer log.SetOutput(oldOut)
 
 	t.Run("Project state with no PRs", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 
 		git := &common.GitHandlerImpl{
 			GitCommiter: "TestCommiter",
@@ -191,9 +188,8 @@ func TestVerifyProjectState(t *testing.T) {
 	})
 
 	t.Run("Project state with 1 PRs that doesn't trigger updates", func(t *testing.T) {
-		ctl := NewController(t)
+		ctl := gomock.NewController(t)
 		gitea := mock_common.NewMockGitea(ctl)
-		gitea.EXPECT().ResetTimelineCache(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes()
 
 		git := &common.GitHandlerImpl{
 			GitCommiter: "TestCommiter",

workflow-pr/test_utils_test.go

@@ -7,14 +7,8 @@ import (
 	"testing"
 
 	"src.opensuse.org/autogits/common"
-	"go.uber.org/mock/gomock"
 )
 
-func NewController(t *testing.T) *gomock.Controller {
-	common.SetTestLogger(t)
-	return gomock.NewController(t)
-}
-
 const LocalCMD = "---"
 
 func gitExecs(t *testing.T, git *common.GitHandlerImpl, cmds [][]string) {