git-workflow/autogits
SHA256
20
1
Fork 11
Code Issues 46 Pull Requests 9 Actions 1 Projects 2 Activity

Allow gitea_status_proxy to properly proxy statuses #88

Manually merged
adamm merged 5 commits from szarate/gitea_status_proxy AGit into main 2025-11-03 17:50:22 +01:00
Conversation 2 Commits 5 Files Changed 2 +61 -18
szarate commented 2025-10-30 13:09:25 +01:00
Contributor
Copy Link

In its current state, the gitea_status_proxy is not able to forward requests it gets from authorized users, this PR fixes that by changing the Authorization and Content Headers to what gitea expects.

I'm also adding a quick readme file, with an usage example.

A result of setting the statuses can be seen at szarate/test-actions-gitea#1

In its current state, the `gitea_status_proxy` is not able to forward requests it gets from authorized users, this PR fixes that by changing the `Authorization` and `Content` Headers to what gitea expects. I'm also adding a quick readme file, with an usage example. A result of setting the statuses can be seen at https://src.opensuse.org/szarate/test-actions-gitea/pulls/1
szarate added 4 commits 2025-10-30 13:09:25 +01:00
Update authorization headers 244160e20e 
For gitea API AuthorizationHeaderToken tokens must be prepended with "token" followed by a space, also fix content type
Be more verbose about authentication errors d083acfd1c
Properly proxy json input directly to gitea 5cb46d106f
Add simple readme for gitea_status_proxy f1ca81ff29
szarate added 2 commits 2025-10-30 13:35:32 +01:00
Add simple readme for gitea_status_proxy f1ca81ff29
Add simple readme for gitea_status_proxy 5f9d406a5c
adamm requested changes 2025-10-30 22:55:27 +01:00
adamm left a comment
Owner
Copy Link

Just some nit-picks, otherwise looks good, thanks!

Just some nit-picks, otherwise looks good, thanks!
👍 1
gitea_status_proxy/main.go
@@ -19,3 +17,1 @@
State string `json:"state"`
TargetUrl string `json:"target_url"`
}
// type Status struct {
adamm commented 2025-10-30 22:25:16 +01:00
Owner
Copy Link

I think we can remove this commented out stuct.

I think we can remove this commented out stuct.
szarate marked this conversation as resolved
gitea_status_proxy/main.go
@@ -83,6 +89,7 @@ func StatusProxy(w http.ResponseWriter, r *http.Request) {
token := token_arr[1]
if !slices.Contains(config.Keys, token) {
common.LogError("Provided token is not known")
adamm commented 2025-10-30 22:31:22 +01:00
Owner
Copy Link

These pre-auth errors should probably use Debug() logging level instead of Error(). If someone spams this endpoint with garbage, it could generate a lot of useless logs here.

These pre-auth errors should probably use Debug() logging level instead of Error(). If someone spams this endpoint with garbage, it could generate a lot of useless logs here.
szarate marked this conversation as resolved
gitea_status_proxy/main.go
@@ -114,0 +117,4 @@
// Context: statusinput.Context,
// State: statusinput.State,
// TargetUrl: statusinput.TargetUrl,
// }
adamm commented 2025-10-30 22:27:52 +01:00
Owner
Copy Link

this comment too can be removed

this comment too can be removed
szarate marked this conversation as resolved
gitea_status_proxy/readme.md
@@ -0,0 +11,4 @@
```
{
"forge_url": "https://src.opensuse.org/api/v1",
"keys": ["some-application-key"]
adamm commented 2025-10-30 22:53:54 +01:00
Owner
Copy Link

We should add that keys should be random and generated like

openssl rand -base64 48

And the build section can probably be removed, as it's just go build

We should add that keys should be random and generated like `openssl rand -base64 48` And the build section can probably be removed, as it's just `go build`
szarate commented 2025-10-31 10:37:26 +01:00
Author
Contributor
Copy Link

Updated the readme to reflect that

Updated the readme to reflect that
adamm marked this conversation as resolved
szarate added 2 commits 2025-10-31 10:34:38 +01:00
Add simple readme for gitea_status_proxy 5f9d406a5c
Add simple readme for gitea_status_proxy 55846562c1
szarate requested review from adamm 2025-10-31 10:37:43 +01:00
szarate commented 2025-10-31 10:38:03 +01:00
Author
Contributor
Copy Link

All comments have been addressed

All comments have been addressed
adamm manually merged commit 918723d57b into main 2025-11-03 17:50:22 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
adamm
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
M0ses adamm andriinikitin atartamo bigironman dancermak darix dirkmueller dmach eroca jdsn jzerebecki mstrigl oertel smithfarm
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: git-workflow/autogits#88
Delete Branch "szarate/gitea_status_proxy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?