importers/git-importer
3
0
Fork 2
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Also treat some more mimetypes as text #20

Merged
Ghost merged 2 commits from add_further_mimetypes into main 2022-11-15 07:28:05 +01:00
Conversation 0 Commits 2 Files Changed 3 +18 -17
Ghost commented 2022-11-11 16:23:08 +01:00
First-time contributor
Copy Link
No description provided.
Ghost added 1 commit 2022-11-11 16:23:09 +01:00
Ghost added 1 commit 2022-11-11 16:34:25 +01:00 
It's ignoring exceptions and makes debugging way too hard to justify
what's happening
aplanas reviewed 2022-11-14 08:08:28 +01:00
lib/binary.py
@ -36,4 +47,3 @@
".asc",
".c",
".cabal",
".cfg",
aplanas commented 2022-11-14 08:08:28 +01:00
Owner
Copy Link

OK for me, but this seems like a non-binary suffix

OK for me, but this seems like a non-binary suffix
Ghost commented 2022-11-15 07:27:58 +01:00
Author
First-time contributor
Copy Link

You're most certainly right. But I was thinking that if a .cfg is large enough to run into this function, it could also be a binary format and we better rely on mimetype detection.

In the database it's only https://gitea.opensuse.org/rpm/fluid-soundfont/src/branch/factory/fluidr3_gm.cfg and it's detected as text/plain - so we're good either way.

You're most certainly right. But I was thinking that if a .cfg is large enough to run into this function, it could also be a binary format and we better rely on mimetype detection. In the database it's only https://gitea.opensuse.org/rpm/fluid-soundfont/src/branch/factory/fluidr3_gm.cfg and it's detected as text/plain - so we're good either way.
aplanas approved these changes 2022-11-14 08:08:36 +01:00
Ghost merged commit d311d54f26 into main 2022-11-15 07:28:05 +01:00
Ghost deleted branch add_further_mimetypes 2022-11-15 07:28:11 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
aplanas
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: importers/git-importer#20
No description provided.
Delete Branch "add_further_mimetypes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?