main #36

adamm · 2025-09-04T14:10:54+02:00

adamm commented

2025-09-04 14:10:54 +02:00

Fixes from devel import.

adamm added 10 commits 2025-09-04 14:10:54 +02:00

Revert "Only stop importing when it isn't a jengelh repository" fb80d0c105

This reverts commit 44b4d690db.

this breaks detection of scmsync projects. Jan can live with not synced
git for a few weeks

fix bug 4ef980d1c8

re-enable LFS checks 7684388193

Ignore OBS service generated files 32d1924a0d

_service: files should not be imported. They are created
by OBS service and will be re-created by OBS during scm sync

Also, not allowed in Factory by policy anyway. So this affects
devel and home projects only

Empty files should still have a mimetype assigned 5d55a8c2fe

Look at deleted packages if they are not found 5a6a55868f

Don't export service files from overlay d5eb5c0db6

Include all the devel commits 17888407df

If commits in devel are younger than factory, we should
probalby export them too....

reconstruct state data 5a28f62fb9

If the state file is missing, we can reconstruct which parts were
exported based on revision ids

Also, packages could have branches in Git, but not be in Git. We
need to check (project,package) tuple for this and not just abort
based on the package name alone.

stop using saved state 94e57852a0

We can reconstruct the state based on log messages. Otherwise,
it's incorrect as the trimming function removes exported parts
anyway and then we have missing commits

mcepl reviewed 2025-09-04 15:56:49 +02:00

mcepl left a comment

First-time contributor

I haven’t dived sufficiently deep to be able to make a judgement on this PR, but I have some comments on it.

lib/git.py

						
				@@ -161,2 +161,4 @@

				        )

				    def branch_commit(self, branch="HEAD"):

				      try:

mcepl commented

2025-09-04 15:49:06 +02:00

First-time contributor

Using try … except as a substitute for if … then … else is always a code smell. Couldn’t you find some civilized way how to decide when to run that command without just trying it blindly?

Using `try … except` as a substitute for `if … then … else` is always a code smell. Couldn’t you find some civilized way how to decide when to run that command without just trying it blindly?

lib/git_exporter.py

						
				@@ -70,3 +137,1 @@

				        left_to_commit = self.check_repo_state(flats, branch_state)

				        if not left_to_commit:

				        if tree == None:  # eg. python-M2Crypto errors