Disable xvid plugin build and dependence #6

qzhao · 2024-09-29T10:25:48+02:00

qzhao commented

2024-09-29 10:25:48 +02:00

Since legal reviewers are concerned xvid patents have not expired
in Brazil, which should not be used in a commercial context.
https://en.wikipedia.org/wiki/Xvid

Please review, thank you.

Since legal reviewers are concerned xvid patents have not expired in Brazil, which should not be used in a commercial context. https://en.wikipedia.org/wiki/Xvid Please review, thank you.

qzhao added 2 commits 2024-09-29 10:25:48 +02:00

Add use 64bit for input size check log entry for n7.0.2's update, to record security fix position. (CVE-2024-7055, bsc#1229026) ec4693218d

Disable xvid plugin build and dependence 717ee65f40

Since legal reviewers are concerned xvid patents have not expired
in Brazil, which should not be used in a commercial context.
https://en.wikipedia.org/wiki/Xvid

jengelh commented

2024-09-29 10:43:39 +02:00

+%if !0%{?is_opensuse}

With that, SLE will still enable xvid, and since Leap imports from SLE without rebuild, xvid will be enabled in Leap.

-#Git-Clone: git://source.ffmpeg.org/ffmpeg

don't steal my line :^)

>`+%if !0%{?is_opensuse}` With that, SLE will still enable xvid, and since Leap imports from SLE without rebuild, xvid will be enabled in Leap. >`-#Git-Clone: git://source.ffmpeg.org/ffmpeg` don't steal my line :^)

qzhao commented

2024-09-29 15:12:46 +02:00

+%if !0%{?is_opensuse}

With that, SLE will still enable xvid, and since Leap imports from SLE without rebuild, xvid will be enabled in Leap.

%if !0%{?is_opensuse}`, means in SLE.
%bcond_with xvid, means disable xvid, not enable.

For leap, see that:
$ osc -A https://api.opensuse.org meta prjconf openSUSE:Leap:15.6 | grep is_opensuse
%is_opensuse 1
So Leap enable xvid. Leap will re-build packages.

-#Git-Clone: git://source.ffmpeg.org/ffmpeg

don't steal my line :^)

I remember someone in openSUSE said in the past that Don't add a separate log entry for these tinny obvious changes, just combine them with other mainly fixes. Since this line has already been commented out, I delete it to make the SPEC file more concise.

> >`+%if !0%{?is_opensuse}` > > With that, SLE will still enable xvid, and since Leap imports from SLE without rebuild, xvid will be enabled in Leap. %if !0%{?is_opensuse}`, means in SLE. %bcond_with xvid, means disable xvid, not enable. For leap, see that: $ osc -A https://api.opensuse.org meta prjconf openSUSE:Leap:15.6 | grep is_opensuse %is_opensuse 1 So Leap enable xvid. Leap will re-build packages. > > >`-#Git-Clone: git://source.ffmpeg.org/ffmpeg` > > don't steal my line :^) I remember someone in openSUSE said in the past that Don't add a separate log entry for these tinny obvious changes, just combine them with other mainly fixes. Since this line has already been commented out, I delete it to make the SPEC file more concise.

jengelh commented

2024-09-29 16:44:54 +02:00

if it were rebuilt, it would carry a different Distribution: line.

1.png

37 KiB

jengelh commented

2024-10-01 13:53:33 +02:00

cc @Pharaoh_Atem . Opinions? Fedora still has xvid in ffmpeg.

Pharaoh_Atem commented

2024-10-01 14:03:09 +02:00

First-time contributor

I've been advised that it is fine to ship in Fedora, and I would say that's sufficient to not worry about it here too.

jengelh commented

2024-10-01 15:43:02 +02:00

If SUSE thinks it must do this, then there should be more submissions, e.g. to vlc and xvidcore.
I would not mind removing xvidcore, since it is just used as one potential mpeg4 encoder in ffmpeg (and not used for decode).

If SUSE thinks it must do this, then there should be more submissions, e.g. to vlc and xvidcore. I would not mind removing xvidcore, since it is just used as one potential mpeg4 encoder in ffmpeg (and not used for decode).

This pull request has changes conflicting with the target branch.

ffmpeg-7.0.2.tar.xz
ffmpeg-7.changes

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u master:qzhao-master

git checkout qzhao-master

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: jengelh/ffmpeg-7#6