jengelh/ffmpeg-7
SHA256
2
1
Fork 12
forked from pool/ffmpeg-7
Code Pull Requests Activity

Disable xvid plugin build and dependence #6

Manually merged
jengelh merged 1 commits from qzhao/ffmpeg-7:master into master 2025-07-10 10:11:44 +02:00
Conversation 6 Commits 1 Files Changed 1 +8
qzhao commented 2024-09-29 10:25:48 +02:00
Contributor
Copy Link

Since legal reviewers are concerned xvid patents have not expired
in Brazil, which should not be used in a commercial context.
https://en.wikipedia.org/wiki/Xvid

Please review, thank you.

Since legal reviewers are concerned xvid patents have not expired in Brazil, which should not be used in a commercial context. https://en.wikipedia.org/wiki/Xvid Please review, thank you.
qzhao added 2 commits 2024-09-29 10:25:48 +02:00
Add use 64bit for input size check log entry for n7.0.2's update, to record security fix position. (CVE-2024-7055, bsc#1229026) ec4693218d
Disable xvid plugin build and dependence 717ee65f40 
Since legal reviewers are concerned xvid patents have not expired
in Brazil, which should not be used in a commercial context.
https://en.wikipedia.org/wiki/Xvid
jengelh commented 2024-09-29 10:43:39 +02:00
Owner
Copy Link

+%if !0%{?is_opensuse}

With that, SLE will still enable xvid, and since Leap imports from SLE without rebuild, xvid will be enabled in Leap.

-#Git-Clone: git://source.ffmpeg.org/ffmpeg

don't steal my line :^)

>`+%if !0%{?is_opensuse}` With that, SLE will still enable xvid, and since Leap imports from SLE without rebuild, xvid will be enabled in Leap. >`-#Git-Clone: git://source.ffmpeg.org/ffmpeg` don't steal my line :^)
qzhao commented 2024-09-29 15:12:46 +02:00
Author
Contributor
Copy Link

+%if !0%{?is_opensuse}

With that, SLE will still enable xvid, and since Leap imports from SLE without rebuild, xvid will be enabled in Leap.

%if !0%{?is_opensuse}`, means in SLE.
%bcond_with xvid, means disable xvid, not enable.

For leap, see that:
$ osc -A https://api.opensuse.org meta prjconf openSUSE:Leap:15.6 | grep is_opensuse
%is_opensuse 1
So Leap enable xvid. Leap will re-build packages.

-#Git-Clone: git://source.ffmpeg.org/ffmpeg

don't steal my line :^)

I remember someone in openSUSE said in the past that Don't add a separate log entry for these tinny obvious changes, just combine them with other mainly fixes. Since this line has already been commented out, I delete it to make the SPEC file more concise.

> >`+%if !0%{?is_opensuse}` > > With that, SLE will still enable xvid, and since Leap imports from SLE without rebuild, xvid will be enabled in Leap. %if !0%{?is_opensuse}`, means in SLE. %bcond_with xvid, means disable xvid, not enable. For leap, see that: $ osc -A https://api.opensuse.org meta prjconf openSUSE:Leap:15.6 | grep is_opensuse %is_opensuse 1 So Leap enable xvid. Leap will re-build packages. > > >`-#Git-Clone: git://source.ffmpeg.org/ffmpeg` > > don't steal my line :^) I remember someone in openSUSE said in the past that Don't add a separate log entry for these tinny obvious changes, just combine them with other mainly fixes. Since this line has already been commented out, I delete it to make the SPEC file more concise.
jengelh commented 2024-09-29 16:44:54 +02:00
Owner
Copy Link

if it were rebuilt, it would carry a different Distribution: line.

if it were rebuilt, it would carry a different Distribution: line.
1.png
37 KiB
1.png
jengelh commented 2024-10-01 13:53:33 +02:00
Owner
Copy Link

cc @Pharaoh_Atem . Opinions? Fedora still has xvid in ffmpeg.

cc @Pharaoh_Atem . Opinions? Fedora still has xvid in ffmpeg.
Pharaoh_Atem commented 2024-10-01 14:03:09 +02:00
First-time contributor
Copy Link

I've been advised that it is fine to ship in Fedora, and I would say that's sufficient to not worry about it here too.

I've been advised that it is fine to ship in Fedora, and I would say that's sufficient to not worry about it here too.
jengelh commented 2024-10-01 15:43:02 +02:00
Owner
Copy Link

If SUSE thinks it must do this, then there should be more submissions, e.g. to vlc and xvidcore.
I would not mind removing xvidcore, since it is just used as one potential mpeg4 encoder in ffmpeg (and not used for decode).

If SUSE thinks it must do this, then there should be more submissions, e.g. to vlc and xvidcore. I would not mind removing xvidcore, since it is just used as one potential mpeg4 encoder in ffmpeg (and not used for decode).
qzhao force-pushed master from 717ee65f40 to fba0c8d5ae 2025-02-28 15:28:11 +01:00 Compare
jengelh manually merged commit fba0c8d5ae into master 2025-02-28 15:28:13 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jengelh
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jengelh/ffmpeg-7#6
No description provided.
Delete Branch "qzhao/ffmpeg-7:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?