jengelh/libteam
SHA256
1
0
Fork 0
forked from pool/libteam
Code Pull Requests Activity

Accepting request 678168 from home:fbui:branches:network

Browse Source 
- Drop use of $FIRST_ARG in .spec
  The use of $FIRST_ARG was probably required because of the
  %service_* rpm macros were playing tricks with the shell positional
  parameters. This is bad practice and error prones so let's assume
  that no macros should do that anymore and hence it's safe to assume
  that positional parameters remains unchanged after any rpm macro
  call.

OBS-URL: https://build.opensuse.org/request/show/678168
OBS-URL: https://build.opensuse.org/package/show/network/libteam?expand=0&rev=17
This commit is contained in:
Tomáš Chvátal 2019-02-25 08:38:07 +00:00 committed by Git OBS Bridge
parent 65e2ff8c8c
commit 13c2fb5372
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libteam.changes
View File

@ -1,3 +1,15 @@
-------------------------------------------------------------------
Fri Feb 22 07:33:05 UTC 2019 - Franck Bui <fbui@suse.com>
- Drop use of $FIRST_ARG in .spec
The use of $FIRST_ARG was probably required because of the
%service_* rpm macros were playing tricks with the shell positional
parameters. This is bad practice and error prones so let's assume
that no macros should do that anymore and hence it's safe to assume
that positional parameters remains unchanged after any rpm macro
call.
-------------------------------------------------------------------
Fri Jan 5 00:31:20 UTC 2018 - jengelh@inai.de

2
libteam.spec
View File

@ -192,7 +192,7 @@ systemctl reload dbus.service 2>/dev/null || :
%service_del_postun teamd@.service
%endif
# reload dbus to forget teamd's policy
if [ ${FIRST_ARG:-$1} -eq 0 ]; then
if [ $1 -eq 0 ]; then
systemctl reload dbus.service 2>/dev/null || :
fi