jengelh/schismtracker
SHA256
1
0
Fork 0
forked from pool/schismtracker
Code Pull Requests Activity

Drop schism-nodate.diff to make builds reproducible #1

Merged
jengelh merged 1 commits from :rb into master 2025-02-06 12:04:46 +01:00
Conversation 3 Commits 1 Files Changed 3 +5 -27
bmwiedemann commented 2025-02-06 09:28:15 +01:00
Contributor
Copy Link

__DATE__ and __TIME__ are perfectly reproducible for years, because we patched gcc to use SOURCE_DATE_EPOCH instead of the build time.
However this patch modified the mtime of version.c which ended up in the binary via __TIMESTAMP__

`__DATE__` and `__TIME__` are perfectly reproducible for years, because we patched gcc to use `SOURCE_DATE_EPOCH` instead of the build time. However this patch modified the mtime of version.c which ended up in the binary via `__TIMESTAMP__`
bmwiedemann added 1 commit 2025-02-06 09:28:16 +01:00
jengelh merged commit 2c25770743 into master 2025-02-06 12:04:46 +01:00
jengelh commented 2025-02-06 12:51:19 +01:00
Owner
Copy Link

So wouldn't that affect gzdoom.spec as well? (Did that not turn up yet in your bit-comparisons?)

So wouldn't that affect gzdoom.spec as well? (Did that not turn up yet in your bit-comparisons?)
jengelh commented 2025-02-06 15:50:09 +01:00
Owner
Copy Link

I'm asking because gzdoom.spec also patches the source (so there is a change in modtime of a .c/.cpp file), which should show up on @bmwiedemann 's bit-reproducibility radar, but I am not sure it did.

I'm asking because gzdoom.spec also patches the source (so there is a change in modtime of a .c/.cpp file), which _should_ show up on @bmwiedemann 's bit-reproducibility radar, but I am not sure it did.
bmwiedemann commented 2025-02-08 04:01:21 +01:00
Author
Contributor
Copy Link

Very few places seem to embed the mtime of the source-file as version.c did here.

gzdoom has a marker for being dependent on filesystem-readdir-order, but since we have the 'nodirindex' flag set in openSUSE:Factory prjconf, that is not causing trouble anymore.

Very few places seem to embed the mtime of the source-file as version.c did here. `gzdoom` has a marker for being dependent on filesystem-readdir-order, but since we have the 'nodirindex' flag set in openSUSE:Factory prjconf, that is not causing trouble anymore.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jengelh/schismtracker#1
No description provided.
Delete Branch ":rb"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?