jengelh/slade
SHA256
1
0
Fork 1
forked from pool/slade
Code Pull Requests Activity

Drop unused dependency on glew. #1

Merged
jengelh merged 1 commits from badshah400/slade:master into master 2025-04-15 19:33:14 +02:00
Conversation 2 Commits 1 Files Changed 2 +6 -1
badshah400 commented 2025-04-15 17:57:35 +02:00
Contributor
Copy Link

Glew has been dropped in favour of GLAD since version 3.2.0 (see
upstream commit https://github.com/sirjuddington/SLADE/commit/4d0433b).

Glew has been dropped in favour of GLAD since version 3.2.0 (see upstream commit https://github.com/sirjuddington/SLADE/commit/4d0433b).
badshah400 added 1 commit 2025-04-15 17:57:36 +02:00
Drop unused dependency on glew. c228cf695c 
Glew has been dropped in favour of GLAD since version 3.2.0 (see
upstream commit https://github.com/sirjuddington/SLADE/commit/4d0433b).
jengelh commented 2025-04-15 19:32:13 +02:00
Owner
Copy Link

You did not add a BuildRequires: glad, and 'lo and behold, I see SLADE has a bundled copy of GLAD. Could we forego that and use the system copy that you have in home:badshah400:Staging/glad?
[Doesn't impact this PR, just saying]

You did not add a `BuildRequires: glad`, and 'lo and behold, I see SLADE has a bundled copy of GLAD. Could we forego that and use the system copy that you have in home:badshah400:Staging/glad? [Doesn't impact this PR, just saying]
jengelh merged commit c228cf695c into master 2025-04-15 19:33:14 +02:00
badshah400 commented 2025-04-15 20:02:10 +02:00
Author
Contributor
Copy Link

Glad is a generator that generates the code you will need for a given GL specification. You are expected to bundle the code with your app/library. See https://gen.glad.sh/.

I am packaging the code generator command line tool as a separate package (which is the glad package in my ~:Staging project), but as far as I can tell, there isn't a '-DUSE_SYSTEM_GLAD' provision ever when using GLAD.

Glad is a generator that generates the code you will need for a given GL specification. You are expected to bundle the code with your app/library. See https://gen.glad.sh/. I am packaging the code generator command line tool as a separate package (which is the glad package in my ~:Staging project), but as far as I can tell, there isn't a '-DUSE_SYSTEM_GLAD' provision ever when using GLAD.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jengelh
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jengelh/slade#1
Delete Branch "badshah400/slade:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?