kernel-kdump/makedumpfile
SHA256
14
0
Fork 2
forked from pool/makedumpfile
Code Pull Requests 1 Activity

Use termios instead of obsolete termio #4

Open
Andreas_Schwab wants to merge 1 commits from Andreas_Schwab/makedumpfile:main into main
pull from: Andreas_Schwab/makedumpfile:main
merge into: kernel-kdump:main
Conversation 4 Commits 1 Files Changed 4 +59 -2
Andreas_Schwab commented 2025-07-28 11:28:26 +02:00
First-time contributor
Copy Link
No description provided.
Andreas_Schwab added 1 commit 2025-07-28 11:28:27 +02:00
Use termios instead of obsolete termio d9fa342dc7
autogits-devel requested review from dmair 2025-07-28 11:28:32 +02:00
autogits-devel requested review from jbohac 2025-07-28 11:28:33 +02:00
autogits-devel requested review from mkoutny 2025-07-28 11:28:33 +02:00
autogits-devel requested review from petesarik 2025-07-28 11:28:33 +02:00
autogits-devel requested review from tiwai 2025-07-28 11:28:33 +02:00
autogits-devel requested review from trenn 2025-07-28 11:28:34 +02:00
Andreas_Schwab force-pushed main from d9fa342dc7 to 9882266cb2 2025-07-28 13:16:55 +02:00 Compare
Andreas_Schwab force-pushed main from 9882266cb2 to a2ea6b2f10 2025-08-04 14:56:08 +02:00 Compare
petesarik commented 2025-08-13 16:02:55 +02:00
Owner
Copy Link

Upstream has a slightly different fix:

5ecafb7aba

But I like your changes better, because they also replace the raw ioctl() with tcgetattr() and tcsetattr(). Would you mind proposing them to upstream?

Upstream has a slightly different fix: https://github.com/lucchouina/eppic/commit/5ecafb7aba4db96c733906e3046b6bbffd0634f6 But I like your changes better, because they also replace the raw `ioctl()` with `tcgetattr()` and `tcsetattr()`. Would you mind proposing them to upstream?
Andreas_Schwab commented 2025-08-13 18:25:52 +02:00
Author
First-time contributor
Copy Link

Upstream is now broken.

Upstream is now broken.
petesarik commented 2025-08-14 09:03:47 +02:00
Owner
Copy Link

Upstream is now broken.

And that's why upstream should be fixed first. We don't want to maintain a growing number of SUSE-specific fixes. Are you going to make an upstream issue and/or pull request?

> Upstream is now broken. And that's why upstream should be fixed first. We don't want to maintain a growing number of SUSE-specific fixes. Are you going to make an upstream issue and/or pull request?
Andreas_Schwab commented 2025-08-14 09:26:14 +02:00
Author
First-time contributor
Copy Link

Sure, just want to let you know.

Sure, just want to let you know.
This pull request has changes conflicting with the target branch.
  • makedumpfile.changes
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:Andreas_Schwab-main
git checkout Andreas_Schwab-main
Sign in to join this conversation.
Reviewers
No Reviewers
dmair
mkoutny
petesarik
tiwai
jbohac
trenn
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
RBrownFactory adamm anag_factory autogits-devel dimstar_suse dmair favogt_factory jbohac lkocman-factory maxlin_factory mkoutny petesarik ptesarik tiwai trenn
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kernel-kdump/makedumpfile#4
No description provided.
Delete Branch "Andreas_Schwab/makedumpfile:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?