lua/lua-macros
SHA256
10
0
Fork 1
forked from pool/lua-macros
Code Pull Requests Activity

macros.lua: Fix parsing on older SLE releases #1

Manually merged
lua merged 1 commits from michals/lua-macros:main into main 2025-11-07 10:03:54 +01:00
Conversation 4 Commits 1 Files Changed 1 +4 -4
michals commented 2025-11-06 19:10:42 +01:00
Contributor
Copy Link

Older RPM versions don't like blank lines in lua macros.

Older RPM versions don't like blank lines in lua macros.
michals added 1 commit 2025-11-06 19:10:42 +01:00
macros.lua: Fx parsing on older SLE releases dd150d0fc5 
Older RPM versions don't like blank lines in lua macros.
autogits-devel requested review from MargueriteSu 2025-11-06 19:10:47 +01:00
autogits-devel requested review from darix 2025-11-06 19:10:47 +01:00
autogits-devel requested review from gmbr3 2025-11-06 19:10:47 +01:00
autogits-devel requested review from jubalh 2025-11-06 19:10:47 +01:00
autogits-devel requested review from mcepl 2025-11-06 19:10:48 +01:00
autogits-devel requested review from pgajdos 2025-11-06 19:10:48 +01:00
michals added 2 commits 2025-11-06 19:15:11 +01:00
macros.lua: Fx parsing on older SLE releases dd150d0fc5 
Older RPM versions don't like blank lines in lua macros.
macros.lua: Fix parsing on older SLE releases 227b626ed0 
Older RPM versions don't like blank lines in lua macros.
michals changed title from macros.lua: Fx parsing on older SLE releases to macros.lua: Fix parsing on older SLE releases 2025-11-06 19:15:16 +01:00
mcepl approved these changes 2025-11-07 10:03:43 +01:00
mcepl left a comment
Owner
Copy Link

OK, I didn’t know that. Thank you.

OK, I didn’t know that. Thank you.
autogits-devel removed review request for darix 2025-11-07 10:03:48 +01:00
autogits-devel removed review request for gmbr3 2025-11-07 10:03:49 +01:00
autogits-devel removed review request for jubalh 2025-11-07 10:03:49 +01:00
autogits-devel removed review request for MargueriteSu 2025-11-07 10:03:49 +01:00
autogits-devel removed review request for pgajdos 2025-11-07 10:03:49 +01:00
lua manually merged commit 227b626ed0 into main 2025-11-07 10:03:54 +01:00
mcepl commented 2025-11-07 10:06:01 +01:00
Owner
Copy Link

@michals And actually, I should reject this: it is missing entry in *.changes. Please, add them, now I will have to do it myself.

@michals And actually, I should reject this: it is missing entry in `*.changes`. Please, add them, now I will have to do it myself.
michals commented 2025-11-07 10:12:07 +01:00
Author
Contributor
Copy Link

Is this documented somewhere?

This somewhat varies per project. Some use some changelog generator.

Is this documented somewhere? This somewhat varies per project. Some use some changelog generator.
michals commented 2025-11-07 10:29:46 +01:00
Author
Contributor
Copy Link

hm, I guess this is because of using git workfow directly, there is no step where the changelog could be generated. The projects where this works develop in a separate repository, and import the source with a service

hm, I guess this is because of using git workfow directly, there is no step where the changelog could be generated. The projects where this works develop in a separate repository, and import the source with a service
Sign in to join this conversation.
Reviewers
No Reviewers
mcepl
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
RBrownFactory adamm autogits-devel darix dimstar_suse favogt_factory gmbr3 jubalh lkocman-factory maxlin_factory mcepl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lua/lua-macros#1
No description provided.
Delete Branch "michals/lua-macros:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?