luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-12 15:36:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

gthreadedresolver: Comment on name expansion for SRV targets

Browse Source 
See the commit contents. This clarifies the existing code’s behaviour
and doesn’t change it.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Fixes: #2622
This commit is contained in:
Philip Withnall 2022-10-17 12:45:19 +01:00
parent b7f2b09c30
commit 09459fa44d
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gio/gthreadedresolver.c
View File

@ -579,6 +579,22 @@ parse_res_srv (const guint8 *answer,
GETSHORT (weight, *p);
GETSHORT (port, *p);
/* RFC 2782 says (on page 4) that “Unless and until permitted by future
* standards action, name compression is not to be used for this field.”, so
* technically we shouldn’t be expanding names here for SRV records.
*
* However, other DNS resolvers (such as systemd[1]) do, and it seems in
* keeping with the principle of being liberal in what you accept and strict
* in what you emit. It also seems harmless.
*
* An earlier version of the RFC, RFC 2052 (now obsolete) specified that name
* compression *was* to be used for SRV targets[2].
*
* See discussion on https://gitlab.gnome.org/GNOME/glib/-/issues/2622.
*
* [1]: https://github.com/yuwata/systemd/blob/2d23cc3c07c49722ce93170737b3efd2692a2d08/src/resolve/resolved-dns-packet.c#L1674
* [2]: https://datatracker.ietf.org/doc/html/rfc2052#page-3
*/
if (!expand_name ("SRV", answer, end, p, namebuf, sizeof (namebuf), error))
return NULL;