mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2024-12-25 15:06:14 +01:00
gsocks5proxy: Fix error reporting in authentication
set_auth_msg() was returning FALSE to indicate error, but all its callers were expecting a negative return value to indicate error. This was causing memory leaks for the GError, and errors to not be reported. Coverity CID: 1325357
This commit is contained in:
parent
c1c001e300
commit
0f98b2f4ec
@ -205,7 +205,7 @@ set_auth_msg (guint8 *msg,
|
||||
g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_PROXY_FAILED,
|
||||
_("Username or password is too long for SOCKSv5 "
|
||||
"protocol."));
|
||||
return FALSE;
|
||||
return -1;
|
||||
}
|
||||
|
||||
msg[len++] = SOCKS5_AUTH_VERSION;
|
||||
|
Loading…
Reference in New Issue
Block a user