luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-09 19:06:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

fdo notification: Avoid a double free

Browse Source 
We're first getting the notification by its notify_id, but activating
the action afterwards could redraw it, leading to a dangling pointer.
Fix this by simply searching the list of active notifications again
after activating the action.
This commit is contained in:
Timm Bäder 2017-01-19 08:18:59 +01:00
parent d0ffee8feb
commit 1920b550db
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gio/gfdonotificationbackend.c
View File

@ -178,8 +178,13 @@ notify_signal (GDBusConnection *connection,
}
}
backend->notifications = g_slist_remove (backend->notifications, n);
freedesktop_notification_free (n);
/* Get the notification again in case the action redrew it */
n = g_fdo_notification_backend_find_notification_by_notify_id (backend, id);
if (n != NULL)
{
backend->notifications = g_slist_remove (backend->notifications, n);
freedesktop_notification_free (n);
}
}
/* Converts a GNotificationPriority to an urgency level as defined by