luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-28 23:16:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

gfileutils: Add an assertion to help static analysis

Browse Source 
This assertion basically mirrors the existing `buffer_size >= 2`
assertion (one implies the other), but scan-build doesn’t seem to be
able to work that out — so give it some help.

Fixes:
```
../../../glib/gfileutils.c: In function ‘g_get_current_dir’:
../../../glib/gfileutils.c:2995:17: warning: potential null pointer dereference [-Wnull-dereference]
 2995 |       buffer[1] = 0;
      |       ~~~~~~~~~~^~~
../../../glib/gfileutils.c:2994:17: warning: potential null pointer dereference [-Wnull-dereference]
 2994 |       buffer[0] = G_DIR_SEPARATOR;
```

Signed-off-by: Philip Withnall <pwithnall@gnome.org>
This commit is contained in:
Philip Withnall 2024-12-31 12:45:42 +00:00
parent 68388cf7f7
commit 1ab1cd6ba4
No known key found for this signature in database
GPG Key ID: C5C42CFB268637CA
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
glib/gfileutils.c
View File

@ -2991,6 +2991,7 @@ g_get_current_dir (void)
{
/* Fallback return value */
g_assert (buffer_size >= 2);
g_assert (buffer != NULL);
buffer[0] = G_DIR_SEPARATOR;
buffer[1] = 0;
}