luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-25 19:52:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Work around test failure in gdbus-names"

Browse Source 
This reverts commit c37cd19feee3a609fec8909f01df8755052c59ab.

Now that we've reverted the commit "gtestdbus: Properly close server
connections", g_test_dbus_down() no longer returns early and we no
longer need this workaround. Since the gdbus-names test seems to
properly unref its GDBusConnection objects it's not clear to me why it
needed the sleep to succeed. However even at the time the failure wasn't
reproducible according to this comment[1] so it's probably not worth
spending more effort trying to reproduce it now.

[1] https://gitlab.gnome.org/GNOME/glib/issues/787#note_214235
This commit is contained in:
Matthew Leeds 2019-07-01 15:55:10 -07:00
parent d03025ba10
commit 1c63d5d539
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gio/tests/gdbus-names.c
View File

@ -472,9 +472,6 @@ test_bus_own_name (void)
g_object_unref (c2);
session_bus_down ();
/* See https://bugzilla.gnome.org/show_bug.cgi?id=711807 */
g_usleep (1000000);
}
/* ---------------------------------------------------------------------------------------------------- */