luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-09-19 16:56:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix an off-by-2 error in the leap year calculation. (#344905, Dan Winship)

Browse Source 
2006-06-20  Matthias Clasen  <mclasen@redhat.com>

	* glib/gtimer.c (mktime_utc): Fix an off-by-2 error
	in the leap year calculation.  (#344905, Dan Winship)

	* tests/testglib.c (main): Change the test data for
	the g_time_val_from_iso8601 tests to expose an off-by-2
	error in the leap year calculation.
This commit is contained in:
Matthias Clasen 2006-06-20 16:37:43 +00:00 committed by Matthias Clasen
parent de6a4865a0
commit 1f536d2f12
4 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,5 +1,12 @@
2006-06-20 Matthias Clasen <mclasen@redhat.com>
* glib/gtimer.c (mktime_utc): Fix an off-by-2 error
in the leap year calculation. (#344905, Dan Winship)
* tests/testglib.c (main): Change the test data for
the g_time_val_from_iso8601 tests to expose an off-by-2
error in the leap year calculation.
* configure.in: Bump version
* === Released 2.11.4 ===

7
ChangeLog.pre-2-12
View File

@ -1,5 +1,12 @@
2006-06-20 Matthias Clasen <mclasen@redhat.com>
* glib/gtimer.c (mktime_utc): Fix an off-by-2 error
in the leap year calculation. (#344905, Dan Winship)
* tests/testglib.c (main): Change the test data for
the g_time_val_from_iso8601 tests to expose an off-by-2
error in the leap year calculation.
* configure.in: Bump version
* === Released 2.11.4 ===

2
glib/gtimer.c
View File

@ -333,7 +333,7 @@ mktime_utc (struct tm *tm)
retval += (tm->tm_year - 68) / 4;
retval += days_before[tm->tm_mon] + tm->tm_mday - 1;
if (tm->tm_year % 4 == 2 && tm->tm_mon < 2)
if (tm->tm_year % 4 == 0 && tm->tm_mon < 2)
retval -= 1;
retval = ((((retval * 24) + tm->tm_hour) * 60) + tm->tm_min) * 60 + tm->tm_sec;

8
tests/testglib.c
View File

@ -1178,10 +1178,10 @@ main (int argc,
g_timer_destroy(timer);
g_timer_destroy(timer2);
#define REF_SEC_UTC 343737360
#define REF_STR_UTC "1980-11-22T10:36:00Z"
#define REF_STR_CEST "1980-11-22T12:36:00+02:00"
#define REF_STR_EST "1980-11-22T05:36:00-05:00"
#define REF_SEC_UTC 320063760
#define REF_STR_UTC "1980-02-22T10:36:00Z"
#define REF_STR_CEST "1980-02-22T12:36:00+02:00"
#define REF_STR_EST "1980-02-22T05:36:00-05:00"
g_print ("checking g_time_val_from_iso8601...\n");
ref_date.tv_sec = REF_SEC_UTC;