luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 11:26:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

hash: Remove an assertion from the hot path

Browse Source 
This assert is using atomics and was showing up
in some cache-heavy GTK profiles. Remove it.
This commit is contained in:
Matthias Clasen 2019-10-10 06:56:38 -04:00 committed by Philip Withnall
parent b50447b0ab
commit 1fb3628fb3
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
glib/ghash.c
View File

@ -463,13 +463,6 @@ g_hash_table_lookup_node (GHashTable *hash_table,
gboolean have_tombstone = FALSE;
guint step = 0;
/* If this happens, then the application is probably doing too much work
* from a destroy notifier. The alternative would be to crash any second
* (as keys, etc. will be NULL).
* Applications need to either use g_hash_table_destroy, or ensure the hash
* table is empty prior to removing the last reference using g_hash_table_unref(). */
g_assert (!g_atomic_ref_count_compare (&hash_table->ref_count, 0));
hash_value = hash_table->hash_func (key);
if (G_UNLIKELY (!HASH_IS_REAL (hash_value)))
hash_value = 2;